glusterfs.git/xlators/mgmt/glusterd/src/glusterd-server-quorum.c, branch v4.0dev

glusterd: fix quorum calculation if percentage is not specified correctly

2017-06-14T12:49:29+00:00

There was an extra "ratio = _gf_true".

- In case the ratio was specified correctly
  in the volfile, this is redundant.
- In case the ratio was specified, but not parseable
  into a precentage, this is wrong and would
  lead to a quorum count of 0 instead of falling
  back to the default of 50% + 1.

This patch removes the extra setting of "ratio".

Change-Id: I2bd57ebf1b8989e905481a2b6285a1f422942f72
BUG: 1461129
Signed-off-by: Michael Adam 
Reviewed-on: https://review.gluster.org/17538
Reviewed-by: Atin Mukherjee 
Tested-by: Atin Mukherjee 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Smoke: Gluster Build System

glusterd (server-quorum): fix unused variable warnings/errors

2016-09-05T13:08:09+00:00

http://review.gluster.org/14085 fixes a/the "leak" - via the
generated rpc/xdr headers - of pragmas that mask these warnings.

However 14085 won't pass the smoke test until all the warnings are
fixed.

Change-Id: I53961a9ddbba824ea3cfa00abbba20109da5de89
BUG: 1369124
Signed-off-by: Kaleb S. KEITHLEY 
Reviewed-on: http://review.gluster.org/15276
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Smoke: Gluster Build System 
Reviewed-by: Atin Mukherjee

glusterd: add async events (part 2)

2016-08-23T14:48:01+00:00

Change-Id: I7a5687143713c283f0051aac2383f780e3e43646
BUG: 1360809
Signed-off-by: Atin Mukherjee 
Reviewed-on: http://review.gluster.org/15153
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Samikshan Bairagya

glusterd: Don't start bricks if server quorum is not met

2016-07-05T11:56:58+00:00

Upon glusterd restart if it is observered that the server quorum
isn't met anymore due to changes to the "server-quorum-ratio"
global option, the bricks should be stopped if they are running.
Also if glusterd has been restarted, and if server quorum is not
applicable for a volume, do not restart the bricks corresponding
to the volume to make sure that bricks that have been brought
down purposely, say for maintenance, are not brought up. This
commit moves this check that was previously inside
"glusterd_spawn_daemons" to "glusterd_restart_bricks" instead.

Change-Id: I0a44a2e7cad0739ed7d56d2d67ab58058716de6b
BUG: 1345727
Signed-off-by: Samikshan Bairagya 
Reviewed-on: http://review.gluster.org/14758
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Jeff Darcy

glusterd: check quorum on restart bricks

2016-02-05T15:26:42+00:00

While spawning bricks on a glusterd restart the quorum should be checked and
brick shouldn't be started if the volume doesn't meet quorum.

Change-Id: I21bf9055bdf38c53c81138cc204ba05a9ff6444f
BUG: 1298439
Signed-off-by: Atin Mukherjee 
Reviewed-on: http://review.gluster.org/13236
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Jeff Darcy

all: reduce "inline" usage

2015-09-01T11:55:15+00:00

There are three kinds of inline functions: plain inline, extern inline,
and static inline.  All three have been removed from .c files, except
those in "contrib" which aren't our problem.  Inlines in .h files, which
are overwhelmingly "static inline" already, have generally been left
alone.  Over time we should be able to "lower" these into .c files, but
that has to be done in a case-by-case fashion requiring more manual
effort.  This part was easy to do automatically without (as far as I can
tell) any ill effect.

In the process, several pieces of dead code were flagged by the
compiler, and were removed.

Change-Id: I56a5e614735c9e0a6ee420dab949eac22e25c155
BUG: 1245331
Signed-off-by: Jeff Darcy 
Reviewed-on: http://review.gluster.org/11769
Tested-by: NetBSD Build System 
Reviewed-by: Dan Lambright 
Reviewed-by: Kaleb KEITHLEY 
Reviewed-by: Niels de Vos 
Reviewed-by: Raghavendra Bhat 
Reviewed-by: Venky Shankar

glusterd: fix quorum calculation logic

2015-06-25T03:30:13+00:00

glusterd_get_quorum_cluster_counts () skips quorum calculation if it finds any
of its peer in QUORUM_WAITING state. This means if any peer probe has been
triggered and at the same point of time a transaction has been initiated, it
might pass through the server quorum check which it should not.

Change-Id: I44eda8905eab3349c9ebf2842e7131d4e758a528
BUG: 1232686
Signed-off-by: Atin Mukherjee 
Reviewed-on: http://review.gluster.org/11275
Reviewed-by: Krishnan Parthasarathi 
Reviewed-by: Anand Nekkunti 
Tested-by: NetBSD Build System

build: do not #include "config.h" in each file

2015-05-29T12:43:17+00:00

Instead of including config.h in each file, and have the additional
config.h included from the compiler commandline (-include option).

When a .c file tests for a certain #define, and config.h was not
included, incorrect assumtions were made. With this change, it can not
happen again.

BUG: 1222319
Change-Id: I4f9097b8740b81ecfe8b218d52ca50361f74cb64
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/10808
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System
Reviewed-by: Kaleb KEITHLEY 
Reviewed-by: Pranith Kumar Karampuri

glusterd: compute quorum on peers in cluster

2015-04-02T17:58:13+00:00

... and not on peers participating in an ongoing
transaction.

Change-Id: I6bdb80fd3bf3e7593fdf37e45a441d4a490469b8
BUG: 1205592
Signed-off-by: Kaushal M 
Reviewed-on: http://review.gluster.org/9493
Reviewed-by: Atin Mukherjee 
Tested-by: Gluster Build System

glusterd: Fix rebase errors introduced by 4b18fba

2015-04-02T10:10:25+00:00

4b18fba 'glusterd: group server-quorum related code together' a
refactoring change, introduced some errors related to usage of
userspace-rcu lists when rebasing. This patch fixes it.

Changes done include,
- Redo changes done by
  673ba26 glusterd: Replace libglusterfs lists with liburcu lists
- Redo changes done by
  c7785f7 glusterd: Protect the peer list and peerinfos with RCU.
- Redo changes done by
  891c7d0 glusterd: Prevent possible deadlock due to
          glusterd_quorum_count

Change-Id: I789e5bc8b209d9ed6dd951d609baa90e89817639
BUG: 1205592
Signed-off-by: Vijay Bellur 
Signed-off-by: Kaushal M 
Reviewed-on: http://review.gluster.org/10105
Reviewed-by: Atin Mukherjee 
Reviewed-by: Niels de Vos 
Tested-by: Gluster Build System