glusterfs.git/xlators/mgmt/glusterd/src/glusterd-snapshot.c, branch v3.8.8

snapshot: Fix for memory leaks in snapshot code path

2016-11-04T06:05:16+00:00

> Reviewed-on: http://review.gluster.org/15668
> NetBSD-regression: NetBSD Build System 
> CentOS-regression: Gluster Build System 
> Smoke: Gluster Build System 
> Reviewed-by: Rajesh Joseph 

(cherry picked from commit 48a4c4e525665115f7e8c478d3bf51764427378d)

Change-Id: Idc2cb16574d166e3c0ee1f7c3a485f1acb19fc8c
BUG: 1388354
Signed-off-by: Avra Sengupta 
Reviewed-on: http://review.gluster.org/15720
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Rajesh Joseph

snapshot/cli: Fix snapshot status xml output

2016-08-24T10:15:12+00:00

    Backport of http://review.gluster.org/#/c/14018/

snap status --xml errors out if a brick is down and
doesn't have pid. It is handled in the cli of the snap
status where "N/A" is displayed in such a scenario.
Handled the same in xml

snap status  --xml fails as the writer is
not initialised for the same. Using GF_SNAP_STATUS_TYPE_ITER
instead of GF_SNAP_STATUS_TYPE_SNAP for all snap's
status to differentiate between the two scenarios.

Added testcase volume-snapshot-xml.t to check
all snapshot commands xml outputs

> Reviewed-on: http://review.gluster.org/14018
> Smoke: Gluster Build System 
> CentOS-regression: Gluster Build System 
> NetBSD-regression: NetBSD Build System 
> Reviewed-by: Rajesh Joseph 

Change-Id: I99563e8f3e84f1aaeabd865326bb825c44f5c745
BUG: 1369372
Signed-off-by: Avra Sengupta 
Reviewed-on: http://review.gluster.org/15291
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Rajesh Joseph

glusterd/snapshot: remove quota related options from snap volfile

2016-06-04T03:39:29+00:00

enabling inode-quota on a snapshot volume is unnecessary, because
snapshot is a read-only volume. So we don't need to enforce quota
on a snapshot volume.

This patch will remove the quota related options from snapshot
volfile.

Backport of>
>Change-Id: Iddabcb83820dac2384924a01d45abe1ef1e95600
>BUG: 1341796
>Signed-off-by: Mohammed Rafi KC 
>Reviewed-on: http://review.gluster.org/14608
>Reviewed-by: Atin Mukherjee 
>Reviewed-by: N Balachandran 
>NetBSD-regression: NetBSD Build System >
>Smoke: Gluster Build System 
>CentOS-regression: Gluster Build System 
>Reviewed-by: Rajesh Joseph 

(cherry picked from commit 03d523504230c336cf585159266e147945f31153)

Change-Id: I68b54cc3e9a5420d6b3550b08fd65c3c44a130cf
BUG: 1342372
Signed-off-by: Mohammed Rafi KC 
Reviewed-on: http://review.gluster.org/14628
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Atin Mukherjee 
Reviewed-by: Rajesh Joseph 
CentOS-regression: Gluster Build System

clone/snapshot: Save restored_from_snap for clones

2016-04-25T08:42:46+00:00

Bricks of cloned volumes are lvm bricks mounted in
/run/gluster, which on reboot of the node gets
cleared. Hence, these brick paths need to be recreated
on glusterd restart and the appropriate lvms are
mounted.

Change-Id: I6da086288c0dbdcedf3a20fd53f25e3728bea473
BUG: 1328010
Signed-off-by: Avra Sengupta 
Reviewed-on: http://review.gluster.org/14021
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Rajesh Joseph

snapshot/quota: Copy quota.cksum during snapshot operations

2016-04-22T05:51:08+00:00

A volume having a quota.conf file, should always have
a quota.cksum file too. Based on this above assumption
modifying glusterd_copy_quota_files() to always copy
quota.cksum, if quota.conf is present.

This change will be reflected when a snapshot is created,
restored and cloned.

Change-Id: Ia49dc26eacef32eeb8f7d7d9553c80e304b08779
BUG: 1316848
Signed-off-by: Avra Sengupta 
Reviewed-on: http://review.gluster.org/13760
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Vijaikumar Mallikarjuna 
Reviewed-by: Rajesh Joseph

glusterd: remove unused large memory/buffer allocations

2016-03-24T09:28:22+00:00

This patch cleans dead buffer allocations which are never used in the
code.

Change-Id: I8c55837434fd5bf9dde9fb7b070fdefbf64cf4a3
BUG: 1253828
Signed-off-by: Prasanna Kumar Kalever 
Reviewed-on: http://review.gluster.org/11928
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Atin Mukherjee

snapshot/cli: Keep the dict keys uniform

2016-03-14T06:19:06+00:00

snapshot info was using a different dictionary key
as compared to other snapshot commands. This was
throwing a recurring error log in cli.log

Change-Id: I9eb9a4541c10a45ec7673a23c89c85a7dce9f3ec
BUG: 1316819
Signed-off-by: Avra Sengupta 
Reviewed-on: http://review.gluster.org/13677
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Rajesh Joseph

glusterd: use string comparison for realpath checks in glusterd_is_brickpath_available

2016-02-29T11:55:23+00:00

glusterd_is_brickpath_available () used to call realpath() for checking the
whether the new brick path matches with the existing ones. The problem with this
is if the underlying file system is bad for any one of the existing bricks then
realpath() would fail and we wouldn't allow to create the new brick even if it
should be allowed.

Fix is to use string comparison with having a new field real_path in brickinfo
to store the absolute path

Change-Id: I1250ea5345f00fca0f6128056ebd08750d604f0a
BUG: 1299710
Signed-off-by: Atin Mukherjee 
Reviewed-on: http://review.gluster.org/13258
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Jeff Darcy

snapshot: Fix parent volinfo corruption in snapshot restore

2016-02-29T06:12:51+00:00

Remove parent_volinfo irrespective of success or failure
of glusterd_lvm_snapshot_remove(). This prevents the
duplication of the volinfo after the execution of
glusterd_snapshot_restore().

When commit fails on originator node, we don't perform
commit on the other nodes, as a result we don't have a
backup of /var/lib/glusterd/vols/ in the
GLUSTERD_TRASH in other nodes. But in the postvalidate
we try to restore from GLUSTED_TRASH and end up cleaning
up /var/lib/glusterd/vols/. Hence moved
glusterd_snapshot_backup_vol() from commit to prevalidate,
so that the backup is always available when a cleanup is
needed.

Change-Id: Icd471b23faf02bad680b9a1aadc4a0175f7cce8b
BUG: 1300979
Signed-off-by: Avra Sengupta 
Reviewed-on: http://review.gluster.org/13282
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Rajesh Joseph

Snapshot:wrong logging is used

2016-02-23T05:36:01+00:00

Change-Id: I56e5f5696fbbb4290f95adb9b68f9e43ed037ed3
BUG: 1189473
Signed-off-by: Mohammed Rafi KC 
Reviewed-on: http://review.gluster.org/9861
Smoke: Gluster Build System 
Reviewed-by: Kaleb KEITHLEY 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Rajesh Joseph