glusterfs.git/xlators/mgmt/glusterd/src/glusterd-utils.c, branch v3.3.2qa1

localtime and ctime are not MT-SAFE

2013-02-08T20:04:42+00:00

There are a number of nit-level issues throughout the source with
the use of localtime and ctime. While they apparently aren't causing
too many problems, apart from the one in bz 828058, they ought to be
fixed. Among the "real" problems that are fixed in this patch:
1) general localtime and ctime not MT-SAFE. There's a non-zero chance
   that another thread calling localtime (or ctime) will over-write
   the static data about to be used in another thread
2) localtime(& <64-bit-type>) or ctime(& <64-bit-type>) generally
   not a problem on 64-bit or little-endian 32-bit. But even though
   we probably have zero users on big-ending 32-bit platforms, it's
   still incorrect.
3) multiple nested calls passed as params. Last one wins, i.e. over-
   writes result of prior calls.
4) Inconsistent error handling. Most of these calls are for logging,
   tracing, or dumping. I submit that if an error somehow occurs in
   the call to localtime or ctime, the log/trace/dump still should
   still occur.
5) Appliances should all have their clocks set to UTC, and all log
   entries, traces, and dumps should use GMT.
6) fix strtok(), change to strtok_r()

Other things this patch fixes/changes (that aren't bugs per se):
1) Change "%Y-%m-%d %H:%M:%S" and similar to their equivalent shorthand,
   e.g. "%F %T"
2) change sizeof(timestr) to sizeof timestr. sizeof is an operator,
   not a function. You don't use i +(32), why use sizeof().
   (And yes, you do use parens with sizeof().)
3) change 'char timestr[256]' to 'char timestr[32]' where appropriate.
   Per-thread stack is limited. Time strings are never longer than ~20
   characters, so why waste 220+ bytes on the stack?

Things this patch doesn't fix:
1) hodgepodge of %Y-%m-%d %H:%M:%S versus %Y/%m/%d-%H%M%S and other
   variations. It's not clear to me whether this ever matters, not to
   mention 3rd party log filtering tools may already rely on a
   particular format. Still it would be nice to have a single manifest
   constant and have every call to localtime/strftime consistently use
   the same format.

BUG: 832173

Change-Id: Iee9719db4576eacc6c75694d9107954d0912cba8
Signed-off-by: Kaleb S. KEITHLEY 
Reviewed-on: http://review.gluster.org/3613
Reviewed-by: Anand Avati 
Tested-by: Anand Avati

glusterd: Expect setmntent(3) to return NULL

2012-09-09T17:41:20+00:00

- Closed the mtab FILE * using endmntent(3)

Change-Id: I5e1ebb7f092abda638cfbb5524da693dcac6c872
BUG: 851109
Signed-off-by: Krishnan Parthasarathi 
Reviewed-on: http://review.gluster.org/3922
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

rpc: Reduce frame-timeout for glusterd connections

2012-08-17T08:13:01+00:00

Reduce frame-timeout for glusterd connections from 30mins to 10 mins. 30mins is
too long when compared to cli timeout of 2mins. Changing to 10mins reduces the
disparity between cli and glusterd.

Also, fix glusterfs_submit_reply() so that a reply is sent even if serialize
failed.

BUG: 843003
Change-Id: Ie8d5ec16fbbb54318a5935a47065e66fd3338b87
Signed-off-by: Kaushal M 
Reviewed-on: http://review.gluster.com/3812
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

glusterd: Fix peer probe when username/password is missing

2012-07-18T06:46:34+00:00

Prevent failure of building volumes dictionary during peer probe, when
username/password for a volume is missing. This situation can be caused by
migration of gluster from pre-3.3 to 3.3 and above.

BUG: 834229
Change-Id: I042ecfcc5024e6b18c4ffb44ea0977ec58e22ef8
Signed-off-by: Kaushal M 
Reviewed-on: http://review.gluster.com/3629
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

glusterd: regenerate brick vol-files on upgrade

2012-05-29T05:52:54+00:00

If upgrade/downgrade option is set in glusterd it terminates
after the volfiles are regenerated. No need for 'sleep 10'
hack anymore.

Change-Id: I83b1cd83b1cc56c6d221e6f2bbbf58af62cb56b9
BUG: 825872
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.com/3472
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

glusterd: Replace-brick should create dst brick path only on 'dst' node.

2012-05-28T17:45:12+00:00

Change-Id: I61e6f8aa44dfef85c7cd98f40b176b796422c4b2
BUG: 824302
Signed-off-by: Krishnan Parthasarathi 
Reviewed-on: http://review.gluster.com/3457
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

glusterd: Cherry-picked e44ac01b08c3ee from master branch

2012-05-28T05:37:38+00:00

        Fix volume create

        Improve Krishnan Parthasarathi's patch, which fixed situation where
        a brick mount point did not had EA enabled. This fixes an incorrect
        assumption that dirname(3) returns the same address it was given as
        argument. GNU dirname(3) does it, BSD dirname(3) does not.

        Also makes the code a bit easier to read.

        Signed-off-by: Emmanuel Dreyfus 

Change-Id: Ie5106b0ee7bda126666cd0ec9c827c895ec035c9
BUG: 812214
Signed-off-by: Krishnan Parthasarathi 
Reviewed-on: http://review.gluster.com/3441
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

glusterd: Disconnected bricks of 'stale' volume before deleting it.

2012-05-28T05:33:18+00:00

If glusterd_delete_bricks is called before glusterd got the DISCONNECT event
from the brick that was stopped, then glusterd_brick_rpc_notify would
dereference a free'd brickinfo. This can happen if the brick had not been
disconnected before.

Change-Id: I6c07ec50f6739422a14478a549edd06c4c0ce913
BUG: 802015
Signed-off-by: Krishnan Parthasarathi 
Reviewed-on: http://review.gluster.com/3442
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

glusterd: Fixed glusterd_brick_create_path algo.

2012-05-19T10:27:20+00:00

- check if any prefix of the brick path has "trusted.gfid"
  or "trusted.glusterfs.volume-id" set.
- set trusted.glusterfs.volume-id on the bricks as soon as
  its induction into the volume is settled. Earlier, the setting of
  "volume-id" used to happen during the first run of the brick process,
  leaving of window for bricks part of one volume to be (ab)used by another
  volume inadvertently.
- removed creation of brick directory (if missing), during start volume force.
  This is to avoid directory creation as part 'force'ful starting of volume
  and leave the responsibility with the user, who understands the
  'availability' of the export directory (brick) better.

Change-Id: I4237ec4ea7a4e38a7501027e7de7112edd67de8c
BUG: 812214
Signed-off-by: Krishnan Parthasarathi 
Reviewed-on: http://review.gluster.com/3280
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur 
Reviewed-on: http://review.gluster.com/3313

mgmt/glusterd: Avoid re-starting nfs unconditionally.

2012-05-09T05:14:01+00:00

NFS server is restarted unconditionally when a volume option is
configured through the set interface. This patch prevents restart
of NFS server when operations are performed on translators that
are not part of the NFS graph.

This does not prevent re-start of a NFS server when an option
corresponding to a translator that is part of the NFS graph is
re-configured.

Change-Id: Ic4b8e48e5e7e80438f230521042c267ec3b96a25
Signed-off-by: Vijay Bellur 
Reviewed-on: http://review.gluster.com/3247
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra Bhat 
Reviewed-by: Anand Avati