glusterfs.git/xlators/mgmt/glusterd/src/glusterd.c, branch v3.4.0alpha

geo-rep / gsyncd: Separate log file directory for Mountbroker sessions

2013-02-05T01:34:56+00:00

... so that a mountbroker session which is initiated b/w master
and slave does not use the same log file if it's started after
a normal geo-rep session b/w master and slave. This results in
EPERM as the log file is owned by root and the geo-rep slave
process (now running as a non privileged user) does not have
access to it.

Also, having separate log file directory for mountbroker sessions
looks clean.

NOTE: geo-rep's client mount log file location remains unchanged.

Change-Id: Ic7a732e250aee5393b9c3f6ebf6dfe2c310b7fe4
BUG: 893960
Signed-off-by: Venky Shankar 
Reviewed-on: http://review.gluster.org/4407
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

glusterd/cli: Updated the options descriptions for "volume set help"

2013-01-22T07:03:57+00:00

Change-Id: I0db00b7334bb9707ab48bd661ac03a3ad818d6e4
BUG: 893458
Signed-off-by: Avra Sengupta 
Reviewed-on: http://review.gluster.org/4393
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

core: fixes for gcc's '-pedantic' flag build

2013-01-22T06:17:36+00:00

* warnings on 'void *' arguments
* warnings on empty initializations
* warnings on empty array (array[0])

Change-Id: Iae440f54cbd59580eb69f3ecaed5a9926c0edf95
BUG: 875913
Signed-off-by: Avra Sengupta 
Reviewed-on: http://review.gluster.org/4219
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

glusterd: replace obsolete /usr/local reference for remote ssh/gsyncd

2013-01-18T21:17:51+00:00

See https://bugzilla.redhat.com/show_bug.cgi?id=895656
    https://bugzilla.redhat.com/show_bug.cgi?id=764679 (GLUSTER-2947)
    https://bugzilla.redhat.com/show_bug.cgi?id=764623 (GLUSTER-2891)

The comments in the bzs are a bit obtuse and/or vague. As near as I
can make out we had, for a while, a "convenience symlink" to or from
/usr/local/libexec/gsyncd, which no longer exists.

And, lacking any comments in the code, I gather this is some sort of
fallback or failsafe logic: if the first, normal attempt to invoke gsyncd
fails then an attempt is made to ssh to the box and invoke it.

In any event, there's nothing in /usr/local/... so it's unquestionably
wrong to try to invoke anything there.

BUG: 895656
Change-Id: I3b7ac7a049b91ce101b930599294830147cc60ad
Signed-off-by: Kaleb S. KEITHLEY 
Reviewed-on: http://review.gluster.org/4392
Reviewed-by: Niels de Vos 
Tested-by: Gluster Build System 
Reviewed-by: Joe Julian 
Reviewed-by: Anand Avati

glusterd: log enhancements for volume start

2013-01-04T15:26:25+00:00

* changed some of the log messages to give as much information as
  available in case of failure

* added logs to identify on which machine lock/stage/commit failed

* added macros to represent error strings to maintain uniformity
  among error messages for a given kind of error

* moved error logs wherever possible, from caller to callee to avoid
  code duplication

Change-Id: I0e98d5d3ba086c99240f2fbd642451f175f51942
BUG: 812356
Signed-off-by: Krutika Dhananjay 
Reviewed-on: http://review.gluster.org/4353
Reviewed-by: Pranith Kumar Karampuri 
Reviewed-by: Vijay Bellur 
Tested-by: Vijay Bellur

glusterd, cli: Task id's for async tasks

2012-12-19T21:32:49+00:00

This patch introduces task-id's for async tasks like rebalance, remove-brick and
replace-brick. An id is generated for each task when it is started and displayed
to the user in cli output. The status of running tasks is also included in the
output of "volume status" along with its id, so that a user can easily track the
progress of an async task.

Also,
 * added tests for this feature into the regression test suite.
 * added a python script for creating files, 'create-files.py', courtesy
   Vijaykumar Koppad (vkoppad@redhat.com) into the test suite.

This patch reverts the revert commit 698deb33d731df6de84da8ae8ee4045e1543a168.

BUG: 857330
Change-Id: Id43d7cb629a38f47f733fbc18cb4c5f2f0327c7a
Signed-off-by: Kaushal M 
Reviewed-on: http://review.gluster.org/4294
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

Revert "glusterd, cli: Task id's for async tasks"

2012-12-04T23:59:52+00:00

This reverts commit ed15521d4e5af2b52b78fd33711e7562f5273bc6

Strangely, the test scripts are "silently" passing for failures too. Reverting patch for now.

Change-Id: I802ec1634c7863dc373cc7dc4a47bd4baa72764e
Reviewed-on: http://review.gluster.org/4267
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

glusterd, cli: Task id's for async tasks

2012-12-04T22:44:36+00:00

This patch introduces task-id's for async tasks like rebalance, remove-brick and
replace-brick. An id is generated for each task when it is started and displayed
to the user in cli output. The status of running tasks is also included in the
output of "volume status" along with its id, so that a user can easily track the
progress of an async task.

Also,
 * added tests for this feature into the regression test suite.
 * added a python script for creating files, 'create-files.py', courtesy
   Vijaykumar Koppad (vkoppad@redhat.com) into the test suite.

Change-Id: Ib0c0d12e0d6c8f72ace48d303d7ff3102157e876
BUG: 857330
Signed-off-by: Kaushal M 
Reviewed-on: http://review.gluster.org/3942
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

mgmt/glusterd: Consider nodesvc to be running after online

2012-11-30T01:34:54+00:00

Definition of online in the message below is that the
RPC_CLNT_CONNECT event arrives for the nfs/self-heal-daemon process.

For automated tests, sometimes the script needs to wait until
self-heal-daemon comes online, so that the relevant
commands can be executed. Gluster volume status before this change
printed whether the self-heal-daemon is running or not based on the
lock availability on the pidfile. But there is a small window where
the lock on pid file is present but the process is still not
online. So the commands that were depending on this kept failing in
the test script.

Change-Id: I0e44e18b08d7b653d34fa170c1f187d91c888cd9
BUG: 858212
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/4236
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

geo-rep / gsyncd,glusterd: do not hardcode socket path

2012-11-29T00:54:07+00:00

... in gsyncd python code. Indeed, use the configuration
mechanism to set it suitably from glusterd.

Change-Id: I9fe2088b14d28588d1e64fe892740cc5755b8365
BUG: 868877
Signed-off-by: Csaba Henk 
Reviewed-on: http://review.gluster.org/4143
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati