glusterfs.git/xlators/mgmt/glusterd/src/glusterd.h, branch v3.7.2

glusterd: Buffer overflow causing crash for glusterd

2015-06-19T01:30:28+00:00

Backport of http://review.gluster.org/11090

Problem: In GLUSTERD_GET_DEFRAG_PROCESS we are using PATH_MAX (4096)
as the max size of the input for target path, but we have allocated
NAME_MAX (255) size of buffer for the target.

Now this crash is not seen with source, but seen with RPMS.
The reason is _foritfy_fail. This check happens when _FORTIFY_SOURCE
is enabled. This option tries to figure out possible
overflow scenarios like the bug here and does crash the process.

BUG: 1227677
Change-Id: I50cf83cb60c640e46cc7a1a8d3a8321b9147fba9
Signed-off-by: Susant Palai 
Reviewed-on: http://review.gluster.org/11091
Reviewed-by: Atin Mukherjee 
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System

glusterd/snapshot: Return correct errno in events of failure - PATCH 2

2015-06-09T14:18:38+00:00

       Backport of http://review.gluster.org/#/c/10588/

ENUM           RETCODE        ERROR
-------------------------------------------------------------
EG_INTRNL      30800          Internal Error
EG_OPNOTSUP    30801          Gluster Op Not Supported
EG_ANOTRANS    30802          Another Transaction in Progress
EG_BRCKDWN     30803          One or more brick is down
EG_NODEDWN     30804          One or more node is down
EG_HRDLMT      30805          Hard Limit is reached
EG_NOVOL       30806          Volume does not exist
EG_NOSNAP      30807          Snap does not exist
EG_RBALRUN     30808          Rebalance is running
EG_VOLRUN      30809          Volume is running
EG_VOLSTP      30810          Volume is not running
EG_VOLEXST     30811          Volume exists
EG_SNAPEXST    30812          Snapshot exists
EG_ISSNAP      30813          Volume is a snap volume
EG_GEOREPRUN   30814          Geo-Replication is running
EG_NOTTHINP    30815          Bricks are not thinly provisioned

Change-Id: I49a170cdfd77df11fe677e09f4e063d99b159275
BUG: 1226117
Signed-off-by: Avra Sengupta 
(cherry picked from commit 2df57ab7dc7b9d7deb0eebad96036149760d607b)
Reviewed-on: http://review.gluster.org/11042
Tested-by: Gluster Build System 
Reviewed-by: Rajesh Joseph 
Tested-by: NetBSD Build System 
Reviewed-by: Krishnan Parthasarathi

glusterd/shared_storage: Provide a volume set option to create and mount the shared storage

2015-06-05T09:20:26+00:00

     Backport of http://review.gluster.org/#/c/10793/

Introducing a global volume set option(cluster.enable-shared-storage)
which helps create and set-up the shared storage meta volume.

gluster volume set all cluster.enable-shared-storage enable

On enabling this option, the system analyzes the number of peers
in the cluster, which are currently connected, and chooses three
such peers(including the node the command is issued from). From these
peers a volume(gluster_shared_storage) is created. Depending on the
number of peers available the volume is either a replica 3
volume(if there are 3 connected peers),  or a replica 2 volume(if there
are 2 connected peers). "/var/run/gluster/ss_brick" serves as the
brick path on each node for the shared storage volume. We also mount
the shared storage at "/var/run/gluster/shared_storage" on all the nodes
in the cluster as part of enabling this option. If there is only one node
in the cluster,  or only one node is up then the command will fail

Once the volume is created, and mounted the maintainance of the
volume like adding-bricks, removing bricks etc., is expected to
be the onus of the user.

On disabling the option, we provide the user a warning, and on
affirmation from the user we stop the shared storage volume, and unmount
it from all the nodes in the cluster.

gluster volume set all cluster.enable-shared-storage disable

Change-Id: Idd92d67b93f444244f99ede9f634ef18d2945dbc
BUG: 1228181
Signed-off-by: Avra Sengupta 
Reviewed-on: http://review.gluster.org/11086
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Rajesh Joseph 
Reviewed-by: Krishnan Parthasarathi

tiering/rebalance: Use separate pid/socket file for tiering

2015-06-01T04:38:26+00:00

        Back port of http://review.gluster.org/10792

When promotion/demotion daemon starts, it uses the same pidfile
as rebalance. This patch will introduce a different pid file
for the same.

 >Change-Id: Ic484c53f51e00ae6b2d697748a9600b14829e23b
 >BUG: 1221970
 >Signed-off-by: Mohammed Rafi KC 
 >Reviewed-on: http://review.gluster.org/10792
 >Reviewed-by: Atin Mukherjee 
 >Tested-by: Gluster Build System 
 >Tested-by: NetBSD Build System

Change-Id: Idda13e983ffd443672aee0873ee51e8cc7089c49
BUG: 1221969
Signed-off-by: Mohammed Rafi KC 
Reviewed-on: http://review.gluster.org/10980
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Joseph Fernandes
Reviewed-by: Kaushal M

glusterd: add counter support for tiered volumes

2015-05-28T07:25:29+00:00

        back port of http://review.gluster.org/10292

This fix adds support to view the number of promoted or demoted
files from the cli. The mechanism is isolmorphic to checking
the status of volumes being rebalanced.

gluster volume rebalance  tier status

 >Change-Id: I1b11ca27355ceec36c488967c23531202030e205
 >BUG: 1213063
 >Signed-off-by: Mohammed Rafi KC 
 >Signed-off-by: Dan Lambright 
 >Reviewed-on: http://review.gluster.org/10292
 >Reviewed-by: Atin Mukherjee 
 >Tested-by: Gluster Build System 

Change-Id: I543e886f17132b544274c83fdecca5a8da9d092a
BUG: 1221477
Signed-off-by: Mohammed Rafi KC 
Signed-off-by: Dan Lambright 
Reviewed-on: http://review.gluster.org/10775
Tested-by: Gluster Build System 
Reviewed-by: Atin Mukherjee

dht: make lookup-unhashed=auto do something actually useful

2015-05-10T04:55:09+00:00

The key concept here is to determine whether a directory is "clean" by
comparing its last-known-good topology to the current one for the
volume.  These are stored as "commit hashes" on the directory and the
volume root respectively.  The volume's commit hash changes whenever a
brick is added or removed, and a fix-layout is done.  A directory's
commit hash changes only when a full rebalance (not just fix-layout)
is done on it.  If all bricks are present and have a directory
commit hash that matches the volume commit hash, then we can assume
that every file is in its "proper" place. Therefore, if we look for
a file in that proper place and don't find it, we can assume it's not
on any other subvolume and *safely* skip the global (broadcast to all)
lookup.

Change-Id: Id6ce4593ba1f7daffa74cfab591cb45960629ae3
BUG: 1220064
Reviewed-on-master: http://review.gluster.org/#/c/7702/
Signed-off-by: Jeff Darcy 
Signed-off-by: Shyam 
Reviewed-on: http://review.gluster.org/10729
Tested-by: Gluster Build System 
Reviewed-by: Krishnan Parthasarathi 
Reviewed-by: Vijay Bellur

cli/tiering: volume info should display details about tier

2015-05-10T04:50:45+00:00

        Back port of http://review.gluster.org/#/c/10339/

>> gluster volume info patchy

Volume Name: patchy
Type: Tier
Volume ID: 8bf1a1ca-6417-484f-821f-18973a7502a8
Status: Created
Number of Bricks: 8
Transport-type: tcp
Hot Tier :
Hot Tier Type : Replicate
Number of Bricks: 1 x 2 = 2
Brick1: hostname:/home/brick30
Brick2: hostname:/home/brick31
Cold Bricks:
Cold Tier Type : Disperse
Number of Bricks: 1 x (4 + 2) = 6
Brick3: hostname:/home/brick20
Brick4: hostname:/home/brick21
Brick5: hostname:/home/brick23
Brick6: hostname:/home/brick24
Brick7: hostname:/home/brick25
Brick8: hostname:/home/brick26

Change-Id: I7b9025af81263ebecd641b4b6897b20db8b67195
BUG: 1219842
Signed-off-by: Mohammed Rafi KC 
Reviewed-on: http://review.gluster.org/10676
Reviewed-by: Dan Lambright 
Tested-by: NetBSD Build System
Tested-by: Gluster Build System

glusterd: remove replace brick with data migration support form cli/glusterd

2015-05-07T07:08:07+00:00

Replace-brick operation with data migration support have been
deprecated from gluster.

With this fix replace brick command will support only one commad

gluster volume replace-brick    {commit force}

Change-Id: Ib81d49e5d8e7eaa4ccb5830cfec2bc081191b43b
BUG: 1218602
Signed-off-by: Gaurav Kumar Garg 
Reviewed-on: http://review.gluster.org/10577
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System
Reviewed-by: Kaushal M

glusterd: gluster volume status should show status of bitrot and scrubber daemon

2015-05-07T03:59:46+00:00

Command gluster volume status  should show the status of bitrot
and scrubber daemon and its pid information.

Along with displaying bitrot and scrubber daemon information in gluster
volume status command there should be command to show its individual status
separately.
Command to show individual status of bitrot and scrubber daemon will
following.

command to show only bitd daemon information will be
gluster volume status  bitd

command to show only scrubber daemon information
gluster volume status  scrub

Change-Id: Id86aae1156c8c599347c98e2a538f294d37376e4
BUG: 1218123
Signed-off-by: Gaurav Kumar Garg 
Reviewed-on: http://review.gluster.org/10175
Reviewed-by: Kaushal M 
Tested-by: Kaushal M 
(cherry picked from commit da1416051d19d612d131acfde8589bc8658979b5)
Reviewed-on: http://review.gluster.org/10519
Tested-by: Gluster Build System

glusterd: Use uint32_t for peerinfo generation number

2015-05-06T17:47:17+00:00

Using a uint64_t for the peerinfo generation number was overkill for how
the generation number is used within GlusterD. It also prevented
GlusterD from running on 32-bit architechtures, as uatomic_add_return
doesn't support 64-bit values on 32-bit architechtures.

This change was developed on the git branch at [1]. This commit is a
combination of the following commits on the development branch.
  b78dba4 Use 32-bit generation number
  2c37e4b Change other generation number variables to uint32_t

[1]: https://github.com/kshlm/glusterfs/tree/urcu

Change-Id: I0f310f56a4fb97d6bcbc23255a379ed5bb1ed9e1
BUG: 1218031
Signed-off-by: Kaushal M 
Reviewed-on: http://review.gluster.org/10426
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur