glusterfs.git/xlators/mgmt/glusterd/src, branch v3.6.4beta2

core: fix Ubuntu code audit (cppcheck) results

2015-06-10T12:03:01+00:00

See also http://review.gluster.org/#/c/8064/, BZ 1109180, and
http://review.gluster.org/#/c/7693/, BZ 1091677

AFAICT these are false positives:

[geo-replication/src/gsyncd.c:100]: (error) Memory leak: str
[geo-replication/src/gsyncd.c:403]: (error) Memory leak: argv
[xlators/nfs/server/src/nlm4.c:1201]: (error) Possible null pointer dereference: fde
[xlators/cluster/afr/src/afr-self-heal-common.c:138]: (error) Possible null pointer dereference: __ptr
[xlators/cluster/afr/src/afr-self-heal-common.c:140]: (error) Possible null pointer dereference: __ptr
[xlators/cluster/afr/src/afr-self-heal-common.c:331]: (error) Possible null pointer dereference: __ptr

Test program:

[extras/test/test-ffop.c:27]: (error) Buffer overrun possible for long command line arguments.
[tests/basic/fops-sanity.c:55]: (error) Buffer overrun possible for long command line arguments.

the remainder are fixed with this change-set:

[cli/src/cli-rpc-ops.c:8883]: (error) Possible null pointer dereference: local
[cli/src/cli-rpc-ops.c:8886]: (error) Possible null pointer dereference: local
[contrib/uuid/gen_uuid.c:369]: (warning) %ld in format string (no. 2) requires 'long *' but the argument type is 'unsigned long *'.
[contrib/uuid/gen_uuid.c:369]: (warning) %ld in format string (no. 3) requires 'long *' but the argument type is 'unsigned long *'.
[xlators/cluster/dht/src/dht-rebalance.c:1734]: (error) Possible null pointer dereference: ctx
[xlators/cluster/stripe/src/stripe.c:4940]: (error) Possible null pointer dereference: local
[xlators/mgmt/glusterd/src/glusterd-geo-rep.c:1718]: (error) Possible null pointer dereference: command
[xlators/mgmt/glusterd/src/glusterd-replace-brick.c:942]: (error) Resource leak: file
[xlators/mgmt/glusterd/src/glusterd-replace-brick.c:1026]: (error) Resource leak: file
[xlators/mgmt/glusterd/src/glusterd-sm.c:249]: (error) Possible null pointer dereference: new_ev_ctx
[xlators/mgmt/glusterd/src/glusterd-snapshot.c:6917]: (error) Possible null pointer dereference: volinfo
[xlators/mgmt/glusterd/src/glusterd-utils.c:4517]: (error) Possible null pointer dereference: this
[xlators/mgmt/glusterd/src/glusterd-utils.c:6662]: (error) Possible null pointer dereference: this
[xlators/mgmt/glusterd/src/glusterd-utils.c:7708]: (error) Possible null pointer dereference: this
[xlators/mount/fuse/src/fuse-bridge.c:4687]: (error) Uninitialized variable: finh
[xlators/mount/fuse/src/fuse-bridge.c:3080]: (error) Possible null pointer dereference: state
[xlators/nfs/server/src/nfs-common.c:89]: (error) Dangerous usage of 'volname' (strncpy doesn't always null-terminate it).
[xlators/performance/quick-read/src/quick-read.c:586]: (error) Possible null pointer dereference: iobuf

Rerunning cppcheck after fixing the above:

As before, test program:

[extras/test/test-ffop.c:27]: (error) Buffer overrun possible for long command line arguments.
[tests/basic/fops-sanity.c:55]: (error) Buffer overrun possible for long command line arguments.

As before, false positive:

[geo-replication/src/gsyncd.c:100]: (error) Memory leak: str
[geo-replication/src/gsyncd.c:403]: (error) Memory leak: argv
[xlators/nfs/server/src/nlm4.c:1201]: (error) Possible null pointer dereference: fde
[xlators/cluster/afr/src/afr-self-heal-common.c:138]: (error) Possible null pointer dereference: __ptr
[xlators/cluster/afr/src/afr-self-heal-common.c:140]: (error) Possible null pointer dereference: __ptr
[xlators/cluster/afr/src/afr-self-heal-common.c:331]: (error) Possible null pointer dereference: __ptr

False positive after fix:

[xlators/performance/quick-read/src/quick-read.c:584]: (error) Possible null pointer dereference: iobuf

Change-Id: Ia5a256281156dd1df2fa900caea7694d9d0a7077
BUG: 1122290
Signed-off-by: Kaleb S. KEITHLEY 
Reviewed-on: http://review.gluster.org/8351
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur 
Reviewed-by: Raghavendra Bhat

glusterd: Maintain local xaction_peer list for op-sm

2015-05-28T09:06:43+00:00

http://review.gluster.org/9269 addresses maintaining local xaction_peers in
syncop and mgmt_v3 framework. This patch is to maintain local xaction_peers list
for op-sm framework as well.

Backport of http://review.gluster.org/#/c/9972/

Change-Id: Idd8484463fed196b3b18c2df7f550a3302c6e138
BUG: 1206429
Signed-off-by: Atin Mukherjee 
Reviewed-on: http://review.gluster.org/9972
Reviewed-by: Anand Nekkunti 
Tested-by: Gluster Build System 
Reviewed-by: Krishnan Parthasarathi 
Tested-by: Krishnan Parthasarathi 
Reviewed-on: http://review.gluster.org/10023
Reviewed-by: Kaushal M 
Reviewed-by: Raghavendra Bhat

Fix case mistake for MKDIR_P in Makefiles

2015-05-19T13:23:59+00:00

Some makefiles used $(mkdir_p) instead of the corectly defined $(MKDIR_P).
The former is substituted as an empty string, leading to possible failures
depending of the user shell tolerance. NetBSD's /bin/sh seems to choke
more easily than Linux's /bin/bash, but if the later does not fail, it
does not created the intended directories anyway.

Backport of I8caed4000f3c91cb3a685453848fb854793945ed

BUG: 1138897
Change-Id: I48a24231ba90aa3e84bf433b63ae5cb50307f042
Signed-off-by: Emmanuel Dreyfus 
Reviewed-on: http://review.gluster.org/10278
Tested-by: Gluster Build System 
Reviewed-by: Kaleb KEITHLEY 
Reviewed-by: Raghavendra Bhat

cluster/afr: Make read child match check in afr optional

2015-03-25T08:58:53+00:00

        Backport of: http://review.gluster.org/9917

Having this particular check which was introduced by
commit c57c455347a72ebf0085add49ff59aae26c7a70d causes a drop in
performance in readdirp. So the behavior is made configurable with this
patch.

Change-Id: I4a19813cfc786504340264a5a5533a0c43a1d4a4
BUG: 1202673
Signed-off-by: Krutika Dhananjay 
Reviewed-on: http://review.gluster.org/9929
Reviewed-by: Atin Mukherjee 
Tested-by: Gluster Build System 
Reviewed-by: Pranith Kumar Karampuri 
Reviewed-by: Raghavendra Bhat

glusterd: don't start gluster-nfs when NFS is disabled

2015-03-25T08:54:07+00:00

Backport of http://review.gluster.org/9835

Change-Id: Iff9c8e8d2233048f3e5c9ee8b5af38ba10193cb9
BUG: 1199936
Signed-off-by: Krishnan Parthasarathi 
Reviewed-on: http://review.gluster.org/9843
Reviewed-by: Atin Mukherjee 
Tested-by: Gluster Build System 
Reviewed-by: Kaleb KEITHLEY 
Reviewed-by: Raghavendra Bhat

glusterd/quota : remove quota-deem-statfs and quota-timeout values when quota is disabled.

2015-03-13T10:36:33+00:00

problem : If quota is disabled then all the options associated with
quota is removed, except quota-deem-statfs and quota-timeout.
When gluster volume info is issued then the user can see that quota
is disabled whereas quota-deem-statfs and quota-timeout values still
exist.

Solution : remove quota-deem-statfs and quota-timeout option when quota is
disabled

NOTE : If features.quota-deem-statfs is turned on, it takes quota limits
into consideration while estimating fs size.

Change-Id: I8cca6a8f47d2355799228643aedc8fc03896cfad
BUG: 1200258
Signed-off-by: Sachin Pandit 
Reviewed-on: http://review.gluster.org/8924
Tested-by: Gluster Build System 
Reviewed-by: Vijaikumar Mallikarjuna 
Reviewed-by: Krishnan Parthasarathi 
Tested-by: Krishnan Parthasarathi 
Signed-off-by: Sachin Pandit 
Reviewed-on: http://review.gluster.org/9845
Reviewed-by: Raghavendra Bhat

glusterd : release cluster wide locks in op-sm during failures

2015-03-04T07:31:08+00:00

glusterd op-sm infrastructure has some loophole in handing error cases in
locking/unlocking phases which ends up having stale locks restricting
further transactions to go through.

This patch still doesn't handle all possible unlocking error cases as the
framework neither has retry mechanism nor the lock timeout. For eg - if
unlocking fails in one of the peer, cluster wide lock is not released and
further transaction can not be made until and unless originator node/the node
where unlocking failed is restarted.

Following test cases were executed (with the help of gdb) after applying this
patch:

* RPC timesout in lock cbk
* Decoding of RPC response in lock cbk fails
* RPC response is received from unknown peer in lock cbk
* Setting peerinfo in dictionary fails while sending lock request for first peer
  in the list
* Setting peerinfo in dictionary fails while sending lock request for other
  peers
* Lock RPC could not be sent for peers

For all above test cases the success criteria is not to have any stale locks

Patch link : http://review.gluster.org/9012

Change-Id: Ia1550341c31005c7850ee1b2697161c9ca04b01a
BUG: 1179136
Signed-off-by: Atin Mukherjee 
Reviewed-on: http://review.gluster.org/9012
Reviewed-by: Krishnan Parthasarathi 
Tested-by: Gluster Build System 
Reviewed-by: Kaushal M 
Reviewed-on: http://review.gluster.org/9393
Reviewed-by: Raghavendra Bhat

glusterd: Maintain per transaction xaction_peers list in syncop & mgmt_v3

2015-02-26T12:00:32+00:00

In current implementation xaction_peers list is maintained in a global variable
(glustrd_priv_t) for syncop/mgmt_v3. This means consistency and atomicity of
peerinfo list across transactions is not guranteed when multiple syncop/mgmt_v3
transaction are going through.

We had got into a problem in mgmt_v3-locks.t which was failing spuriously, the
reason for that was two volume set operations (in two different volume) was
going through simultaneouly and both of these transaction were manipulating the
same xaction_peers structure which lead to a corrupted list. Because of which in
some cases unlock request to peer was never triggered and we end up with having
stale locks.

Solution is to maintain a per transaction local xaction_peers list for every
syncop.

Please note I've identified this problem in op-sm area as well and a separate
patch will be attempted to fix it.

Finally thanks to Krishnan Parthasarathi and Kaushal M for your constant help to
get to the root cause.

Backport URL : http://review.gluster.org/#/c/9269/
               http://review.gluster.org/#/c/9422/
               http://review.gluster.org/#/c/9350/
    
Change-Id: Ib1eaac9e5c8fc319f4e7f8d2ad965bc1357a7c63
BUG: 1176756
Signed-off-by: Atin Mukherjee 
Reviewed-on: http://review.gluster.org/9269
Tested-by: Gluster Build System 
Reviewed-by: Kaushal M 
Reviewed-on: http://review.gluster.org/9328
Reviewed-by: Raghavendra Bhat 
Tested-by: Raghavendra Bhat

glusterd: Fix spurious volume delete failure

2015-02-11T11:45:36+00:00

If volume uses quota, volume delete operation should unmount the
auxiliary quota mount usin glusterd_remove_auxiliary_mount(). This
may fail with EBADF is the mount is already gone. In that situation,
ignore the error so that volume delete succeeds.

This fixes a spurious failure on NetBSD in tests/basic/quota.t 74-75

Backport of I69325f71fc2c8af254db46f696c8669a4e6bd7e4

BUG: 1138897
Change-Id: If0d382d44a956bb9fd8c41299f82affdf2ee0618
Signed-off-by: Emmanuel Dreyfus 
Reviewed-on: http://review.gluster.org/9484
Tested-by: Gluster Build System 
Reviewed-by: Krishnan Parthasarathi 
Tested-by: Krishnan Parthasarathi

mgmt/glusterd: do not restart nfs server when snapshot is deactivated

2015-01-09T09:35:02+00:00

> Change-Id: Ie5eaa2beb4446640b22873f91e17da90d1cd8fad
> BUG: 1174625
> Signed-off-by: Raghavendra Bhat 
> Reviewed-on: http://review.gluster.org/9280
> Tested-by: Gluster Build System 
> Reviewed-by: Kaushal M 
> Signed-off-by: Raghavendra Bhat 

Change-Id: Ic5049f919fb444b45b3372a3b486183ed46d60f8
BUG: 1180404
Reviewed-on: http://review.gluster.org/9425
Tested-by: Gluster Build System 
Reviewed-by: Kaushal M 
Reviewed-by: Raghavendra Bhat