glusterfs.git/xlators/mgmt/glusterd, branch release-3.6

core : Use correct path in dlopen for socket.so

2015-12-16T11:29:23+00:00

Backport of http://review.gluster.org/12656

This patch fixes the path for socket.so file while loading the so dynamically.
Also for config.memory-accounting & config.transport voltype is changed to
glusterd to fix the warning message coming from xlator_volopt_dynload

Change-Id: I0f7964814586f2018d4922b23c683f4e1eb3098e
BUG: 1283834
Signed-off-by: Atin Mukherjee 
Reviewed-on: http://review.gluster.org/12656
Tested-by: Gluster Build System 
Reviewed-by: Niels de Vos 
Reviewed-by: Jeff Darcy 
Reviewed-on: http://review.gluster.org/12671
Reviewed-by: Raghavendra Bhat

glusterd: call glusterd_store_volinfo in bump up op-version

2015-11-18T12:43:53+00:00

After an upgrade, op-version is expected to be updated through gluster volume
set. If the new version introduces any feature which changes volinfo structure
without storing the default values of these new options would result into cksum
issues.

Backport of:
>Change-Id: I57b4667f3403839811735bf66bef29e5200a9241
>BUG: 1262805
>Signed-off-by: Atin Mukherjee 
>Reviewed-on: http://review.gluster.org/12171
>Tested-by: Gluster Build System 
>Reviewed-by: Krishnan Parthasarathi 
>Reviewed-by: Gaurav Kumar Garg 
>(cherry picked from commit c3ed484af54e32c1ef2300cda652604d75dc9d20)

Change-Id: I0c8d3cc7722b4a04e129c01792b80e27a7e8e59f
BUG: 1277823
Reviewed-on: http://review.gluster.org/12500
Tested-by: Gluster Build System 
Reviewed-by: Atin Mukherjee 
Reviewed-by: Raghavendra Bhat

glusterd: fix info file checksum mismatch during upgrade

2015-11-18T12:43:27+00:00

issue: probing a new  node(>=3.6)  from 3.5 cluster is moving the peer to rejected state.

fix: Disperse vol support is added from 3.6 release, so write disperse fields (disperse_count=0
and redundancy_count=0) in vol info file  only if cluster version supported.

Backport of:
>Change-Id: I11d5e2e337b9bbaddc8e52ca7295ba481beb1132
>BUG: 1276423
>Signed-off-by: anand 
>Reviewed-on: http://review.gluster.org/12464
>Reviewed-by: Pranith Kumar Karampuri 
>Tested-by: Gluster Build System 
>Reviewed-by: Kaushal M 
>Tested-by: NetBSD Build System 
>(cherry picked from commit d29dd0747dbb2e7383867c97cbbaa8c41851db78)

Change-Id: I8351457d15e76936851128eb8609746ae87d5aa8
BUG: 1277822
Signed-off-by: anand 
Reviewed-on: http://review.gluster.org/12501
Tested-by: Gluster Build System 
Reviewed-by: Atin Mukherjee 
Reviewed-by: Raghavendra Bhat

glusterd: really get the inode size for a brick

2015-08-18T12:55:17+00:00

backport of http://review.gluster.org/#/c/8492/

The device to get the inode size from does not get passed to the tool
(tune2fs, xfs_info or the like) that is called. This is probably just an
oversight. While correcting this, cleanup some bits of the function too.

Change-Id: Ida45852cba061631fb304bc7dd5286df1a808010
BUG: 1254421
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/8492
Tested-by: Gluster Build System 
Reviewed-by: Kaleb KEITHLEY 
Reviewed-by: Krishnan Parthasarathi 
Tested-by: Krishnan Parthasarathi 
Reviewed-on: http://review.gluster.org/11941
Reviewed-by: Raghavendra Bhat

glusterd: fix op-version bump up flow

2015-08-14T08:49:23+00:00

Backport of http://review.gluster.org/#/c/11798/

If a cluster is upgraded from 3.5 to latest version, gluster volume set all
cluster.op-version  will throw an error message back to the user saying
unlocking failed. This is because of trying to release a volume wise lock in
unlock phase as the lock was taken cluster wide. The problem surfaced because
the op-version is updated in commit phase and unlocking works in the v3
framework where it should have used cluster unlock. Fix is to decide which
lock/unlock is to be followed before invoking lock phase

Change-Id: I6a82251d88cfc7af36c7deec511c634a09e55004
BUG: 1250836
Signed-off-by: Atin Mukherjee 
Reviewed-on: http://review.gluster.org/11849
Tested-by: Gluster Build System 
Reviewed-by: Krishnan Parthasarathi 
Tested-by: NetBSD Build System 
Reviewed-by: Raghavendra Bhat

glusterd: Fix management encryption issues with GlusterD

2015-07-13T10:13:55+00:00

  Backport of commit 01b82c6 from master

Management encryption was enabled incorrectly in GlusterD leading to
issues of cluster deadlocks. This has been fixed with this commit. The
fix is in two parts,

1. Correctly enable encrytion for the TCP listener in GlusterD and
re-enable own-threads for encrypted connections.
  Without this, GlusterD could try to esatblish the blocking SSL
  connects in the epoll thread, for eg. when handling friend updates,
  which could lead to cluster deadlocks.

2. Explicitly enable encryption for outgoing peer connections.
  Without enabling encryption explicitly for outgoing connections was
  causing SSL socket events to be handled in the epoll thread. Some
  events, like disconnects during peer detach, could lead to connection
  attempts to happen in the epoll thread, leading to deadlocks again.

Change-Id: I438c2b43f7b1965c0e04d95c000144118d36272c
BUG: 1241785
Signed-off-by: Kaushal M 
Reviewed-on: http://review.gluster.org/11612
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra Bhat

glusterd: use a real host name (instead of numeric) when we have one

2015-07-13T06:24:05+00:00

Change-Id: Ie9cc201204d3d613e3e585cab066a07283db902c
BUG: 1241275
Signed-off-by: Jeff Darcy 
Reviewed-on: http://review.gluster.org/11569
Tested-by: Gluster Build System 
Reviewed-by: Krishnan Parthasarathi 
Reviewed-by: Shyamsundar Ranganathan 
Reviewed-by: Raghavendra Bhat 
Tested-by: NetBSD Build System

glusterd: Store peerinfo after updating hostnames

2015-07-10T07:29:44+00:00

  Backport of https://review.gluster.org/11365

Change-Id: I1d36ac63de810061d60edb28b6f591ae45d5cd3a
BUG: 1234846
Signed-off-by: Kaushal M 
Reviewed-on: http://review.gluster.org/11395
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System 
Reviewed-by: Raghavendra Bhat

core: fix Ubuntu code audit (cppcheck) results

2015-06-10T12:03:01+00:00

See also http://review.gluster.org/#/c/8064/, BZ 1109180, and
http://review.gluster.org/#/c/7693/, BZ 1091677

AFAICT these are false positives:

[geo-replication/src/gsyncd.c:100]: (error) Memory leak: str
[geo-replication/src/gsyncd.c:403]: (error) Memory leak: argv
[xlators/nfs/server/src/nlm4.c:1201]: (error) Possible null pointer dereference: fde
[xlators/cluster/afr/src/afr-self-heal-common.c:138]: (error) Possible null pointer dereference: __ptr
[xlators/cluster/afr/src/afr-self-heal-common.c:140]: (error) Possible null pointer dereference: __ptr
[xlators/cluster/afr/src/afr-self-heal-common.c:331]: (error) Possible null pointer dereference: __ptr

Test program:

[extras/test/test-ffop.c:27]: (error) Buffer overrun possible for long command line arguments.
[tests/basic/fops-sanity.c:55]: (error) Buffer overrun possible for long command line arguments.

the remainder are fixed with this change-set:

[cli/src/cli-rpc-ops.c:8883]: (error) Possible null pointer dereference: local
[cli/src/cli-rpc-ops.c:8886]: (error) Possible null pointer dereference: local
[contrib/uuid/gen_uuid.c:369]: (warning) %ld in format string (no. 2) requires 'long *' but the argument type is 'unsigned long *'.
[contrib/uuid/gen_uuid.c:369]: (warning) %ld in format string (no. 3) requires 'long *' but the argument type is 'unsigned long *'.
[xlators/cluster/dht/src/dht-rebalance.c:1734]: (error) Possible null pointer dereference: ctx
[xlators/cluster/stripe/src/stripe.c:4940]: (error) Possible null pointer dereference: local
[xlators/mgmt/glusterd/src/glusterd-geo-rep.c:1718]: (error) Possible null pointer dereference: command
[xlators/mgmt/glusterd/src/glusterd-replace-brick.c:942]: (error) Resource leak: file
[xlators/mgmt/glusterd/src/glusterd-replace-brick.c:1026]: (error) Resource leak: file
[xlators/mgmt/glusterd/src/glusterd-sm.c:249]: (error) Possible null pointer dereference: new_ev_ctx
[xlators/mgmt/glusterd/src/glusterd-snapshot.c:6917]: (error) Possible null pointer dereference: volinfo
[xlators/mgmt/glusterd/src/glusterd-utils.c:4517]: (error) Possible null pointer dereference: this
[xlators/mgmt/glusterd/src/glusterd-utils.c:6662]: (error) Possible null pointer dereference: this
[xlators/mgmt/glusterd/src/glusterd-utils.c:7708]: (error) Possible null pointer dereference: this
[xlators/mount/fuse/src/fuse-bridge.c:4687]: (error) Uninitialized variable: finh
[xlators/mount/fuse/src/fuse-bridge.c:3080]: (error) Possible null pointer dereference: state
[xlators/nfs/server/src/nfs-common.c:89]: (error) Dangerous usage of 'volname' (strncpy doesn't always null-terminate it).
[xlators/performance/quick-read/src/quick-read.c:586]: (error) Possible null pointer dereference: iobuf

Rerunning cppcheck after fixing the above:

As before, test program:

[extras/test/test-ffop.c:27]: (error) Buffer overrun possible for long command line arguments.
[tests/basic/fops-sanity.c:55]: (error) Buffer overrun possible for long command line arguments.

As before, false positive:

[geo-replication/src/gsyncd.c:100]: (error) Memory leak: str
[geo-replication/src/gsyncd.c:403]: (error) Memory leak: argv
[xlators/nfs/server/src/nlm4.c:1201]: (error) Possible null pointer dereference: fde
[xlators/cluster/afr/src/afr-self-heal-common.c:138]: (error) Possible null pointer dereference: __ptr
[xlators/cluster/afr/src/afr-self-heal-common.c:140]: (error) Possible null pointer dereference: __ptr
[xlators/cluster/afr/src/afr-self-heal-common.c:331]: (error) Possible null pointer dereference: __ptr

False positive after fix:

[xlators/performance/quick-read/src/quick-read.c:584]: (error) Possible null pointer dereference: iobuf

Change-Id: Ia5a256281156dd1df2fa900caea7694d9d0a7077
BUG: 1122290
Signed-off-by: Kaleb S. KEITHLEY 
Reviewed-on: http://review.gluster.org/8351
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur 
Reviewed-by: Raghavendra Bhat

glusterd: Maintain local xaction_peer list for op-sm

2015-05-28T09:06:43+00:00

http://review.gluster.org/9269 addresses maintaining local xaction_peers in
syncop and mgmt_v3 framework. This patch is to maintain local xaction_peers list
for op-sm framework as well.

Backport of http://review.gluster.org/#/c/9972/

Change-Id: Idd8484463fed196b3b18c2df7f550a3302c6e138
BUG: 1206429
Signed-off-by: Atin Mukherjee 
Reviewed-on: http://review.gluster.org/9972
Reviewed-by: Anand Nekkunti 
Tested-by: Gluster Build System 
Reviewed-by: Krishnan Parthasarathi 
Tested-by: Krishnan Parthasarathi 
Reviewed-on: http://review.gluster.org/10023
Reviewed-by: Kaushal M 
Reviewed-by: Raghavendra Bhat