glusterfs.git/xlators/mgmt, branch v3.12.2

glusterd:Marking all the brick status as stopped when a process goes down in brick multiplexing

2017-10-12T18:49:37+00:00

In brick multiplexing environment, if a brick process goes down
i.e., if we kill it with SIGKILL, the status of the brick for which
the process came up for the first time is only changing to stopped.
all other brick statuses are remain started. This is happening because
the process was killed abruptly using SIGKILL signal and signal
handler wasn't invoked and further cleanup wasn't triggered.

When we try to start a volume using force, it shows error saying
"Request timed out", since all the brickinfo->status are still in
started state, we're waiting for one of the brick process to come up
which never going to happen since the brick process was killed.

To resolve this, In the disconnect event, We are checking all the
processes that whether the brick which got disconnected belongs the
process. Once we get the process we are calling a function named
glusterd_mark_bricks_stopped_by_proc() and sending brick_proc_t object as
an argument.

From the glusterd_brick_proc_t we can get all the bricks attached
to that process. but these are duplicated ones. To get the original
brickinfo we are reading volinfo from brick. In volinfo we will have
original brickinfo copies. We are changing brickinfo->status to
stopped for all the bricks.

>Change-Id: Ifb9054b3ee081ef56b39b2903ae686984fe827e7
>BUG: 1499509
>Signed-off-by: Sanju Rakonde 
>Reviewed-on: https://review.gluster.org/#/c/18444/
>Smoke: Gluster Build System 
>CentOS-regression: Gluster Build System 
>Reviewed-by: Atin Mukherjee 
>cherry picked from commit 9422446d72bc054962d72ace9912ecb885946d49)

Change-Id: Ifb9054b3ee081ef56b39b2903ae686984fe827e7
BUG: 1501154
Signed-off-by: Sanju Rakonde

glusterd: disallow replace brick for dist only volumes

2017-10-12T05:38:57+00:00

Allowing replace-brick on dist only volumes will lead to data loss. This
patch blocks replace brick commit force to fail if a volume is dist
only.

Also removing tests/basic/pump.t as its of no use as per the discussion
in
http://lists.gluster.org/pipermail/gluster-devel/2017-September/053652.html

>Reviewed-on: https://review.gluster.org/18226
>Smoke: Gluster Build System 
>Reviewed-by: N Balachandran 
>CentOS-regression: Gluster Build System 
>(cherry picked from commit 7f70d38b66ce755f848ff0197814457a28b321df)

Change-Id: Iabb0c16f865f3fc361b64a19bfcf0c0fbb5c2682
BUG: 1493975
Signed-off-by: Atin Mukherjee

cli/afr: gluster volume heal info "healed" command output is not appropriate

2017-10-11T10:02:57+00:00

Problem: "gluster volume heal info [healed] [heal-failed]" command
          output on terminal is not appropriate in case of down any volume.

Solution: To make message more appropriate change the condition
          in function "gd_syncop_mgmt_brick_op".

Test : To verify the fix followed below procedure
       1) Create 2*3 distribute replicate volume
       2) set self-heal daemon off
       3) kill two bricks (3, 6)
       4) create some file on mount point
       5) bring brick 3,6 up
       6) kill other two brick (2 and 4)
       7) make self heal daemon on
       8) run "gluster v heal "

Note: After apply the patch options (healed | heal-failed) will deprecate
      from command line.

> BUG: 1388509
> Change-Id: I229c320c9caeb2525c76b78b44a53a64b088545a
> Signed-off-by: Mohit Agrawal 
> (Cherry pick from commit d1f15cdeb609a1b720a04a502f7a63b2d3922f41)

BUG: 1500662
Change-Id: I229c320c9caeb2525c76b78b44a53a64b088545a
Signed-off-by: Mohit Agrawal

glusterd: fix invalid memory reference returned

2017-10-10T05:35:06+00:00

> BUG: 1490897
> Reviewed-on: https://review.gluster.org/18263
> Smoke: Gluster Build System 
> CentOS-regression: Gluster Build System 
> Reviewed-by: Jeff Darcy 
> Reviewed-by: Gaurav Yadav 

Change-Id: I0823c7b33060b48040c1d86ad346a5f6e15bc190
BUG: 1491178
Signed-off-by: Xavier Hernandez

glusterd: fix client io-threads option for replicate volumes

2017-10-09T12:21:08+00:00

Backport of https://review.gluster.org/#/c/18430/

Problem:
Commit ff075a3d6f9b142911d25c27fd209838782bfff0 disabled loading
client-io-threads for replicate volumes (it was set to on by default in
commit e068c1997314046658dd502e9118dab32decf879) due to performance
issues but in doing so, inadvertently failed to load the xlator even if
the user explicitly enabled the option using the volume set command.
This was despite returning returning sucess for the volume set.

Fix:
Modify the check in perfxl_option_handler() and add checks in volume
create/add-brick/remove-brick code paths, tying it all to
GD_OP_VERSION_3_12_2.

Change-Id: Ib612973a999a7da818cc926f5c2601b1f0794fcf
BUG: 1499158
Signed-off-by: Ravishankar N

glusterd: spelling errors reported by Debian maintainer

2017-10-06T06:37:24+00:00

Reported-by: "Patrick Matthäi" 

master https://review.gluster.org/18185

Change-Id: I0dd6b7d88ddf3c98e8083b75f8dd848babcfd30a
BUG: 1494523
Signed-off-by: Kaleb S. KEITHLEY

glusterd: retrieve uuid under mutex lock

2017-10-05T12:18:22+00:00

In a multi node cluster, if one of the glusterd instance goes down and
comes back, then there might be a race situation where glusterd needs to
retrieve its uuid (glusterd_retrieve_uuid) and at the same time as part of
receiving a friend handshake from other peer, glusterd iterates over the volume
information recieved from remote node and checks for if a brick is local or not
by calling MY_UUID which in turn calls glusterd_retrieve_uuid. And the
same applies for glusterd_store_global_info () function too. This
could end up in a situation where for the same node glusterd ends up
generating two UUID files in /var/lib/glusterd. Following is the log
snippet which confirms the above:

[2017-09-01 03:09:24.458030] I [glusterd.c:146:glusterd_uuid_init] 0-management: retrieved UUID: fd46a495-7e33-468f-88f6-63c815fac640  // thread 1 retrieve uuid from glusterd.info
[2017-09-01 03:09:24.458034] E [glusterd-store.c:2109:glusterd_retrieve_uuid] 0-: No previous uuid is present
//thread 2 can not retrieve uuid, because in thread1 the file pointer has already become eof.
[2017-09-01 03:09:24.458041] E [glusterd-store.c:2117:glusterd_retrieve_uuid] 0-: Returning -1
[2017-09-01 03:09:24.458076] I [glusterd.c:176:glusterd_uuid_generate_save] 0-management: generated UUID: 190bb292-a296-4125-96da-42b247511cc4
[2017-09-01 03:09:24.458129] E [store.c:367:gf_store_save_value] 0-: Able to store key: UUID,value: 190bb292-a296-4125-96da-42b247511cc4

Fix is to retrieve the uuid under mutex lock.

Credits : cynthia.zhou@nokia-sbell.com

> Reviewed-on: : https://review.gluster.org/#/c/18333/
>(cherry picked from commit 898f0b7ce31ddf8ec02e572c5d22eff2e4205b4c)

Change-Id: Ib9a5e159c3febf2aef13aa5e38f0a51fe409dadb
BUG: 1495162
Signed-off-by: Atin Mukherjee

feature/posix: Enabled gfid2path by default

2017-08-29T20:09:32+00:00

Enable gfid2path feature by default. The basic
performance tests are carried out and it doesn't
show significant depreciation. The results are
updated in issue.

Updates: #139
Change-Id: I5f1949a608d0827018ef9d548d5d69f3bb7744fd
> Signed-off-by: Kotresh HR 
> Reviewed-on: https://review.gluster.org/17950
> Smoke: Gluster Build System 
> CentOS-regression: Gluster Build System 
> Reviewed-by: Aravinda VK 
> Reviewed-by: Amar Tumballi 
(cherry picked from commit 3ec63650bb7fd874a5013e7be4a2def3b519c9b2)
Reviewed-on: https://review.gluster.org/18133
Reviewed-by: Amar Tumballi 
Smoke: Gluster Build System 
Tested-by: Shyamsundar Ranganathan 
CentOS-regression: Gluster Build System 
Reviewed-by: Shyamsundar Ranganathan

glusterd: replace-brick executing successfully when quorum does not met

2017-08-29T12:39:52+00:00

Problem:
replace-brick command on a setup where quorum does not met executing
successfully.

Fix:
With the fix glusterd is validating whether server is in quorum or not
during replace-brick staging

>Reviewed-on: https://review.gluster.org/18068
>Smoke: Gluster Build System 
>CentOS-regression: Gluster Build System 
>Reviewed-by: Atin Mukherjee 

Change-Id: I8017154bb62bdcc6c6490e720ecfe9cde090c161
BUG: 1486110
Signed-off-by: Gaurav Yadav 
Reviewed-on: https://review.gluster.org/18125
Smoke: Gluster Build System 
Reviewed-by: Atin Mukherjee 
Reviewed-by: Prashanth Pai 
CentOS-regression: Gluster Build System

glusterd: disable rpc_clnt_t after relalance process disconnection

2017-08-25T19:00:50+00:00

Problem:
glusterd continues to connect to rebalance process even after
the socket connection has disconnected.

Solution:
rpc_clnt_disable() disables the rpc_clnt_t object and disarms
all relevant timers and drops refs to the rpc_clnt_t object
and the transport as well.

>Reviewed-on: https://review.gluster.org/18114
>Reviewed-by: MOHIT AGRAWAL 
>Tested-by: Atin Mukherjee 
>Reviewed-by: Atin Mukherjee 
>Smoke: Gluster Build System 
>CentOS-regression: Gluster Build System 
>(cherry picked from commit a894d44427649e99d4344a241dc2f9d584a9a691)

Change-Id: I981d6f1cc0087037f1927062c2770a4d5026a619
BUG: 1484885
Signed-off-by: Milind Changire 
Reviewed-on: https://review.gluster.org/18117
Tested-by: Atin Mukherjee 
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Shyamsundar Ranganathan