glusterfs.git/xlators/mount/fuse/src, branch v3.7.9

mount/fuse: cleanup an additional inode_ref()

2016-03-17T20:05:20+00:00

commit ca515db0127 introduced a check in
fuse_resolve_inode_simple(). This results in an additional
ref being held on inodes which were obtained through readdirp.
As a result, the inode table keeps growing and entries remain in
the active list even after deletion of such inodes from the volume.

Change-Id: I780ec5513990d6ef00ea051ec57ff20e4428081e
BUG: 1317959
Signed-off-by: Vijay Bellur 
Reviewed-on: http://review.gluster.org/13745
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Raghavendra Bhat

fuse: Add a new mount option capability

2016-03-10T03:09:43+00:00

Originally all security.* xattrs were forbidden if selinux is disabled,
which was causing Samba's acl_xattr module to not work, as it would
store the NTACL in security.NTACL. To fix this http://review.gluster.org/#/c/12826/
was sent, which forbid only security.selinux. This opened up a getxattr
call on security.capability before every write fop and others.

Capabilities can be used without selinux, hence if selinux is disabled,
security.capability cannot be forbidden. Hence adding a new mount
option called capability.

Only when "--capability" or "--selinux" mount option is used,
security.capability is sent to the brick, else it is forbidden.

Backport of : http://review.gluster.org/#/c/13540/ &
              http://review.gluster.org/#/c/13653/

BUG: 1309462
Change-Id: Ib8d4f32d9f1458f4d71a05785f92b526aa7033ff
Signed-off-by: Poornima G 
Reviewed-on: http://review.gluster.org/13626
Tested-by: Vijay Bellur 
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Vijay Bellur

fuse: send lookup if inode_ctx is not set

2016-02-22T14:45:32+00:00

During resolving of an entry or inode, if inode ctx
was not set, we will send a lookup.

This patch also make sure that inode_ctx will be created
after every inode_link

Back port of>
>Change-Id: I4211533ca96a51b89d9f010fc57133470e52dc11
>BUG: 1297311
>Signed-off-by: Mohammed Rafi KC 
>Reviewed-on: http://review.gluster.org/13225
>Reviewed-by: Dan Lambright 

Change-Id: I53d7f77b5b9a9e095aeeccdd3605dcce7eade0b2
BUG: 1306131
Tested-by: Dan Lambright 
Reviewed-on: http://review.gluster.org/13416
Smoke: Gluster Build System 
Tested-by: mohammed rafi  kc 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Dan Lambright

fuse:sent at least one lookup before actual fop

2016-02-22T14:37:20+00:00

Fuse shoud sent atleast one lookup for an inode/gfid
populated via readdirp before actual fop to populate
inode ctx for xlators.

Back port of>
>Change-Id: I5c02ed73f892924c9e404d91cbe0633a275accbd
>BUG: 1236032
>Signed-off-by: Mohammed Rafi KC 
>Reviewed-on: http://review.gluster.org/11892
>Reviewed-by: Raghavendra G 
>Tested-by: Raghavendra G 
>Tested-by: NetBSD Build System 
>Reviewed-by: Dan Lambright 
>Tested-by: Dan Lambright 

Change-Id: Iab5d9c7939771a1644fce4f6fe2520ed19455a37
BUG: 1306131
Signed-off-by: Mohammed Rafi KC 
Reviewed-on: http://review.gluster.org/13415
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Dan Lambright

Fuse: Add a check for NULL in fuse_itable_dump

2016-02-09T05:25:33+00:00

Problem: Immediately after starting a disperse volume (2+1)
kill one brick and just after that try to mount it
through fuse. This lead to crash.

Our test scripts use process statedumps to determine various things
like whether they are up, connected to bricks etc. It takes some time
for an active_subvol to be be associated with fuse even after mount
process is daemonized. This time is normally a function of completion
of handshake with bricks. So, if we try to take statedump in this time
window, fuse wouldn't have an active_subvol associated with it leading
to this crash.

This happened while executing ec-notify.t, which contains above steps.

Solution: Check priv and  priv->active_subvol for NULL before
inode_table_dump. If priv->active_subvol is null its perfectly fine to
skip dumping of inode table as inode table is associated with an
active_subvol. A Null active_subvol indicates initialization in
progress and fuse wouldn't even have started reading requests from
/dev/fuse and hence there wouldn't be any inodes or file system
activity.

Change-Id: I323a154789edf8182dbd1ac5ec7ae07bf59b2060
BUG: 1305428
Signed-off-by: Ashish Pandey 
Reviewed-on: http://review.gluster.org/13253
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Raghavendra G 
Signed-off-by: Ashish Pandey 
Reviewed-on: http://review.gluster.org/13396
Reviewed-by: Xavier Hernandez

fuse: fix inode and dentry leaks

2016-02-04T07:55:34+00:00

When a readdirp was executed, the nlookup count for each inode of the
returned entries was incremented. However the kernel does not increment
the counter for '.' and '..' entries.

This caused that kernel sent forgets with a counter smaller than the
inode's current value. This prevented these inodes to be retired when
ref count was 0.

Change-Id: I36f3736c86d1cc20adabbbc133ce4edeff62db78
Signed-off-by: Xavier Hernandez 
Reviewed-on: http://review.gluster.org/13324
Smoke: Gluster Build System 
Reviewed-by: Raghavendra Bhat 
Tested-by: Kaleb KEITHLEY 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Kaleb KEITHLEY

fuse: use-after-free fix in fuse-bridge, revisited

2016-02-03T05:16:04+00:00

Prompted by the email exchange in gluster-devel between Oleksandr
Natalenko, xavi, and soumyak, I looked at this because the fuse client
on the longevity cluster has also been suffering from a serious memory
leak for some time. (longevity cluster is currently running 3.7.6)

The longevity cluster manifests the same kernel notifier loop terminated
log message the Oleksandr sees, and some sample runs suggest that the
length passed to the (sys_)write call is unexpectedly and abnormally large.

Basically this fix
 a) uses correct types for len and rv,
 b) copies the len from potentially incorrectly aligned memory (in a
    way that should minimize potential performance issues related to
    accessing unaligned memory.)
 c) changes log level of the kernel notifier loop terminated message
 d) fixes a potential mutex lock/unlock issue

See
    Change-Id: Icedb3525706f59803878bb37ef6b4ffe4a986880
    BUG: 1288857
    http://review.gluster.org/13274

Change-Id: I1a2f957a95978468baa33c2b1f3667934d88939c
BUG: 1288922
Signed-off-by: Kaleb S KEITHLEY 
Reviewed-on: http://review.gluster.org/13275
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Raghavendra G

all: reduce "inline" usage

2016-01-18T09:02:34+00:00

There are three kinds of inline functions: plain inline, extern inline,
and static inline.  All three have been removed from .c files, except
those in "contrib" which aren't our problem.  Inlines in .h files, which
are overwhelmingly "static inline" already, have generally been left
alone.  Over time we should be able to "lower" these into .c files, but
that has to be done in a case-by-case fashion requiring more manual
effort.  This part was easy to do automatically without (as far as I can
tell) any ill effect.

In the process, several pieces of dead code were flagged by the
compiler, and were removed.

backport of Change-Id: I56a5e614735c9e0a6ee420dab949eac22e25c155,
http://review.gluster.org/11769, BUG: 1245331

Change-Id: Iba1efb0bc578ea4a5e9bf76b7bd93dc1be9eba44
BUG: 1283302
Signed-off-by: Kaleb S KEITHLEY 
Reviewed-on: http://review.gluster.org/12646
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Niels de Vos

fuse: forbid only access to security.selinux xattr if not mounted with 'selinux'

2015-12-16T19:18:43+00:00

Originally, all selinux.* xattrs were forbidden, causing
for example Samba's acl_xattr module which uses security.NTACL
to fail without the 'selinux' mount option, which is confusing
at least. This change specializes the check to the security.selinux
attribute, so other selinux.* attributes work with or without the option.

> Change-Id: I9d3083123efbf403f20572cfb325a300ce2e90d9
> BUG: 1283103
> Signed-off-by: Michael Adam 
> Reviewed-on: http://review.gluster.org/12826
> Tested-by: Gluster Build System 
> Tested-by: NetBSD Build System 
> Reviewed-by: Rajesh Joseph 
> Reviewed-by: Raghavendra G 

(cherry picked from commit 4fefa3d7dbcdad1e71c74db11113ac1e74b01656)

Change-Id: Ia1ab1ef70b0ce8085afc7f8b09accff2a5966161
BUG: 1283107
Signed-off-by: Michael Adam 
Reviewed-on: http://review.gluster.org/12953
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra Talur

mount/fuse: Fix use-after-free crash

2015-12-10T03:52:57+00:00

       Backport of http://review.gluster.com/12886

fouh->len is accessed after 'node' is freed. Also 'rv' is int where as
fouh->len is uint32, changed comparison to ssize_t variables.

BUG: 1288922
Change-Id: Ib5e22ce56a022740fcc09ce430ff1de31a8a45d6
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/12887
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System 
Reviewed-by: Raghavendra G