glusterfs.git/xlators/mount, branch v3.5.8

fuse: squash 64-bit inodes in readdirp when enable-ino32 is set

2015-06-03T20:23:55+00:00

The structures returned by readdirp contain the inode 2x. Only one of
them was squashed into 32-bits when enable-ino32 is enabled.

Backport of:
> Change-Id: I33a6d28fb118bb23971f918ffeb983d7f033106e
> BUG: 1223889
> Reviewed-on: http://review.gluster.org/10881
> Signed-off-by: Niels de Vos 
> Tested-by: Cyril Peponnet  [on release-3.5]

Change-Id: I33a6d28fb118bb23971f918ffeb983d7f033106e
BUG: 1222150
Signed-off-by: Niels de Vos 
Tested-by: Cyril Peponnet 
Reviewed-on: http://review.gluster.org/10884
Tested-by: Gluster Build System

mount: Verify mount failure in mount.glusterfs wrapper.

2014-12-15T08:02:30+00:00

The result of mount command execution is not checked properly, thus
no proper message given for the end user. This patch fix the same.

Cherry picked from commit 76b72680017c836eff8805ea0339f7827ba3e561:
> Bug Id: 1128165
> Change-Id: I3882e34e840ed15b5ce48ed5e1ad51208e2be913
> Signed-off-by: Humble Chirammal 
> Reviewed-on: http://review.gluster.org/8438
> Tested-by: Gluster Build System 
> Reviewed-by: Niels de Vos 

BUG: 1173515
Change-Id: I3882e34e840ed15b5ce48ed5e1ad51208e2be913
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/9271
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

core: fix Ubuntu code audit (cppcheck) results

2014-11-26T08:30:12+00:00

See http://review.gluster.org/#/c/7583/ BZ 1086460

AFAICT these are false positives:

[geo-replication/src/gsyncd.c:99]: (error) Memory leak: str
[geo-replication/src/gsyncd.c:395]: (error) Memory leak: argv
[xlators/nfs/server/src/nlm4.c:1200]: (error) Possible null pointer dereference: fde

Program exits, resource leak not an issue
[extras/geo-rep/gsync-sync-gfid.c:105]: (error) Resource leak: fp

Test program:
[extras/test/test-ffop.c:27]: (error) Buffer overrun possible for long command line arguments.

Not built:
[xlators/cluster/ha/src/ha.c:2699]: (error) Possible null pointer dereference: priv

The remainder are fixed with this change-set:

[heal/src/glfs-heal.c:357]: (error) Possible null pointer dereference: remote_subvol
[libglusterfs/src/xlator.c:648]: (error) Uninitialized variable: gfid
[libglusterfs/src/xlator.c:649]: (error) Uninitialized variable: gfid
[xlators/cluster/afr/src/afr-inode-write.c:469]: (error) Possible null pointer dereference: frame
[xlators/cluster/afr/src/afr-self-heal-common.c:1704]: (error) Possible null pointer dereference: local
[xlators/cluster/dht/src/dht-rebalance.c:1643]: (error) Possible null pointer dereference: ctx
[xlators/cluster/stripe/src/stripe.c:4963]: (error) Possible null pointer dereference: local
[xlators/features/changelog/src/changelog.c:1464]: (error) Possible null pointer dereference: priv
[xlators/mgmt/glusterd/src/glusterd-geo-rep.c:1656]: (error) Possible null pointer dereference: command
[xlators/mgmt/glusterd/src/glusterd-replace-brick.c:914]: (error) Resource leak: file
[xlators/mgmt/glusterd/src/glusterd-replace-brick.c:998]: (error) Resource leak: file
[xlators/mgmt/glusterd/src/glusterd-sm.c:248]: (error) Possible null pointer dereference: new_ev_ctx
[xlators/mgmt/glusterd/src/glusterd-store.c:1332]: (error) Possible null pointer dereference: handle
[xlators/mgmt/glusterd/src/glusterd-utils.c:4706]: (error) Possible null pointer dereference: this
[xlators/mgmt/glusterd/src/glusterd-utils.c:5613]: (error) Possible null pointer dereference: this
[xlators/mgmt/glusterd/src/glusterd-utils.c:6342]: (error) Possible null pointer dereference: path_tokens
[xlators/mgmt/glusterd/src/glusterd-utils.c:6343]: (error) Possible null pointer dereference: path_tokens
[xlators/mount/fuse/src/fuse-bridge.c:4591]: (error) Uninitialized variable: finh
[xlators/mount/fuse/src/fuse-bridge.c:3004]: (error) Possible null pointer dereference: state
[xlators/nfs/server/src/nfs-common.c:89]: (error) Dangerous usage of 'volname' (strncpy doesn't always null-terminate it).
[xlators/performance/quick-read/src/quick-read.c:585]: (error) Possible null pointer dereference: iobuf

Rerunning cppcheck afterwards:

As before, test program:
[extras/test/test-ffop.c:27]: (error) Buffer overrun possible for long command line arguments.

As before, believed to be false positive:
[geo-replication/src/gsyncd.c:99]: (error) Memory leak: str
[geo-replication/src/gsyncd.c:395]: (error) Memory leak: argv
[xlators/nfs/server/src/nlm4.c:1200]: (error) Possible null pointer dereference: fde

As before, not built:
[xlators/cluster/ha/src/ha.c:2699]: (error) Possible null pointer dereference: priv

False positive after fix:
[heal/src/glfs-heal.c:356]: (error) Possible null pointer dereference: remote_subvol
[xlators/cluster/stripe/src/stripe.c:4963]: (error) Possible null pointer dereference: local

Change-Id: Ib3029d3223f5a13e2ac386a527d64d5ffe3ecb90
BUG: 1092037
Signed-off-by: Kaleb S. KEITHLEY 
Reviewed-on: http://review.gluster.org/7605
Tested-by: Gluster Build System 
Reviewed-by: Niels de Vos

mount/fuse: Handle fd resolution failures

2014-10-01T10:44:28+00:00

        Backport of http://review.gluster.org/8402

Problem:
Even when the fd resolution failed, the fop is continuing on the
new graph which may not have valid inode. This lead to NULL layout
subvols in dht which lead to crash in fsync after graph migration.

Fix:
- Remove resolution error handling in FUSE_FOP as it was only added
  to handle fd migration failures.
- check in fuse_resolve_done for fd resolution failures and fail the
  fop right away.
- loc resolution failures are already handled in the corresponding
  fops.
- Return errno from state->resolve.op_errno in resume functions.
- Send error to fuse on frame allocation failures.
- Removed unused variable state->resolved
- Removed unused macro FUSE_FOP_COOKIE

BUG: 1136835
Change-Id: I5074f7a9b177c54051ef37a4f73de7f8d1fcc5b7
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/8595
Tested-by: Gluster Build System 
Reviewed-by: Niels de Vos

fuse: prevent READDIR(P) from writing to much data to /dev/fuse

2014-05-08T17:58:50+00:00

In an environment with mixed architectures (32-bit servers, 64-bit
client), it is possible that the on-wire Reply on a READDIR(P) procedure
contains more direntries than the client can fit in the maximum size
that the fuse-request indicated.

A direntry is a dynamically sized structure, because the structure
contains the name of the entry. The client sends a maximum size in the
READDIR(P) Call to the server, and the server uses this size to limit
the number of direntries to return. In case the server can pack more
direntries in the requested maximum size (due to alignment differences
between the architectures), it can happen that the client unpacks the
list of direntries into a buffer that exceeds the maximum size that was
given in the initial fuse-request.

This change introduces a check for the maximum requested size of the
fuse-response in fuse_readdir_cbk() and fuse_readdirp_cbk(). When the
conversion from gluster-direntries to the fuse-direntry format takes
place, the maximum size is checked, and the 'extra' direntries are
discarded. The next readdir()/getdents() that is done, will fetch the
just discarded direntries again.

In addition to this bugfix, some extra logging in send_fuse_iov() and
send_fuse_data() has been added to help diagnosing similar issues.

This change combines two commits from master:
> Commit: 20e317011af7c0f075819bf0648b225f6dc42350
> Change-Id: If2eecfcdf9c248f3820035601446d2c89ff9d1a1
> BUG: 1074023
> Signed-off-by: Niels de Vos 
> Reviewed-on: http://review.gluster.org/7278
> Tested-by: Gluster Build System 
> Reviewed-by: Xavier Hernandez 
> Reviewed-by: Anand Avati 
>
> Commit: 76ab97169f63da78c9e83daf040d7b09766497cf
> Change-Id: Ic62d9d729a86a1a6a53ed1354fce153bac01d860
> BUG: 1074023
> Reported-by: Kaleb S. KEITHLEY 
> Signed-off-by: Niels de Vos 
> Reviewed-on: http://review.gluster.org/7547
> Tested-by: Gluster Build System 
> Reviewed-by: Anand Avati 

Change-Id: Id847db26d861a9805041ff3367e848da7be05545
BUG: 1089934
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/7522
Tested-by: Gluster Build System 
Reviewed-by: Xavier Hernandez

mount.glusterfS/glusterfsd: Add dummy deprecated *fetch-attempts options

2014-02-03T04:27:47+00:00

volfile-max-fetch-attempts and fetch-attempts were not deprecated
properly at 'b610f1be7cd71b8f3e51c224c8b6fe0e7366c8cf'.

Provide a way for backward compatibility for broken third party apps.

Change-Id: I520d7bc775d67917cf149d7833a8e46bdf265d9d
BUG: 1045309
Signed-off-by: Harshavardhana 
Reviewed-on: http://review.gluster.org/6761
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

mount/fuse: cleanup old graphs.

2014-01-28T16:43:52+00:00

After a graph switch, a PARENT_DOWN event from fuse indicates
protocol/client to shutdown all its sockets. However, this event will
be sent only when the first fop is received from fuse mount after
graph switch. Also, this event is sent only on previously active graph.
So, if there are multiple graph switches when there is no activity on
mountpoint, we'll be left with a list of graphs with their sockets
still open.

This patch fixes the issue by sending PARENT_DOWN to previously
non-active graph when a new graph is available irrespective of whether
there is an activity on mount-point.

Change-Id: I9e676658d797c0b2dd3ed5ca5a56271bd94b4bb6
BUG: 924726
Signed-off-by: Raghavendra G 
Reviewed-on: http://review.gluster.org/4713
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati 
Reviewed-on: http://review.gluster.org/6813
Reviewed-by: Vijay Bellur

mount/fuse: adding a setxattr filter pass for geo-rep create.

2014-01-27T17:45:00+00:00

Adding filter pass for setxattr when key is "glusterfs.gfid.newfile".
This was blocking creates at slave volume.

Change-Id: I61455abd8688c52ac6894b5a04ba050076117ea3
BUG: 1054199
Signed-off-by: Ajeet Jha 
Reviewed-on: http://review.gluster.org/6811
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

mount/fuse: Remove duplicate GET_STATE call

2014-01-02T07:22:38+00:00

BUG: 952029
Change-Id: I4aa87ffe70f2b56182666981956d7d1d62048e2f
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/6580
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

mount.glusterfs: Provide backward compatibility for "backup-volfile-servers"

2013-12-16T05:28:53+00:00

In commit "b610f1be7cd71b8f3e51c224c8b6fe0e7366c8cf" we deprecated
"backupvolfile-server" and provided a new option for specifying
multiple backup servers. This resulted in existing `fstab` entries
invalid and leading to mount failure. Provide backward compatibility
to avoid this regression.

Change-Id: Ic20671bbe2a0df36b6110ffa928396f808eb76e5
BUG: 1039643
Signed-off-by: Harshavardhana 
Reviewed-on: http://review.gluster.org/6464
Tested-by: Gluster Build System 
Reviewed-by: Kaushal M 
Reviewed-by: Anand Avati 
Reviewed-on: http://review.gluster.org/6485
Reviewed-by: Vijay Bellur