glusterfs.git/xlators/mount, branch v3.6.5

core: fix Ubuntu code audit (cppcheck) results

2015-06-10T12:03:01+00:00

See also http://review.gluster.org/#/c/8064/, BZ 1109180, and
http://review.gluster.org/#/c/7693/, BZ 1091677

AFAICT these are false positives:

[geo-replication/src/gsyncd.c:100]: (error) Memory leak: str
[geo-replication/src/gsyncd.c:403]: (error) Memory leak: argv
[xlators/nfs/server/src/nlm4.c:1201]: (error) Possible null pointer dereference: fde
[xlators/cluster/afr/src/afr-self-heal-common.c:138]: (error) Possible null pointer dereference: __ptr
[xlators/cluster/afr/src/afr-self-heal-common.c:140]: (error) Possible null pointer dereference: __ptr
[xlators/cluster/afr/src/afr-self-heal-common.c:331]: (error) Possible null pointer dereference: __ptr

Test program:

[extras/test/test-ffop.c:27]: (error) Buffer overrun possible for long command line arguments.
[tests/basic/fops-sanity.c:55]: (error) Buffer overrun possible for long command line arguments.

the remainder are fixed with this change-set:

[cli/src/cli-rpc-ops.c:8883]: (error) Possible null pointer dereference: local
[cli/src/cli-rpc-ops.c:8886]: (error) Possible null pointer dereference: local
[contrib/uuid/gen_uuid.c:369]: (warning) %ld in format string (no. 2) requires 'long *' but the argument type is 'unsigned long *'.
[contrib/uuid/gen_uuid.c:369]: (warning) %ld in format string (no. 3) requires 'long *' but the argument type is 'unsigned long *'.
[xlators/cluster/dht/src/dht-rebalance.c:1734]: (error) Possible null pointer dereference: ctx
[xlators/cluster/stripe/src/stripe.c:4940]: (error) Possible null pointer dereference: local
[xlators/mgmt/glusterd/src/glusterd-geo-rep.c:1718]: (error) Possible null pointer dereference: command
[xlators/mgmt/glusterd/src/glusterd-replace-brick.c:942]: (error) Resource leak: file
[xlators/mgmt/glusterd/src/glusterd-replace-brick.c:1026]: (error) Resource leak: file
[xlators/mgmt/glusterd/src/glusterd-sm.c:249]: (error) Possible null pointer dereference: new_ev_ctx
[xlators/mgmt/glusterd/src/glusterd-snapshot.c:6917]: (error) Possible null pointer dereference: volinfo
[xlators/mgmt/glusterd/src/glusterd-utils.c:4517]: (error) Possible null pointer dereference: this
[xlators/mgmt/glusterd/src/glusterd-utils.c:6662]: (error) Possible null pointer dereference: this
[xlators/mgmt/glusterd/src/glusterd-utils.c:7708]: (error) Possible null pointer dereference: this
[xlators/mount/fuse/src/fuse-bridge.c:4687]: (error) Uninitialized variable: finh
[xlators/mount/fuse/src/fuse-bridge.c:3080]: (error) Possible null pointer dereference: state
[xlators/nfs/server/src/nfs-common.c:89]: (error) Dangerous usage of 'volname' (strncpy doesn't always null-terminate it).
[xlators/performance/quick-read/src/quick-read.c:586]: (error) Possible null pointer dereference: iobuf

Rerunning cppcheck after fixing the above:

As before, test program:

[extras/test/test-ffop.c:27]: (error) Buffer overrun possible for long command line arguments.
[tests/basic/fops-sanity.c:55]: (error) Buffer overrun possible for long command line arguments.

As before, false positive:

[geo-replication/src/gsyncd.c:100]: (error) Memory leak: str
[geo-replication/src/gsyncd.c:403]: (error) Memory leak: argv
[xlators/nfs/server/src/nlm4.c:1201]: (error) Possible null pointer dereference: fde
[xlators/cluster/afr/src/afr-self-heal-common.c:138]: (error) Possible null pointer dereference: __ptr
[xlators/cluster/afr/src/afr-self-heal-common.c:140]: (error) Possible null pointer dereference: __ptr
[xlators/cluster/afr/src/afr-self-heal-common.c:331]: (error) Possible null pointer dereference: __ptr

False positive after fix:

[xlators/performance/quick-read/src/quick-read.c:584]: (error) Possible null pointer dereference: iobuf

Change-Id: Ia5a256281156dd1df2fa900caea7694d9d0a7077
BUG: 1122290
Signed-off-by: Kaleb S. KEITHLEY 
Reviewed-on: http://review.gluster.org/8351
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur 
Reviewed-by: Raghavendra Bhat

fuse: squash 64-bit inodes in readdirp when enable-ino32 is set

2015-06-03T11:47:27+00:00

The structures returned by readdirp contain the inode 2x. Only one of
them was squashed into 32-bits when enable-ino32 is enabled.

Backport of:
> Change-Id: I33a6d28fb118bb23971f918ffeb983d7f033106e
> BUG: 1223889
> Reviewed-on: http://review.gluster.org/10881
> Signed-off-by: Niels de Vos 
> Tested-by: Cyril Peponnet  [on release-3.5]

Change-Id: I33a6d28fb118bb23971f918ffeb983d7f033106e
BUG: 1223891
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/10883
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra Bhat

build: only include sys/sysctl.h when sysctl() is used

2015-05-19T13:35:08+00:00

Backport of BZ 1198849 http://review.gluster.org/9963

(fails to build on X32. X32 ABI for amd64/x86_64 using
32-bit pointers.)

Change-Id: I92496eeadec5a339abcfe9b7fab4bef896d80da4
BUG: 1215421
Signed-off-by: Kaleb S. KEITHLEY 
Reviewed-on: http://review.gluster.org/10424
Reviewed-by: Niels de Vos 
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra Bhat

Replace /dev/stderr with >&2 in mount scripts

2015-03-07T15:14:47+00:00

/dev/stderr is not available on boot in CentOS 7 and thus
mounting anything from /etc/fstab at boot time fails.

Instead of using /dev/stderr, the standard error redirection ">&2" is being used.

Cherry picked from commit adef0c8860f57c8137382d848244009e9a584497:
> Change-Id: I15d07cd49e6b0392331047edb441925f48047b2b
> BUG: 1199545
> Signed-off-by: Nico Schottelius 
> Reviewed-on: http://review.gluster.org/9824
> Reviewed-by: Niels de Vos 
> Tested-by: Gluster Build System 
> Reviewed-by: Raghavendra Talur 
> Reviewed-by: Vijay Bellur 

Change-Id: I15d07cd49e6b0392331047edb441925f48047b2b
BUG: 1199577
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/9826
Reviewed-by: Nico Schottelius 
Tested-by: Nico Schottelius 
Reviewed-by: Humble Devassy Chirammal 
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra Bhat

mount:Handle -o transport option in mount.glusterfs

2015-01-06T09:47:53+00:00

        Backport of http://review.gluster.org/#/c/9147/

In current scenario ,when tcp transport type(default)
specified for mounting,glusterfs mount script won't
append '.tcp' to volume name.But to accommodate the change
in http://review.gluster.org/#/c/9146/, we need to
append ".tcp" with volfile-id if '-o transport=tcp' is given.

Change-Id: I5444ac38846192de4af02535435b86bb00422aab
BUG: 1166515
Signed-off-by: Mohammed Rafi KC 
Reviewed-on: http://review.gluster.org/9179
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra G 
Reviewed-by: Raghavendra Bhat

glusterd/snapshot: mount snapshot volume with read-only option

2014-12-18T14:46:54+00:00

Snapshot volumes are readonly. If you mount the volume to the client it
doesn't allow writes, but its attributes are rw which contradicts the
functionality.

mount script should set read-only attributes for snapshot volumes.

> Change-Id: I056253abd8dfe7b2b43a064fbdbd9c16b8eca679
> BUG: 1132946
> Signed-off-by: vmallika 
> Reviewed-on: http://review.gluster.org/8518
> Tested-by: Gluster Build System 
> Reviewed-by: Avra Sengupta 
> Reviewed-by: Rajesh Joseph 
> Reviewed-by: Krishnan Parthasarathi 
> Tested-by: Krishnan Parthasarathi 
> Signed-off-by: Raghavendra Bhat 

Change-Id: Ida7340ea18a558cd15f25f2787a9794e287b17bd
BUG: 1175694
Reviewed-on: http://review.gluster.org/9296
Reviewed-by: Vijaikumar Mallikarjuna 
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra Bhat 
Tested-by: Raghavendra Bhat

Allow gluster to be used with linux automounter

2014-12-17T21:33:55+00:00

Added (ignored) -n option to mount.glusterfs command

Cherry picked from commit f8496dab2f6111bdc5ced0881d15061160b76e52:
> Change-Id: I9209da215d38507cd9d01b1e9af4aecff4414f83
> BUG: 1123004
> Signed-off-by: Anders Blomdell 
> Reviewed-on: http://review.gluster.org/8373
> Reviewed-by: Harshavardhana 
> Tested-by: Gluster Build System 
> Reviewed-by: Humble Devassy Chirammal 
> Reviewed-by: Vijay Bellur 

BUG: 1171259
Change-Id: I9209da215d38507cd9d01b1e9af4aecff4414f83
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/9279
Reviewed-by: Anders Blomdell 
Tested-by: Gluster Build System 
Reviewed-by: Kaleb KEITHLEY 
Reviewed-by: Harshavardhana 
Tested-by: Harshavardhana

mount: Verify mount failure in mount.glusterfs wrapper.

2014-12-13T06:03:19+00:00

The result of mount command execution is not checked properly, thus
no proper message given for the end user. This patch fix the same.

Cherry picked from commit 76b72680017c836eff8805ea0339f7827ba3e561:
> Bug Id: 1128165
> Change-Id: I3882e34e840ed15b5ce48ed5e1ad51208e2be913
> Signed-off-by: Humble Chirammal 
> Reviewed-on: http://review.gluster.org/8438
> Tested-by: Gluster Build System 
> Reviewed-by: Niels de Vos 

BUG: 1173513
Change-Id: I3882e34e840ed15b5ce48ed5e1ad51208e2be913
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/9270
Reviewed-by: Humble Devassy Chirammal 
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra Bhat 
Tested-by: Raghavendra Bhat

Portability fix: mount.glusterfs

2014-11-17T07:05:12+00:00

Remove bash-specific syntax from mount.glusterfs

This is a backport of  Iec3a52686f7cee1825ac5a06c11fb8ac4d3e5d65

BUG: 1138897
Change-Id: I3149cd4d94c862a3857709c00cf0ed0377976f40
Signed-off-by: Emmanuel Dreyfus 
Reviewed-on: http://review.gluster.org/9045
Tested-by: Gluster Build System 
Reviewed-by: Kaleb KEITHLEY 
Reviewed-by: Vijay Bellur

32 bit fix: use off_t and not size_t for truncate()

2014-09-25T18:05:52+00:00

Make sure off_t and not size_t is used when holding file offsets for
ftruncate()/truncate(). It works on 64 bit machines where
sizeof(size_t) == sizeof(off_t) == 8, but breaks for big offsets on 32 bit
machines because sizeof(size_t) == 4 and sizeof(off_t) == 8

This is backport of Ia2637be772ba9b11731d59fdbffbd269f0ff56c8

BUG: 1138897
Change-Id: I8fe77a86831f0db4eff5b5c89efe004b9a0b29e9
Signed-off-by: Emmanuel Dreyfus 
Reviewed-on: http://review.gluster.org/8743
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur