glusterfs.git/xlators/nfs/server/src/nfs3-helpers.c, branch v3.1.0alpha

gfid: changes in inode management

2010-09-04T08:45:06+00:00

- incorporate usage of uuid (gfid) as the key for finding inodes
- deprecate inode number/generation number based inode_get
- undo code specific to generation numbers (attic list etc.)

Signed-off-by: Anand V. Avati 
Signed-off-by: Anand V. Avati 
Signed-off-by: Vijay Bellur 

BUG: 971 (dynamic volume management)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971

nfs3: Return ESTALE when going beyond fh-hashcount or max-hashes

2010-08-31T14:44:38+00:00

During fh resolution, if we go beyond the max hashes support by
gnfs or if we go beyond the dir depth specified in the filehandle,
then return ESTALE.

Signed-off-by: Shehjar Tikoo 
Signed-off-by: Vijay Bellur 

BUG: 1378 (Deep directory creation crashes gnfs)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1378

nfs3: Logging and comments made more accurate

2010-08-31T14:44:33+00:00

Signed-off-by: Shehjar Tikoo 
Signed-off-by: Vijay Bellur 

BUG: 1378 (Deep directory creation crashes gnfs)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1378

nfs3: Unref dir fd once usage ends in hard fh resolution

2010-08-31T14:44:21+00:00

There are three conditions when a dir fd_t needs to be unrefed
when:

a. the inode being searched is found as the candidate entry,
b. we have exhausted all the entries in the current dir,
c. we decide to step into a child directory because of a hash
match.

This decision is made in nfs3_fh_resolve_check_response.

Signed-off-by: Shehjar Tikoo 
Signed-off-by: Vijay Bellur 

BUG: 1397 (Cached dir fd_ts are a leakin')
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1397

nfs3: Dont ref dir fd_t used in hard fh resolution

2010-08-31T14:44:18+00:00

..because the extra ref was under the mistaken assumption that
directory fd_t will be cached even during hard fh resolution and
that is not the case.

Signed-off-by: Shehjar Tikoo 
Signed-off-by: Vijay Bellur 

BUG: 1397 (Cached dir fd_ts are a leakin')
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1397

nfs3: Dont ref cached fd after fd_lookup

2010-08-31T14:44:11+00:00

..because fd_lookup returns a ref'd fd_t.

Signed-off-by: Shehjar Tikoo 
Signed-off-by: Vijay Bellur 

BUG: 1397 (Cached dir fd_ts are a leakin')
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1397

xlators/nfs: nfs3-helpers.c remove dead assignments.

2010-08-23T05:27:35+00:00

Signed-off-by: Sachidananda Urs 
Signed-off-by: Anand V. Avati 

BUG: 1115 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1115

nfs, nfs/rpc: Rename functions to prevent gfrpcsvc conflict

2010-08-10T09:44:22+00:00

Signed-off-by: Shehjar Tikoo 
Signed-off-by: Anand V. Avati 

BUG: 1274 (nfs fails to start)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1274

nfs3: NULL fdentry check before removing from fdcache

2010-07-28T10:10:02+00:00

Suppose a file name 1 is created and some data is written to it. After this
another 512 files are newly created and written to. When the the 513th file is
created and an fd_t opened for it, it results in 1's fd_t being replaced in the
fd-lru with 513th file's fd_t. This is the correct behaviour resulting in all
refs getting unref from the fd_t of 1 and the fd and all related state being
freed.

But, in some workloads, some refs are still pending even after the fd_t is
removed from LRU, resulting in the fd still being bound to the inode. In
nfs3svc_remove_cbk, while removing the inode state, we also ensure that any
fd_ts in the cache for this inode are also removed. While removing the fd_t,
this situation where the fd_t has replaced with another, even while a ref
remains on the fd_t, results in a crash in the fdcache_remove path in
nfs3svc_remove_cbk. This happens because the fd_ctx_get results in a NULL value
because the ctx was already deleted when this fd_t was removed from fd-lru
earlier. This patch fixes the crash by introducing a NULL check.

Signed-off-by: Shehjar Tikoo 
Signed-off-by: Anand V. Avati 

BUG: 885 ([NFS Xlator] Crash in nfs3_fdcache_update)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=885

nfs3: Return ESTALE when fh resolver exhausts dirents

2010-07-28T09:24:41+00:00

During hard fh resolution, if a directory traversal goes right
through to end-of-dir without finding a hash match, we need to return
an ESTALE, not ENOENT.

Signed-off-by: Shehjar Tikoo 
Signed-off-by: Anand V. Avati 

BUG: 854 (nfs server didn't start)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=854