glusterfs.git/xlators/nfs/server/src/nfs3.c, branch v3.7.20

nfs : store sattr properly in nfs3_setattr() call

2016-06-24T10:19:49+00:00

nfs3_setattr stores the input arguments in cs->stbuf.
However, inode/entry resolution code overwrites cs->stbuf
after a successful resolution, thereby overwriting the
input arguments with iatt values stored on backend.
Hence operations like chmod/chown turns out to be a NOP.
Specifically following are the functions that overwrite
cs->stbuf:

    nfs3_fh_resolve_inode_lookup_cbk
    nfs3_fh_resolve_entry_lookup_cbk

Since we resort to inode resolution only when inode is not
found in inode table and lru limit guards the number of
inodes in itable, we run into this issue only when the data
set is bigger than lru limit of itable.

Fix is to store input arguments in a member other than
cs->stbuf.

Thanks Du for suggesting the fix

        Backport of http://review.gluster.org/#/c/14657/

> Change-Id: I7caef48839d4f177c3557d7823fc1d35c8294939
> BUG: 1318204
> Signed-off-by: Jiffin Tony Thottan 
> Signed-off-by: Manikandan Selvaganesh 

Change-Id: I7caef48839d4f177c3557d7823fc1d35c8294939
BUG: 1343362
Signed-off-by: Manikandan Selvaganesh 
Reviewed-on: http://review.gluster.org/14659
Reviewed-by: jiffin tony Thottan 
Reviewed-by: Niels de Vos 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Raghavendra G 
Smoke: Gluster Build System

core, shard: Make shards inherit main file's O_DIRECT flag if present

2016-06-16T16:04:10+00:00

        Backport of: http://review.gluster.org/14191

If the application opens a file with O_DIRECT, the shards'
anon fds would also need to inherit the flag. Towards this,
shard xl would be passing the odirect flag in the @flags parameter
to the WRITEV fop. This will be used in anon fd resolution
and subsequent opening by posix xl.

Change-Id: I3a0593fa46cc25e390a5762a0354b469c2a1532d
BUG: 1342903
Signed-off-by: Krutika Dhananjay 
Reviewed-on: http://review.gluster.org/14663
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Jeff Darcy

NFS: new option nfs.rdirplus added

2016-04-18T17:03:56+00:00

When this option is 'disabled', NFS falls back to standard readdir instead
of readdirp

Backport of http://review.gluster.org/#/c/13782/

> Change-Id: Icaaf4da6533bee56160d4a81e42bb60f7d341945
> BUG: 1302948
> Signed-off-by: Sakshi Bansal 

Change-Id: Icaaf4da6533bee56160d4a81e42bb60f7d341945
BUG: 1312721
Signed-off-by: Sakshi Bansal 
Reviewed-on: http://review.gluster.org/13916
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Niels de Vos

nfs : avoid invalid usage of `cs` variable in nfs fops

2015-10-30T16:20:30+00:00

Due to changes from http://review.gluster.org/#/c/12162/ a path variable
is added to nfs3_log_common_res() and usually `cs->resolvedloc.path` is
passed for that. But in certain fop function `cs` may not filled due error
and when it is logged using nfs3_log_common_res() results in a crash.
This patch will fix the same.

Cherry picked from commit ee4f6175d1e1e6d6b82631d72c993db5691ad205:
> Change-Id: I5a709818923e7884bd04e329834ee352a1b3a58f
> BUG: 1276243
> Signed-off-by: Jiffin Tony Thottan 
> Reviewed-on: http://review.gluster.org/12458
> Reviewed-by: Niels de Vos 
> Tested-by: NetBSD Build System 
> Tested-by: Gluster Build System 
> Reviewed-by: N Balachandran 

Change-Id: I5a709818923e7884bd04e329834ee352a1b3a58f
BUG: 1276244
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/12471
Reviewed-by: jiffin tony Thottan 
Reviewed-by: N Balachandran 
Tested-by: Gluster Build System 
Reviewed-by: Kaleb KEITHLEY

nfs : logging improvements

2015-09-15T16:13:13+00:00

NFS log-warning messages logged twice in cbk function. Though,
the logging messages are not exactly duplicate, instead of
logging twice, they can be merged to one log message and the
other log message is removed in cbk functions.

Example:
(1)
W [nfs3.c:2075:nfs3svc_write_cbk] 0-nfs: 16f4dce6:
        /f.195 => -1 (Disk quota exceeded)
(2)
W [nfs3-helpers.c:3443:nfs3_log_write_res] 0-nfs-nfsv3:
        XID: 16f4dce6, WRITE: NFS: 69(Resource (quota)
        hard limit exceeded), POSIX: 122
        (Disk quota exceeded), count: 0, UNSTABLE,
        wverf: 1381508849

Here, the second message is more elaborative, and is similar
to (1). Since file name is not present in (2), it is added to (2)
and then removing all mesages of type (1).

        Backport of http://review.gluster.org/#/c/11936/

Cherry picked from commit 0166dca4f268f07dcbf9db7ca971ed16e296e8b7
> Change-Id: I6028ab17b23948493a065dfad92fe4984548511f
> BUG: 1254146
> Signed-off-by: Manikandan Selvaganesh 
> Reviewed-on: http://review.gluster.org/11936
> Tested-by: NetBSD Build System 
> Reviewed-by: jiffin tony Thottan 
> Tested-by: Gluster Build System 
> Reviewed-by: Niels de Vos 

Change-Id: I6028ab17b23948493a065dfad92fe4984548511f
BUG: 1262344
Signed-off-by: Manikandan Selvaganesh 
Reviewed-on: http://review.gluster.org/12162
Tested-by: Gluster Build System 
Reviewed-by: jiffin tony Thottan 
Tested-by: NetBSD Build System 
Reviewed-by: Niels de Vos

nfs: a unix-domain-socket should not be created as fifo

2015-07-23T16:01:45+00:00

Cherry picked from commit 381afd4f480533f212e1f62a0ccfd9dcf7248e17:
> Change-Id: Ic6a23165df1703b330636a059967c3c674dbde57
> BUG: 1235231
> Signed-off-by: Niels de Vos 
> Reviewed-on: http://review.gluster.org/11355
> Tested-by: NetBSD Build System 
> Reviewed-by: Kaleb KEITHLEY 
> Tested-by: Gluster Build System 

Change-Id: Ic6a23165df1703b330636a059967c3c674dbde57
BUG: 1244114
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/11708
Tested-by: Gluster Build System 
Reviewed-by: Kaleb KEITHLEY 
Tested-by: NetBSD Build System

nfs.c nfs3.c: port log messages to a new framework

2015-06-14T10:45:53+00:00

        Backport of http://review.gluster.org/#/c/10216/

Cherry picked from 6601aad8380f0f0ccbd4bb9147d8d3584a88da20
> Change-Id: I9ddb90d66d3ad3adb2916c0c949834794ee7bdf3
> BUG: 1194640
> Signed-off-by: Hari Gowtham 
> Reviewed-on: http://review.gluster.org/10216
> Tested-by: Gluster Build System 
> Reviewed-by: Niels de Vos 

Change-Id: I9ddb90d66d3ad3adb2916c0c949834794ee7bdf3
BUG: 1217722
Signed-off-by: Hari Gowtham 
Reviewed-on: http://review.gluster.org/11146
Tested-by: Gluster Build System 
Reviewed-by: jiffin tony Thottan 
Reviewed-by: Niels de Vos

nfs: do not overwrite the return value and errno of resolve operation

2015-04-13T05:45:24+00:00

* In auth status check which is done in the resume function, the op_ret and
  op_errno values saved in nfs3_call_state are overwritten by the return value
  of the auth status check function.

Change-Id: Id4682ddd399c78a1cef6313a534892ef309c57a6
BUG: 1210338
Signed-off-by: Raghavendra Bhat 
Reviewed-on: http://review.gluster.org/10179
Tested-by: Gluster Build System 
Reviewed-by: Venky Shankar 
Reviewed-by: Niels de Vos

Avoid conflict between contrib/uuid and system uuid

2015-04-04T17:48:35+00:00

glusterfs relies on Linux uuid implementation, which
API is incompatible with most other systems's uuid. As
a result, libglusterfs has to embed contrib/uuid,
which is the Linux implementation, on non Linux systems.
This implementation is incompatible with systtem's
built in, but the symbols have the same names.

Usually this is not a problem because when we link
with -lglusterfs, libc's symbols are trumped. However
there is a problem when a program not linked with
-lglusterfs will dlopen() glusterfs component. In
such a case, libc's uuid implementation is already
loaded in the calling program, and it will be used
instead of libglusterfs's implementation, causing
crashes.

A possible workaround is to use pre-load libglusterfs
in the calling program (using LD_PRELOAD on NetBSD for
instance), but such a mechanism is not portable, nor
is it flexible. A much better approach is to rename
libglusterfs's uuid_* functions to gf_uuid_* to avoid
any possible conflict. This is what this change attempts.

BUG: 1206587
Change-Id: I9ccd3e13afed1c7fc18508e92c7beb0f5d49f31a
Signed-off-by: Emmanuel Dreyfus 
Reviewed-on: http://review.gluster.org/10017
Tested-by: Gluster Build System 
Reviewed-by: Niels de Vos

gNFS: Export / Netgroup authentication on Gluster NFS mount

2015-03-15T14:01:38+00:00

* Parses linux style export file/netgroups file into a structure that
  can be lookedup.

* This parser turns each line into a structure called an "export
  directory". Each of these has a dictionary of hosts and netgroups
  which can be looked up during the mount authentication process.
  (See Change-Id Ic060aac and I7e6aa6bc)

* A string beginning withan '@' is treated as a netgroup and a string
  beginning without an @ is a host.
  (See Change-Id Ie04800d)

* This parser does not currently support all the options in the man page
  ('man exports'), but we can easily add them.

BUG: 1143880
URL: http://www.gluster.org/community/documentation/index.php/Features/Exports_Netgroups_Authentication
Change-Id: I181e8c1814d6ef3cae5b4d88353622734f0c0f0b
Original-author: Shreyas Siravara 
CC: Richard Wareing 
CC: Jiffin Tony Thottan 
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/8758
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur