glusterfs.git/xlators/nfs/server/src, branch v3.3.0qa12

NFS : Posix compliance fixes.

2011-09-22T11:51:22+00:00

Change-Id: I4f1d8883a3eedee20557e306815674a6dc062bfe
BUG: 1337
Reviewed-on: http://review.gluster.com/487
Tested-by: Gluster Build System 
Reviewed-by: Amar Tumballi 
Reviewed-by: Vijay Bellur

nfs: enhance NFS log messages.

2011-09-22T06:55:14+00:00

Change-Id: I6c2eaa2795756f515b5fb2ea5098d3dcb4ef77c4
BUG: 3527
Reviewed-on: http://review.gluster.com/433
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

mount/nfs: Gluster nfs crashes with subdirectory mount

2011-09-08T07:23:15+00:00

Glusterfs used to crash trying to dereference a NULL
pointer. Also, in mnt3_resolve_export_subdir, volume
name was prefixed to sub directory exported, resulting in
mount fail of sub directory. Fixed both issues.

Change-Id: I746f0c244b4cbf03033d73ac3e40518762d76385
BUG: 3481
Reviewed-on: http://review.gluster.com/323
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

nfs3: Resolve entry vs. hash conflict at same dir depth

2011-09-08T06:53:44+00:00

Intro Note
==========
The current code in hard fh resolution takes the first-match approach, i.e.
which ever dirent either matches the hash or matches the gfid first
is the one chosen as the result for the next step of fh resolution. In
the latter case, i.e., dirent matches the gfid, we the next step is to
conclude the fh resolution by returning the entry whose gfid matched.
In the former, i.e., the hash matches the dirent, we choose the hash-matching
dirent as the next directory to descend into, for searching the file to be
operated upon.

Problem
=======
When performing hard fh resolution, there can be a situation where:

o the hash of the primary entry,i.e. the entry we're looking for and the hash
of another sibling directory, match. Note the use of "sibling", meaning both
the primary entry and the hash matching one are in the same directory, i.e.,
their filehandle.hashcount will be same.

o the sibling directory is encountered first during the dir search.

Because of the current code described in "Intro", we'll end up descending into
the sibling directory even though the correct behaviour is to ignore this and
wait till we encounter the primary entry in the same parent directory.

Once we end up descending into this sibling directory, the directory depth
validation check fails. The check fails because it notices that the resolution
is attempting to open a directory that is deeper in the fs tree than the file
we're looking for. When this check fails, we return an ESTALE. So basically, a
false-positive results in an estale to Specsfs.

This is not a theoretical situation. Me and Avati saw this on specsfs test
where sfs created terabytes-sized file system for its tests. The number of
files was so huge in a single directory that the hashes of two entries ended up
colliding.

Change-Id: I4a6df11d326a67a507b1cd716c2c8e00b5a858a4
BUG: 3510
Reviewed-on: http://review.gluster.com/357
Tested-by: Gluster Build System 
Reviewed-by: Shehjar Tikoo

Eliminate many "var set but not used" warnings with newer gcc.

2011-09-08T06:48:01+00:00

This fixes ~200 such warnings, but leaves three categories untouched.

(1) Rpcgen code.

(2) Macros which set variables in the outer (calling function) scope.

(3) Variables which are set via function calls which may have side effects.

Change-Id: I6554555f78ed26134251504b038da7e94adacbcd
BUG: 2550
Reviewed-on: http://review.gluster.com/371
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

mem-pool: Make mem-pool ptr avialable in ptr

2011-08-25T19:01:08+00:00

The header of the ptr returned from mem-pool will now store the
mem-pool ptr it belongs to. mem_put will now take only the pointer
to be freed.

Also, changing MALLOC call to GF_CALLOC in mem_get when we run out
of entries in mem-pool. This also will have the header information
saved.

Change-Id: I3de182663a7f5b49c9e9425e9531775b70bdff67
BUG: 3390
Reviewed-on: http://review.gluster.com/205
Reviewed-by: Amar Tumballi 
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

if nfs.port is not configured init the transport.socket.listen-port to GF_NFS3_PORT

2011-08-20T10:54:46+00:00

Change-Id: I6c0db600ba2010b0a0272f58b16c4955b4b570f2
BUG: 3308
Reviewed-on: http://review.gluster.com/273
Reviewed-by: Vijay Bellur 
Tested-by: Gluster Build System

xlators/nfs: Fix a typo in option description

2011-08-20T10:34:58+00:00

Change-Id: I626893fd16094742869d4abfa488b66924c2796e
BUG: 3445
Reviewed-on: http://review.gluster.com/276
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

xlator options: revamp xlator option validation/reconfigure code

2011-08-19T06:49:03+00:00

- move option handling to options.c (new file)
- remove duplication of option validation code
- remove duplication of gf_log / sprintf
- get rid of xlator_t->validate_options
- get rid of option validation in rpc-transport
- get rid of validate_options() in every xlator
- use xlator_volume_option_get to clean up many functions
- introduce primitives to init/reconfigure option types

Change-Id: I51798af72c8dc0a2b9e017424036eb3667dfc7ff
BUG: 3415
Reviewed-on: http://review.gluster.com/235
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

do rpcsvc_init() after we fill nfs_state structure and add to nfsx->options keys for allowing insecure client ports.

2011-08-18T12:12:49+00:00

Change-Id: Iae755d1460f2c7296fc7980b5257afcf778e7767
BUG: 3296
Reviewed-on: http://review.gluster.com/247
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur