glusterfs.git/xlators/nfs, branch v3.4.4

core: fix Ubuntu code audit (cppcheck) results

2014-05-25T10:52:01+00:00

These block inclusion in Ubuntu Main repo.

AFAICT these are false positives:

[rpc/rpc-transport/rdma/src/rdma.c:3074]: (error) Address of local auto-variable assigned to a function parameter.
[xlators/features/marker/utils/src/gsyncd.c:99]: (error) Memory leak: str
[xlators/features/marker/utils/src/gsyncd.c:354]: (error) Memory leak: argv
[xlators/nfs/server/src/nlm4.c:1176]: (error) Possible null pointer dereference: fde

The remainder are fixed with this change-set:

[api/src/glfs-fops.c:700]: (error) Possible null pointer dereference: gio
[api/src/glfs-fops.c:702]: (error) Possible null pointer dereference: frame
[xlators/cluster/afr/src/afr-inode-write.c:375]: (error) Possible null pointer dereference: frame
[xlators/cluster/afr/src/afr-self-heal-common.c:1522]: (error) Possible null pointer dereference: local
[xlators/cluster/dht/src/dht-rebalance.c:1574]: (error) Possible null pointer dereference: ctx
[xlators/cluster/stripe/src/stripe.c:4407]: (error) Possible null pointer dereference: local
[xlators/mgmt/glusterd/src/glusterd-mountbroker.c:675]: (error) Possible null pointer dereference: cookieswitch
[xlators/mgmt/glusterd/src/glusterd-mountbroker.c:677]: (error) Possible null pointer dereference: cookieswitch
[xlators/mgmt/glusterd/src/glusterd-replace-brick.c:924]: (error) Resource leak: file
[xlators/mgmt/glusterd/src/glusterd-replace-brick.c:1008]: (error) Resource leak: file
[xlators/mgmt/glusterd/src/glusterd-sm.c:248]: (error) Possible null pointer dereference: new_ev_ctx
[xlators/mgmt/glusterd/src/glusterd-store.c:1250]: (error) Possible null pointer dereference: handle
[xlators/mgmt/glusterd/src/glusterd-utils.c:4272]: (error) Possible null pointer dereference: this
[xlators/mgmt/glusterd/src/glusterd-utils.c:5113]: (error) Possible null pointer dereference: this
[xlators/mount/fuse/src/fuse-bridge.c:4432]: (error) Uninitialized variable: finh
[xlators/mount/fuse/src/fuse-bridge.c:2927]: (error) Possible null pointer dereference: state
[xlators/mount/fuse/src/fuse-bridge.c:3226]: (error) Possible null pointer dereference: state
[xlators/storage/bd_map/src/bd_map.c:1504]: (error) Possible null pointer dereference: bd_fd
[xlators/storage/bd_map/src/bd_map.c:1728]: (error) Possible null pointer dereference: n_entry
[xlators/storage/bd_map/src/bd_map.c:1741]: (error) Possible null pointer dereference: n_entry
[xlators/performance/quick-read/src/quick-read.c:585]: (error) Possible null pointer dereference: iobuf

rerunning cppcheck --force afterwards:

Test code, don't care:
[extras/test/test-ffop.c:27]: (error) Buffer overrun possible for long command line arguments.

False positive after fix
[xlators/cluster/stripe/src/stripe.c:4407]: (error) Possible null pointer dereference: local

Still false positive:
[xlators/features/marker/utils/src/gsyncd.c:354]: (error) Memory leak: argv
[xlators/nfs/server/src/nlm4.c:1176]: (error) Possible null pointer dereference: fde

Not built, don't care:
[xlators/cluster/ha/src/ha.c:2699]: (error) Possible null pointer dereference: priv

Change-Id: I1fb849e9c042d3a3701cb05121d413e58e73d505
BUG: 1086460
Signed-off-by: Kaleb S. KEITHLEY 
Reviewed-on: http://review.gluster.org/7583
Reviewed-by: Vijay Bellur 
Tested-by: Gluster Build System

nfs: exit when all volumes are disabled

2014-05-15T02:36:21+00:00

Instead of triggering 4-5 error logs, when nfs is
disabled for all volumes, exit the process.

backport from 3.5

Change-Id: I191294232f5848a4a01609b477289d628cf89ba5
BUG: 1095330
Signed-off-by: Kaleb S. KEITHLEY 
Reviewed-on: http://review.gluster.org/7699
Tested-by: Gluster Build System 
Reviewed-by: Pranith Kumar Karampuri 
Tested-by: Pranith Kumar Karampuri

nfs: Fix for NFS crash during blocking NLM call.

2014-04-14T20:56:47+00:00

Bug 990887: During a blocking NLM call NFS server is crashing.

Cause: When nlm4_establish_callback function is called from nlm4svc_send_granted the cs->req->trans
pointer is NULL. Thus using this pointer will result in a crash. Whereas cs->trans points to a
valid transport object. NLM should use cs->trans instead of cs->req->trans.

Fix: Replaced cs->req->trans with cs->trans.

Backport of: http://review.gluster.org/#/c/5452/

BUG: 990887
Change-Id: I33d4b6634752333d6791b1a47ebf10c787c22120
Signed-off-by: Justin Clift 
Reviewed-on: http://review.gluster.org/7478
Reviewed-by: Harshavardhana 
Reviewed-by: Kaleb KEITHLEY

dual license: update remaining files with correct license text

2013-10-30T22:22:29+00:00

Sayan Saha has previously approved changing everthing to dual license
but somehow we have missed changing these files.

I am explicitly not updating the copyright dates as nothing else that's
copyrightable has changed in these files with the license change

Change-Id: I498eb648527a2c55a384df335b555bd5c6087e03
BUG: 951551
Signed-off-by: Kaleb S. KEITHLEY 
Reviewed-on: http://review.gluster.org/6129
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

nfs/mount3: fix crash in subdir resolution

2013-10-14T17:20:41+00:00

* __mnt3_resolve_export_subdir_comp: if nfs_entry_loc_fill fails,
  mres->resolveloc does not contain valid data
* gf_log should use 'gfid' instead of mres->resolveloc.inode->gfid
* fixes a crash if program flow gets to this line

Backport FIX link: http://review.gluster.org/4948

Signed-off-by: Santosh Kumar Pradhan 

Change-Id: I6dea17ae3f07210430a0b71bd08be6f59f739c9a
BUG: 1018547
Signed-off-by: Santosh Kumar Pradhan 
Reviewed-on: http://review.gluster.org/6083
Tested-by: Gluster Build System 
Reviewed-by: Rajesh Joseph

gNFS: avoid double fd unref in opendir

2013-09-25T06:49:41+00:00

Noticed that the fd_unref was called on the fd regardless of the return
value at nfs3svc_opendir_readdir_cbk(), hence removing an extra unref in
the negative case in nfs_inode_opendir_cbk, which fixes the spurious
fd_unref().

Back port of: http://review.gluster.org/4943 (Rajesh Amaravathi)

Change-Id: Ibddf487c7890407d01befedd65eefb10cb9c989f
BUG: 1011761
Signed-off-by: Santosh Kumar Pradhan 
Reviewed-on: http://review.gluster.org/5996
Reviewed-by: Rajesh Joseph 
Tested-by: Gluster Build System

core: increase the auxillary group limit to 65536

2013-09-10T00:25:38+00:00

Make the allocation of groups dynamic and increase the limit
to 65536.

Change-Id: I702364ff460e3a982e44ccbcb3e337cac9c2df51
BUG: 953694
Signed-off-by: Anand Avati 
Reviewed-on: http://review.gluster.org/5172
Reviewed-by: Xavier Hernandez 
Tested-by: Gluster Build System

nfs: prevent NFS server crash when upgrading from 3.2.x server

2013-09-10T00:16:41+00:00

After an upgrade the NFS3 filehandle size changed (became smaller),
but when doing a live ugprade the client would send the old handle
(expect ESTALE and do fresh lookup). But when reading the old
handle we were reading it into a structure which was limited to the
size of the new handle, while we should have been reading into a
buffer which is as big as the NFS3 spec permits the handle size to
be. The actor functions declare the structure on the stack. So the
overflow is resulting in a stack corruption.

Change-Id: Ie930875ac9db46b43d1cb8ad1e6d89cdaeded7ca
BUG: 1002385
Signed-off-by: Anand Avati 
Reviewed-on: http://review.gluster.org/5730
Reviewed-by: Rajesh Joseph 
Reviewed-by: Niels de Vos 
Tested-by: Gluster Build System 
Reviewed-on: http://review.gluster.org/5804
Reviewed-by: Kaleb KEITHLEY

nfs/server: Fix multiple crashes in acl handler.

2013-03-03T14:19:39+00:00

Change-Id: I67c224c74c02f7058bcf546713501dd7ab810826
BUG: 915280
Signed-off-by: Vijay Bellur 
Reviewed-on: http://review.gluster.org/4606
Reviewed-by: Jeff Darcy 
Tested-by: Gluster Build System

Use proper libtool option -avoid-version instead of bogus -avoidversion

2013-02-07T23:12:56+00:00

Change-Id: I1c9541058c7d07786539a3266ca125a6a15287d8
BUG: 859835
Signed-off-by: Anand Avati 
Original-author: Kacper Kowalik (Xarthisius) 
Signed-off-by: Kacper Kowalik (Xarthisius) 
Reviewed-on: http://review.gluster.org/3967
Tested-by: Gluster Build System