glusterfs.git/xlators/protocol/client/src/client-handshake.c, branch v3.3.0qa35

core: adding extra data for fops

2012-03-22T23:40:27+00:00

with this change, the xlator APIs will have a dictionary as extra
argument, which is passed between all the layers. This can be
utilized for overloading in some of the operations.

Change-Id: I58a8186b3ef647650280e63f3e5e9b9de7827b40
Signed-off-by: Amar Tumballi 
BUG: 782265
Reviewed-on: http://review.gluster.com/2960
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

protocol/client: Handle failures in lock self healing gracefully (part2).

2012-03-19T16:16:23+00:00

During reopening of fd's and reacquiring of locks on the fd (after a
reconnect), a release on a fd on which reacquiring of locks is in progress
will free up fdctx. This patch will keep fdctx valid until the reacquiring
of locks is in progress.

Change-Id: I0fae27544a7f8ddaa26def4ee4d41a8a2b322521
BUG: 795386
Signed-off-by: Mohammed Junaid 
Reviewed-on: http://review.gluster.com/2819
Reviewed-by: Amar Tumballi 
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

protocol/client: replace STACK_UNWIND_STRICT macro with CLIENT_STACK_UNWIND,

2012-03-18T08:52:37+00:00

which does appropraite cleanup before unwinding.

Signed-off-by: Raghavendra G 
Change-Id: Ic49d6e21c5fc56e747afec35be2bebbbbd2a6583
BUG: 767359
Reviewed-on: http://review.gluster.com/2897
Tested-by: Gluster Build System 
Reviewed-by: Amar Tumballi 
Reviewed-by: Anand Avati

rpc: don't unwind the fop in caller if client_submit_request fails

2012-03-18T08:52:04+00:00

client_submit_request guarantees that the cbkfn - which we pass to
it as argument - is called whenever there is a failure.

Change-Id: I0e8ce5a6b320246dc13ce4318b04739d38d183a3
BUG: 767359
Signed-off-by: Raghavendra G 
Reviewed-on: http://review.gluster.com/2896
Tested-by: Gluster Build System 
Reviewed-by: Amar Tumballi 
Reviewed-by: Anand Avati

protocol/client: Added lk_ctx info in fdctx dump

2012-03-07T18:17:41+00:00

- Added a brief explanation as to why we can't use gf_log
  when in statedump.

- Removed gf_log messages from client_priv_dump since
  it can cause a 'deadlock' - See statedump.c for explanation

- Added try-lock based accessors for fd_lk_list for dump purposes.

Change-Id: I1d755a4ef2c568acf22fb8c4ab0a33a4f5fd07b4
BUG: 789858
Signed-off-by: Krishnan Parthasarathi 
Reviewed-on: http://review.gluster.com/2882
Tested-by: Gluster Build System 
Reviewed-by: Amar Tumballi 
Reviewed-by: Vijay Bellur

protocol/client: Calling GF_FREE on memory allocated via GF_CALLOC.

2012-03-01T18:02:42+00:00

This is a temporary fix. A clean fix would be to allocate memory using mem_get0
and free via mem_put.

Change-Id: I6351ab22c2f05ba8fa4aaad67f375027df873807
BUG: 796656
Signed-off-by: Mohammed Junaid 
Reviewed-on: http://review.gluster.com/2852
Reviewed-by: Amar Tumballi 
Tested-by: Gluster Build System

protocol/client: send unique key to server during handshake

2012-02-29T10:16:07+00:00

utilize the graph->id for making the key unique.

Change-Id: I0c1b355aa901af88e65fd12cb9e0535318856867
BUG: 783982
Signed-off-by: Amar Tumballi 
Reviewed-on: http://review.gluster.com/2831
Tested-by: Gluster Build System 
Reviewed-by: Jeff Darcy 
Reviewed-by: Mohammed Junaid

core: utilize mempool for frame->local allocations

2012-02-21T10:42:09+00:00

in each translator, which uses 'frame->local', we are using
GF_CALLOC/GF_FREE, which would be costly considering the
number of allocation happening in a lifetime of 'fop'. It
would be good to utilize the mem pool framework for xlator's
local structures, so there is no allocation overhead.

Change-Id: Ida6e65039a24d9c219b380aa1c3559f36046dc94
Signed-off-by: Amar Tumballi 
BUG: 765336
Reviewed-on: http://review.gluster.com/2772
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

protocol/client,server: fcntl lock self healing.

2012-02-20T12:45:31+00:00

Currently(with out this patch), on a disconnect the server cleans up
the transport which inturn closes the fd's and releases the locks acquired on
those fd's by that client. On a reconnect, client just reopens the fd's but
doesn't reacquire the locks. The application that had previously acquired
the locks still is under the assumption that it is the owner of those locks
which might have been granted to other clients(if they request) by the server
leading to data corruption.

This patch allows the client to reacquire the fcntl locks (held on the fd's)
during client-server handshake.

* The server identifies the client via process-uuid-xl (which is a combination
  of uuid and client-protocol name, it is assumed to be unique) and lk-version
  number.

* The client maintains a list of process-uuid-xl, lk-version pair for each
  accepted connection. On a connect, the server traverses the list for a
  matching pair, if a matching pair is not found the the server returns
  lk-version with value 0, else it returns the lk-version it has in store.

* On a disconnect, the server and client enter grace period, and on the
  completion of the grace period, the client bumps up its lk-version number
  (which means, it will reacquire the locks the next time) and the server will
  distroy the connection. If reconnection happens within the grace period, the
  server will find the matching (process-uuid-xl, lk-version) pair in its list
  which guarantees that the fd's and there corresponding locks are still valid
  for this client.

Configurable options:
  To set grace-timeout, the following options are
    option server.grace-timeout value
    option client.grace-timeout value

  To enable or disable the lk-heal,
    option lk-heal [on|off]

gluster volume set command can be used to configurable options
Change-Id: Id677ef1087b300d649f278b8b2aa0d94eae85ed2
BUG: 795386
Signed-off-by: Mohammed Junaid 
Reviewed-on: http://review.gluster.com/2766
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

protocol xdr: remove 'path<>'

2012-02-14T12:34:06+00:00

client was sending 'path' on wire, which gets ignored on server
side, and also doesn't get freed up, which causes memory leak.

also with not having path on wire, the xdr size on wire most of the
time can remain constant, which helps in allocating RDMA buffers.

Change-Id: Ie0d36a670be60b02fd1e925c6f977b1a71def5cd
BUG: 790298
Signed-off-by: Amar Tumballi 
Reviewed-on: http://review.gluster.com/2744
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati