glusterfs.git/xlators/protocol/server/src, branch release-3.13

protocol/server: fix the comparision logic in case of subdir mount

2017-10-24T12:21:27+00:00

without the fix, the stat entry on a file would return inode==1 for
many files, in case of subdir mount

This happened with the confusion of return value of 'gf_uuid_compare()',
it is more like strcmp, instead of a gf_boolean return value, and hence
resulted in the bug.

Change-Id: I31b8cbd95eaa3af5ff916a969458e8e4020c86bb
BUG: 1505527
Signed-off-by: Amar Tumballi

gfproxyd: Let glusterd manage gfproxy daemon

2017-10-18T14:15:05+00:00

Updates: #242
BUG: 1428063
Change-Id: Iaaf2edf99b2ecc75f6d30762c752a6d445c1c826
Signed-off-by: Poornima G

protocol-auth: use the proper validation method

2017-10-12T10:36:26+00:00

Currently, server protocol's init and glusterd's option
validation methods are different, causing an issue. They
should be same for having consistent behavior

Updates #175

Change-Id: Ibbf9a18c7192b2d77f9b7675ae7da9b8d2fe5de4
Signed-off-by: Amar Tumballi

xlators/protocol/server: Coverity Issue in server_setvolume()

2017-09-29T07:53:40+00:00

Issue: Event result_independent_of_operands: "rsp->dict.dict_len > 4294967295U
/* 2147483647 * 2U + 1U */" is always false regardless of the values of its
operands. This occurs as the logical operand of "if".

Fix: removed if block as the if condition is always false and statement inside
block never executes.

Change-Id: Ieaa968d6fbc9477428b4658ef725ace0db9b810a
BUG: 789278
Signed-off-by: Girjesh Rajoria

protocol: UNINIT coverity fix

2017-09-27T14:53:44+00:00

Problem: Coverity issue due uninitialized variable.

Solution: Initialized the variable appropriately.

Bug: 789278
Change-Id: I6e9356bbcd8fa97006b605ee162458d4a2eb5887
Signed-off-by: Akarsha Rai

eventsapi: Fix issue with CLIENT_CONNECT event

2017-09-19T10:54:12+00:00

A mismatch in event format causing below error in events.log when
it detects CLIENT_CONNECT event.

    [2017-09-19 09:35:06,785] WARNING [glustereventsd - 46:handle] -
    Unable to parse Event 1505793906 97
    client_uid=f241-16363-2017/09/19-04:05:06:747558-gv1-client-
    0-0-0;client_identifier=192.168.122.208:49150;server_identifier=
    192.168.122.208:49152;brick_path=/bricks/b1,subdir_mount=(null)

BUG: 1492968
Change-Id: Ie6d507725a7e6b54fca44651f9c5e66eca2be244
Signed-off-by: Aravinda VK 
Reviewed-on: https://review.gluster.org/18322
Reviewed-by: Atin Mukherjee 
Smoke: Gluster Build System 
Reviewed-by: Amar Tumballi 
CentOS-regression: Gluster Build System 
Reviewed-by: Prashanth Pai

protocol/server: Remove duplicate dict_get_str

2017-09-13T16:16:33+00:00

dict_get_str() for auth-path has been already done once within switch
case for RPCSVC_EVENT_DISCONNECT inside server_rpc_notify(). Therefore
this change removes the needless dict_get_str.

Change-Id: Ifeb3db828328df08a1f1612a8ad8e0babace1d16
Signed-off-by: Anoop C S 
Reviewed-on: https://review.gluster.org/18272
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Jeff Darcy

Command to identify client process

2017-09-06T11:52:40+00:00

command: gluster volume status  client-list

output:
Client connections for volume v1
Name                                                       count
-----                                                     ------
fuse                                                           2
tierd                                                          1

total clients for volume v1 : 3
-----------------------------------------------------------------

Client connections for volume v2
Name                                                       count
-----                                                     ------
tierd                                                          1
fuse.gsync                                                     1

total clients for volume v2 : 2
-----------------------------------------------------------------

Updates: #178
Change-Id: I0ff2579d6adf57cc0d3bd0161a2ec6ac6c4747c0
Signed-off-by: hari gowtham 
Reviewed-on: https://review.gluster.org/18095
Smoke: Gluster Build System 
Tested-by: hari gowtham 
CentOS-regression: Gluster Build System 
Reviewed-by: Atin Mukherjee

rpc: destroy transport after client_t

2017-08-31T03:45:09+00:00

Problem:
1. Ref counting increment on the client_t object is done in
   rpcsvc_request_init() which is incorrect.
2. Ref not taken when delegating to grace_time_handler()

Solution:
1. Only fop requests which require processing down the graph via
   stack 'frames' now ref count the request in get_frame_from_request()
2. Take ref on client_t object in server_rpc_notify() but avoid
   dropping in RPCSVC_EVENT_TRANSPORT_DESRTROY. Drop the ref
   unconditionally when exiting out of grace_time_handler().
   Also, avoid dropping ref on client_t in
   RPCSVC_EVENT_TRANSPORT_DESTROY when ref mangement as been
   delegated to grace_time_handler()

Change-Id: Ic16246bebc7ea4490545b26564658f4b081675e4
BUG: 1481600
Reported-by: Raghavendra G 
Signed-off-by: Milind Changire 
Reviewed-on: https://review.gluster.org/17982
Tested-by: Raghavendra G 
Reviewed-by: Raghavendra G 
CentOS-regression: Gluster Build System 
Smoke: Gluster Build System

Infra to indentify process

2017-08-16T15:38:49+00:00

Problem: currently we can't identify which process is running and
how many instances of it are available.

Fix: name the process when its spawned and send it to the server
and save it in the client_t

The processes that abide by this change from this patch are:
1) fuse mount,
2) rebalance,
3) selfheal,
4) tier,
5) quota,
6) snapshot,
7) brick.
8) gfapi (by default. gfapi. if processname is found)

Note: fuse gets a process name as native-fuse-client by default.
If the user gives a name for the fuse and spawns it, it will be of
this type --process-name native-fuse-client..
This can be made use by the process like aux mount done by quota,
geo-rep, etc by adding another option in the aux mount " -o
process-name=gsync_mount"

Updates: #178
Signed-off-by: hari gowtham 
Change-Id: Ie4d02257216839338043737691753bab9a974d5e
Reviewed-on: https://review.gluster.org/17957
Smoke: Gluster Build System 
Tested-by: hari gowtham 
Reviewed-by: Amar Tumballi 
CentOS-regression: Gluster Build System 
Reviewed-by: Atin Mukherjee 
Reviewed-by: Aravinda VK 
Reviewed-by: Niels de Vos