glusterfs.git/xlators/protocol, branch v3.13.0beta

protocol/client: handle the subdir handshake properly for add-brick

2017-10-29T07:55:42+00:00

There should be different way we handle handshake in case of subdir
mount for the first time, and in case of subsequent graph changes.

Change-Id: I2a7ba836433bb0a0f4a861809e2bb0d7fbc4da54
BUG: 1505323
Signed-off-by: Amar Tumballi

protocol/server: fix the comparision logic in case of subdir mount

2017-10-24T12:21:27+00:00

without the fix, the stat entry on a file would return inode==1 for
many files, in case of subdir mount

This happened with the confusion of return value of 'gf_uuid_compare()',
it is more like strcmp, instead of a gf_boolean return value, and hence
resulted in the bug.

Change-Id: I31b8cbd95eaa3af5ff916a969458e8e4020c86bb
BUG: 1505527
Signed-off-by: Amar Tumballi

gfproxyd: Let glusterd manage gfproxy daemon

2017-10-18T14:15:05+00:00

Updates: #242
BUG: 1428063
Change-Id: Iaaf2edf99b2ecc75f6d30762c752a6d445c1c826
Signed-off-by: Poornima G

protocol-auth: use the proper validation method

2017-10-12T10:36:26+00:00

Currently, server protocol's init and glusterd's option
validation methods are different, causing an issue. They
should be same for having consistent behavior

Updates #175

Change-Id: Ibbf9a18c7192b2d77f9b7675ae7da9b8d2fe5de4
Signed-off-by: Amar Tumballi

Coverity issue fix: checked return

2017-10-04T10:00:12+00:00

issue:Calling "client_submit_request" without checking return value (as is done elsewhere 52 out of 58 times).

function: client_fdctx_destroy

Change-Id: I66a295dd114fc20f04eb1aca9a5b274df53be090
BUG: 789278
fix: typecasted function return value using void
Signed-off-by: Kartik_Burmee

protocol/client: Coverity Fix IDENTICAL_BRANCHES in client3_3_flush_cbk

2017-09-29T09:27:46+00:00

Issue : The same code is executed when the condition "ret < 0" is true
or false, because the code in the if-then branch and after the if
statement is identical.

Solution : Remove the if-condition whose output does not alter the
program flow of control

Fix : The identical branching condition was removed.

Change-Id: Iae40f068e5a03946273e1091886ba7011460fcc8
BUG: 789278
Signed-off-by: Mohammed Azhar Padariyakam

xlators/protocol/server: Coverity Issue in server_setvolume()

2017-09-29T07:53:40+00:00

Issue: Event result_independent_of_operands: "rsp->dict.dict_len > 4294967295U
/* 2147483647 * 2U + 1U */" is always false regardless of the values of its
operands. This occurs as the logical operand of "if".

Fix: removed if block as the if condition is always false and statement inside
block never executes.

Change-Id: Ieaa968d6fbc9477428b4658ef725ace0db9b810a
BUG: 789278
Signed-off-by: Girjesh Rajoria

protocol: UNINIT coverity fix

2017-09-27T14:53:44+00:00

Problem: Coverity issue due uninitialized variable.

Solution: Initialized the variable appropriately.

Bug: 789278
Change-Id: I6e9356bbcd8fa97006b605ee162458d4a2eb5887
Signed-off-by: Akarsha Rai

eventsapi: Fix issue with CLIENT_CONNECT event

2017-09-19T10:54:12+00:00

A mismatch in event format causing below error in events.log when
it detects CLIENT_CONNECT event.

    [2017-09-19 09:35:06,785] WARNING [glustereventsd - 46:handle] -
    Unable to parse Event 1505793906 97
    client_uid=f241-16363-2017/09/19-04:05:06:747558-gv1-client-
    0-0-0;client_identifier=192.168.122.208:49150;server_identifier=
    192.168.122.208:49152;brick_path=/bricks/b1,subdir_mount=(null)

BUG: 1492968
Change-Id: Ie6d507725a7e6b54fca44651f9c5e66eca2be244
Signed-off-by: Aravinda VK 
Reviewed-on: https://review.gluster.org/18322
Reviewed-by: Atin Mukherjee 
Smoke: Gluster Build System 
Reviewed-by: Amar Tumballi 
CentOS-regression: Gluster Build System 
Reviewed-by: Prashanth Pai

protocol/server: Remove duplicate dict_get_str

2017-09-13T16:16:33+00:00

dict_get_str() for auth-path has been already done once within switch
case for RPCSVC_EVENT_DISCONNECT inside server_rpc_notify(). Therefore
this change removes the needless dict_get_str.

Change-Id: Ifeb3db828328df08a1f1612a8ad8e0babace1d16
Signed-off-by: Anoop C S 
Reviewed-on: https://review.gluster.org/18272
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Jeff Darcy