glusterfs.git/xlators/storage/posix/src, branch v3.7.19

posix: make sure atime and mtime are set when calling lutimes()

2017-01-09T01:11:12+00:00

When overwriting an existing file with O_TRUNC, the 'atime' was set to
0, meaning the Epoch (01-Jan-1970 UTC). However, the 'mtime' gets
updated correcty.

In case 'atime' or 'mtime' is not passed in the 'struct iatt', the time
values passed to the systemcall are taken from the current values are
returned by lstat().

Cherry picked from commit 9bed81ada6f91f998e9abd915b18e3f06557cdcb:
> Change-Id: I7021b7161dcd6c9a3e515d98f6d4847533c434b3
> BUG: 1401777
> Reported-by: Eivind Sarto 
> Signed-off-by: Niels de Vos 
> Reviewed-on: http://review.gluster.org/16034
> Smoke: Gluster Build System 
> NetBSD-regression: NetBSD Build System 
> Reviewed-by: Raghavendra Bhat 
> CentOS-regression: Gluster Build System 
> Reviewed-by: Kaleb KEITHLEY 

Change-Id: I7021b7161dcd6c9a3e515d98f6d4847533c434b3
BUG: 1401122
Reported-by: Eivind Sarto 
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/16354
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Kaleb KEITHLEY

build: correctly format some (s)size_t messages

2016-09-07T11:49:42+00:00

On 32-bit builds the are are warnings like these:

    posix.c:6438: warning: format '%ld' expects type 'long int', but argument 11 has type 'ssize_t'

Instead of using "%l" for (signed) size_t variables, "%z" should be
used.

Cherry picked from commit 3af889f02722f4636d2ea30570de6477e8b5a3a9:
> BUG: 1198849
> Change-Id: I6f57b5e8ea174dd9e3056aff5da685e497894ccf
> Signed-off-by: Niels de Vos 
> Reviewed-on: http://review.gluster.org/14933
> NetBSD-regression: NetBSD Build System 
> CentOS-regression: Gluster Build System 
> Reviewed-by: Kaleb KEITHLEY 
> Smoke: Gluster Build System 

This patch is not really recommended for backporting, but we do have a
new smoke test that fails when these warnings pop-up. It is cleaner to
correct the code in the release-3.7 branch then to modify the smoke test
to skip this branch.

Change-Id: I6f57b5e8ea174dd9e3056aff5da685e497894ccf
BUG: 1225842
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/15401
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Kaleb KEITHLEY 
Smoke: Gluster Build System

storage/posix: Log EEXIST failures at DEBUG log-level

2016-08-17T10:22:34+00:00

        Backport of: http://review.gluster.org/15161

Change-Id: I98faa1170dae89879f678e8836f499bbc6ace675
BUG: 1367362
Signed-off-by: Krutika Dhananjay 
Reviewed-on: http://review.gluster.org/15174
NetBSD-regression: NetBSD Build System 
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Pranith Kumar Karampuri

posix: Do not move and recreate .glusterfs/unlink directory

2016-08-10T09:32:08+00:00

Problem:
At the time of start of a volume, it is checked if
.glusterfs/unlink exist or not. If it does, move it
to landfill and recreate unlink directory. If a volume
is mounted and we write data on it till we face ENOSPC,
restart of that volume fails as it will not be able to
create unlink dir. mkdir will fail with ENOSPC.
This will not allow volume to restart.

Solution:
If .glusterfs/unlink directory exist, don't move it to
landfill. Delete all the entries inside it.

master -
http://review.gluster.org/#/c/15030/

Change-Id: Icde3fb36012f2f01aeb119a2da042f761203c11f
BUG: 1364354
Signed-off-by: Ashish Pandey 
Reviewed-on: http://review.gluster.org/15092
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Smoke: Gluster Build System 
Reviewed-by: Pranith Kumar Karampuri

storage/posix: fix inode leaks

2016-08-10T08:40:19+00:00

> Reviewed-on: http://review.gluster.org/14739
> Smoke: Gluster Build System 
> CentOS-regression: Gluster Build System 
> NetBSD-regression: NetBSD Build System 
> Reviewed-by: N Balachandran 
> Reviewed-by: Pranith Kumar Karampuri 
> Reviewed-by: Krutika Dhananjay 

BUG: 1364886
Change-Id: Ibd221ba62af4db17bea5c52d37f5c0ba30b60a7d
Signed-off-by: Raghavendra G 
Signed-off-by: Oleksandr Natalenko 
Reviewed-on: http://review.gluster.org/15107
Reviewed-by: N Balachandran 
Smoke: Gluster Build System 
Reviewed-by: Prashanth Pai 
Reviewed-by: Krutika Dhananjay 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System

posix: leverage FALLOC_FL_ZERO_RANGE in zerofill fop

2016-08-08T10:58:12+00:00

posix_zerofill() implements zerofilling of a given (offset,length) by
doing a writev in a loop followed by an optional fsync on the file.
fallocate(2) has a FALLOC_FL_ZERO_RANGE flag which does away with all
this and provides the same result (from a userspace application point of
view) with a single syscall. This patch attempts the zerofill with the
latter and falls back to the former if it fails.

Tested using a libgfapi based C program on XFS and observed using gdb that
posix_zerofill()'s call to fallocate with FALLOC_FL_ZERO_RANGE was a
success.

> Reviewed-on: http://review.gluster.org/15037
> Reviewed-on: http://review.gluster.org/15100
> Smoke: Gluster Build System 
> CentOS-regression: Gluster Build System 
> NetBSD-regression: NetBSD Build System 
> Reviewed-by: Pranith Kumar Karampuri 

BUG: 1363750
Change-Id: I77e9b7de0d59c255f06b0c39c43a276990081727
Signed-off-by: Ravishankar N 
Signed-off-by: Oleksandr Natalenko 
Reviewed-on: http://review.gluster.org/15082
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Prashanth Pai 
CentOS-regression: Gluster Build System 
Reviewed-by: Pranith Kumar Karampuri

posix: fix posix_fgetxattr to return the correct error

2016-08-08T06:11:25+00:00

posix_fgetxattr used to not updating op_ret
and op_errno (initialized to -1 and ENOENT respectively)
on success cases. Hence, it can return ENOENT even if all
the opertions were sucessful.

BUG: 1358823
Change-Id: I1799ca7e48a4bd800a678366d2b6927d19c31f88
Signed-off-by: Susant Palai 
Reviewed-on: http://review.gluster.org/12745
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Pranith Kumar Karampuri 
Signed-off-by: Susant Palai 
Reviewed-on: http://review.gluster.org/13449
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System

storage/posix: Look for file in "unlink" dir IFF open on real-path fails with ENOENT

2016-07-30T12:29:39+00:00

        Backport of: http://review.gluster.org/#/c/15039/

PROBLEM:
In some of our users' setups, open() on the anon fd failed for
a reason other than ENOENT. But this error code is getting masked
by a subsequent open() under posix's hidden "unlink" directory, which
will fail with ENOENT because the gfid handle still exists under .glusterfs.
And the log message following the two open()s ends up logging ENOENT,
causing much confusion.

FIX:
Look for the presence of the file under "unlink" ONLY if the open()
on the real_path failed with ENOENT.

Change-Id: Id68bbe98740eea9889b17f8ea3126ed45970d26f
BUG: 1360785
Signed-off-by: Krutika Dhananjay 
Reviewed-on: http://review.gluster.org/15041
Smoke: Gluster Build System 
Reviewed-by: Pranith Kumar Karampuri 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System

storage/posix: Give correct errno for anon-fd operations

2016-07-29T16:00:46+00:00

 >Change-Id: Ia9e61d3baa6881eb7dc03dd8ddb6bfdde5a01958
 >BUG: 1343906
 >Signed-off-by: Pranith Kumar K 
 >Reviewed-on: http://review.gluster.org/14669
 >Smoke: Gluster Build System 
 >NetBSD-regression: NetBSD Build System 
 >CentOS-regression: Gluster Build System 
 >Reviewed-by: Raghavendra G 

BUG: 1360140
Change-Id: I553dd59424aaff9538e0798370846d653ca1cf32
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/15011
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Krutika Dhananjay

libglusterfs: Implement API that provides page-aligned iobufs

2016-06-30T04:37:08+00:00

        Backport of: http://review.gluster.org/14672

One of the consumers of a page aligned buffer would be posix's
readv fop on O_DIRECT fds. Today the way it works is by getting
a page-aligned buffer through calloc, pread()ing into this buffer
and then copying its contents into a newly created iobuf's ptr.
This results in an extra memcpy() which can be avoided if we could
implement an api that would return an iobuf whose ptr is
page-aligned. That way the iobuf->ptr can be directly passed to
sys_pread() as a parameter by posix translator.

Change-Id: Ie44c300dc773fef8e1669d609987d47dbd340ac2
BUG: 1351024
Signed-off-by: Krutika Dhananjay 
Reviewed-on: http://review.gluster.org/14826
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Zhou Zhengping 
Reviewed-by: Pranith Kumar Karampuri