glusterfs.git/xlators/storage, branch v3.1.6qa4

posix: perform readdir filling in locked region

2011-07-16T19:47:22+00:00

When two application threads share an open dir fd (DIR *) and issue
readdirs, storage/posix will receive separate readdir fops in separate
threads in parallel. This has two-fold issues

1. In the following pair of operations -

   entry = readdir(dir)
       and
   strcpy (gf_dirent->name, entry->d_name)

   @entry is a static buffer in libc which can get reused by another thread
   to get filled with a longer name. This can cause the second operation
   to overflow the buffer as the allocation was for the smaller name.

2. In the following pair of operations -

   seekdir (dir, offset)
      and
   entry = readdir(dir)

   If two threads are executing these sequence in parallel in separate
   threads, then one of them will end up reading wrong/unexpected entries.

It would be sufficient to fix 1. by using readdir_r but that still keeps
the second race open. Hence the patch moves all the set of operations to a
locked region which solves both races.

Change-Id: I36e596a96e254d3a82ff5f3669fa67ec72ef0833

Signed-off-by: Anand Avati 

BUG: 3171 (Crash in server)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=3171

storage/posix: detect race in posix_rename()

2011-07-12T09:24:31+00:00

detect a race in rename between two clients by checking for
reassigned gfid or presence of dir when not expecting.

checks not necessary for rename of files.

Signed-off-by: Anand Avati 

BUG: 2522 ([glusterfs-3.1.3qa8]: rm -rf shows invalid argument)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2522

posix: fix GFID assignment race between mkdir and lookup

2011-06-17T15:34:04+00:00

In lookup, treat inodes which have recent ctime and no GFID as
though they are still getting created by another thread and
return ENOENT

Signed-off-by: Anand Avati 

BUG: 2994 ([glusterfs-3.2.1qa2]: untar and rm in parallel hangs untar)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2994

posix: Set op_errno to ENOMEM on failed iobuf_get

2011-03-12T05:58:26+00:00

This prevents a situation where op_ret for the read fop is
-1 but the op_errno is still 0.

Signed-off-by: Shehjar Tikoo 
Signed-off-by: Vijay Bellur 

BUG: 1977 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1977

posix: Handle offset greater than file size of EOF determination

2011-03-12T05:58:21+00:00

Signed-off-by: Shehjar Tikoo 
Signed-off-by: Vijay Bellur 

BUG: 1977 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1977

Solaris xattr support for symlink and special files.

2011-03-04T08:41:15+00:00

Since glusterfs uses xattr for storing gfid, and xattr support for
symlinks and special files does not exist in solaris. The work around
is provided by creating hidden files under export directory on solaris
hosts only. the hidden files ares maintained in .glusterfs_xattr_inode directory,
and all xattr ops on symlink and special files are redirected to respective
inodes.

All dir entries with name starting as .glusterfs (GF_HIDDEN_PATH) will
not be shown in readdir ops.

Signed-off-by: shishir gowda 
Signed-off-by: Anand V. Avati 

BUG: 2213 (Symlink fails with ENODATA)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2213

v2 Prevent removal of trusted.gfid xattr

2011-03-01T10:05:35+00:00

Signed-off-by: shishir gowda 
Signed-off-by: Anand V. Avati 

BUG: 2461 (remove xattr of trusted.gfid succeeds)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2461

storage/posix: set op_ret to -1 when setgid_override fails.

2011-02-22T17:21:57+00:00

Signed-off-by: Raghavendra G 
Signed-off-by: Anand V. Avati 

BUG: 2409 (crash in stat prefetch)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2409

storage/posix: in opendir, allocate proper size for fd ctx pointer

2011-01-08T01:43:45+00:00

Signed-off-by: Amar Tumballi 
Signed-off-by: Anand V. Avati 

BUG: 2280 (wrong size allocated for posix_fd in posix.c:posix_opendir())
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2280

gfid: disable setting/getting of gfid from higher level translators

2010-12-07T06:19:05+00:00

Signed-off-by: Anand V. Avati 
Signed-off-by: Anand V. Avati 

BUG: 2196 ()
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2196