glusterfs.git/xlators/storage, branch v3.3.0qa26

storage/posix: In lookup check for buf->gfid being NULL

2012-02-29T10:09:59+00:00

There are few cases where create and lookup race.
Lookup ends up getting a valid struct iatt, but with no gfid set.
We need to check for gfid being 0, and handle it as an error.

Signed-off-by: shishir gowda 
Change-Id: I36ae1978b325aff964cbc3b24730c1e993666267
BUG: 797167
Reviewed-on: http://review.gluster.com/2832
Tested-by: Gluster Build System 
Reviewed-by: Amar Tumballi 
Reviewed-by: Vijay Bellur

glusterfsd: unref the dict and free the memory to avoid memleak

2012-02-27T10:17:34+00:00

Change-Id: Ib7a1f8cbab039fefb73dc35560a035d5688b0e32
BUG: 796186
Signed-off-by: Raghavendra Bhat 
Reviewed-on: http://review.gluster.com/2808
Tested-by: Gluster Build System 
Reviewed-by: Amar Tumballi 
Reviewed-by: Vijay Bellur

Introduce new extended attribute: node-uuid

2012-02-23T07:19:44+00:00

Request for trusted.glusterfs.node-uuid returns pathinfo
like string but containing the UUID of glusterd instead
of the backend path for the requested file. This info
is benificial for tasks like parallel rebalance that will
make use of the UUID for data locality.

Change-Id: I766a09cc4a5f63aebd11c73107924a1b29242dcf
BUG: 772610
Signed-off-by: Venky Shankar 
Reviewed-on: http://review.gluster.com/2614
Tested-by: Gluster Build System 
Reviewed-by: Shishir Gowda 
Reviewed-by: Vijay Bellur

storage/posix: Add xattr for gfid2path

2012-02-20T18:05:38+00:00

Change-Id: I1fe987d255bf50e8433043749b482b67554a0ac3
BUG: 763820
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.com/2774
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

glusterd: auth allow enhancements

2012-02-20T08:30:54+00:00

* PROBLEM:

  When address-based authentication is enabled on a volume,
  the gNfs server, self-heal daemon (shd), and other operations
  such as quota, rebalance, replace-brick and geo-replication
  either stop working or the services are not started if all
  the peers' ipv{4,6} addresses or hostnames are not added in
  the "set auth.allow" operation, breaking the functionality
  of several operations.

  E.g:
    volume vol in a cluster of two peers:
    /mnt/brick1 in 192.168.1.4
    /mnt/brick2 in 192.168.1.5

    option auth.allow 192.168.1.6
    (allow connection requests only from 192.168.1.6)

    This will disrupt the nfs servers on 192.168.1.{4,5}.
    brick server processes reject connection requests from both
    nfs servers (on 4,5), because the peer addresses are not in
    the auth.allow list.

    Same holds true for local mounts (on peer machines),
    self-heal daemon, and other operations which perform
    a glusterfs mount on one of the peers.

* SOLUTION:

  Login-based authentication (username/password pairs,
  henceforth referred to as "keys") for gluster services and
  operations.

  These *per-volume* keys can be used to by-pass the addr-based
  authentication, provided none of the peers' addresses are put
  in the auth.reject list, to enable gluster services like gNfs,
  self-heal daemon and internal operations on volumes when
  auth.allow option is exercised.

* IMPLEMENTATION:

  1. Glusterd generates keys for each volume and stores it in
     memory as well as in respective volfiles.
     A new TRUSTED-FUSE volfile is generated which is
     fuse volfile + keys in protocol/client,
     and is named trusted--fuse.vol.
     This is used by all local mounts. ANY local mount (on any peer)
     is granted the trusted-fuse volfile instead of fuse volfile
     via getspec. non-local mounts are NOT granted the trusted fuse
     volfile.

  2. The keys generated for the volume is written to each server
     volfile telling servers to allow users with these keys.

  3. NFS, self-heal daemon and replace-brick volfiles are updated
     with the volume's authentication keys.

  4. The keys are NOT written to fuse volfiles for obvious reasons.

  5. The ownership of volfiles and logfiles is restricted to root users.

  6. Merging two identical definitions of peer_info_t in auth/addr
     and rpc-lib, throwing away the one in auth/addr.

  7. Code cleanup in numerous places as appropriate.

* IMPORTANT NOTES:

  1. One SHOULD NOT put any of the peer addresses in the auth.reject
     list if one wants any of the glusterd services and features
     such as gNfs, self-heal, rebalance, geo-rep and quota.

  2. If one wants to use username/password based authentication
     to volumes, one shall append to the server, nfs and shd volfiles,
     the keys one wants to use for authentication, *while_retaining
     those_generated_by_glusterd*.
     See doc/authentication.txt file for details.

Change-Id: Ie0331d625ad000d63090e2d622fe1728fbfcc453
BUG: 789942
Signed-off-by: Rajesh Amaravathi 
Reviewed-on: http://review.gluster.com/2733
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

cluster/dht: Support for hardlink rebalance when decommissioning

2012-02-19T12:47:50+00:00

The support for hardlink rebalance is only available for decommissioning
of a node. this can be triggered in two ways
1. remove-brick start
2. if decommission node value is set in vol file, then a normal rebalance
   command

The way we handle it is-
if (nlink > 1)
do
       * if src file doesnt have linkto xattr
                * mark src's linkto to the dst
       * else
                * perform a link on the dst
                * do a look up
                * if nlinks = dst.nlinks
                        * migrate data
                * else
                        * continue crawling
done
Signed-off-by: shishir gowda 
Change-Id: If43b5524b872fd1413e9f7aa7f436cb244e30d8d
BUG: 763844
Reviewed-on: http://review.gluster.com/2737
Tested-by: Gluster Build System 
Reviewed-by: Amar Tumballi

posix: handle some internal behavior in posix_mknod()

2012-02-17T06:48:57+00:00

assume a case of link() systemcall, which is handled in distribute by
creating a 'linkfile' in hashed subvolume, if the 'oldloc' is present
in different subvolume. we have same 'gfid' for the linkfile as that
of file for consistency. Now, a file with multiple hardlinks, we may
end up with 'hardlinked' linkfiles. dht create linkfile using 'mknod()'
fop, and as now posix_mknod() is not equipped to handle this situation.

this patch fixes the situation by looking at the 'internal' key set in
the dictionary to differentiate the call which originates from inside
with regular system calls.

Change-Id: Ibff7c31f8e0c8bdae035c705c93a295f080ff985
BUG: 763844
Signed-off-by: Amar Tumballi 
Reviewed-on: http://review.gluster.com/2755
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

storage/posix: reset op_ret to -1 after call to MAKE_INODE_HANDLE

2012-02-17T05:56:30+00:00

MAKE_INODE_HANDLE uses op_ret. We do not reset it to -1, and in few
instances we jump to label out, where we unwind with op_ret.

Change-Id: Iac4d9f250f5253b3ce0cd91cc385168247efd4a8
BUG: 788998
Signed-off-by: shishir gowda 
Reviewed-on: http://review.gluster.com/2759
Tested-by: Gluster Build System 
Reviewed-by: Amar Tumballi

core: add an extra flag to readv()/writev() API

2012-02-14T09:09:02+00:00

needed to implement a proper handling of open flag alterations
using fcntl() on fd.

Change-Id: Ic280d5db6f1dc0418d5c439abb8db1d3ac21ced0
Signed-off-by: Amar Tumballi 
BUG: 782265
Reviewed-on: http://review.gluster.com/2723
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

storage/posix: Fix rename gfid handle unset

2012-01-30T07:31:17+00:00

Change-Id: I365ef264056691914ad5bd620d8150f8b71ec887
BUG: 785524
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.com/2698
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati