glusterfs.git/xlators/system/posix-acl/src/posix-acl.c, branch v5.1

Land part 2 of clang-format changes

2018-09-12T12:22:45+00:00

Change-Id: Ia84cc24c8924e6d22d02ac15f611c10e26db99b4
Signed-off-by: Nigel Babu

posix-acl: skip acl_permits check when the owner setting GF_POSIX_ACL_xxxx

2018-08-27T03:26:02+00:00

Change-Id: Iaeea470d040587027f37e0760ae27c4fc205a189
fixes: bz#1613098
Signed-off-by: Kinglong Mee

features/acl: Fix a possible null dereference

2018-08-17T03:04:09+00:00

Addresses CID 1370952

Change-Id: I1f157dbede32e74e38aed8a1a162e38107f2628d
updates: bz#789278
Signed-off-by: Vijay Bellur

glusterfsd: Memleak in glusterfsd process while brick mux is on

2018-02-27T07:11:15+00:00

Problem: At the time of stopping the volume while brick multiplex is
         enabled memory is not cleanup from all server side xlators.

Solution: To cleanup memory for all server side xlators call fini
          in glusterfs_handle_terminate after send GF_EVENT_CLEANUP
          notification to top xlator.

BUG: 1544090
Signed-off-by: Mohit Agrawal 

Note: Run all test-cases in separate build (https://review.gluster.org/19574)
      with same patch after enable brick mux forcefully, all test cases are
      passed.

Change-Id: Ia10dc7f2605aa50f2b90b3fe4eb380ba9299e2fc

posix-acl: Whitelist virtual ACL xattrs

2017-06-09T11:10:01+00:00

Similar to system.posix_acl_* xattrs, all users should get
permission to be able to read glusterfs.posix.acl* xattrs too.

Change-Id: I1fc2b67c8a12113910e4ec57cd114e4baefe0d38
BUG: 1459971
Signed-off-by: Soumya Koduri 
Reviewed-on: https://review.gluster.org/17493
Smoke: Gluster Build System 
Reviewed-by: jiffin tony Thottan 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Raghavendra Talur 
Reviewed-by: Niels de Vos

Remove unused conditionnal

2017-02-26T16:30:38+00:00

The code is using a got to jump 1 line further, which is
a no-op. Found by coverty scan

Change-Id: Ic8698e2f86ebd9472b3104b09920ab7946c3b4fc
BUG: 789278
Signed-off-by: Michael Scherer 
Reviewed-on: https://review.gluster.org/16714
Smoke: Gluster Build System 
Reviewed-by: Shyamsundar Ranganathan 
Tested-by: Michael Scherer 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System

access_control : address O_TRUNC and O_APPEND flag properly in posix_acl_open

2016-12-14T13:01:07+00:00

In posix_acl_open, in switch value passed is (flag & O_ACCMODE). The value for
O_ACCMODE is 0003, so the result will always be less than or equal to 3.
But value for O_TRUNC is 01000 and O_APPEND is 02000, so it is not right to
check it in switch case

Change-Id: Ia17db80a6a5f681c35e08e062d384f33ef7e0354
BUG: 1387241
Signed-off-by: Jiffin Tony Thottan 
Reviewed-on: http://review.gluster.org/15688
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Niels de Vos 
Reviewed-by: Kaleb KEITHLEY

system/posix-acl: Log reason for EACCES

2016-11-17T09:56:14+00:00

It is becoming increasingly difficult to debug the reason why posix-acl decides
to fail a fop with EACCES. This patch prints a big log everytime such
a condition occurs giving out the details that may help in finding why the fop
is errored out.

Change-Id: I2505baaafb5d77ef6c187554ff027df9b20468db
BUG: 1394548
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/15837
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Raghavendra Talur

posix-acl: check dictionary before using it

2016-11-04T07:38:19+00:00

If extended attributes are not present in md-cache it returns NULL as xattr.
posix acl xlator should check for NULL before using xattr.

If normal and default ACLs are not set on file then md-cache will not contain
system.posix_acl_access and system.posix_acl_default extended attributes in
its cache.

Therefore posix_acl_lookup_cbk should check xattr before using it, otherwise
the logs will get filled with dictionary errors.

Change-Id: Icebf73cf0b313bd3e82ca8cbda63786dd0fa47da
BUG: 1391387
Signed-off-by: Rajesh Joseph 
Reviewed-on: http://review.gluster.org/15769
Reviewed-by: Raghavendra Talur 
Smoke: Gluster Build System 
Reviewed-by: jiffin tony Thottan 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Vijay Bellur 
CentOS-regression: Gluster Build System

system/posix-acl: Unwind with NULL xdata on error

2016-09-13T08:05:04+00:00

In posix-acl when there are errors xdata that comes as part of input is used to
unwind which can be used as response xdata which may lead to problems as the
keys in the input will match with keys in the output but the values the
response xdata may expect can be completely different.

For example, we see that dht sends DHT_IATT_IN_XDATA_KEY in setxattr
which will be unwound with the same key in the xdata-response which
dht thinks is valid response and fills stbuf with invalid values
leading to EIO

BUG: 1374093
Change-Id: I6b77a1fa1ee99cb62e181e1db2e6fea73f6eaaa3
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/15421
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: jiffin tony Thottan 
Reviewed-by: Niels de Vos