glusterfs.git/xlators, branch v3.10.3

tier: port value missing on cli parsing

2017-05-31T17:51:32+00:00

problem: as tier didn't have a port all the values regarding
the port were removed. but the cli needs a port value to parse and
print the status.

fix: fake the port value with a zero.

>Change-Id: I6491f6c441f7cfddbdaa724fcbe7c30e348aa765
>BUG: 1452006
>Signed-off-by: hari gowtham 
>Reviewed-on: https://review.gluster.org/17419
>Smoke: Gluster Build System 
>Tested-by: hari gowtham 
>Reviewed-by: Shyamsundar Ranganathan 
>Reviewed-by: Prashanth Pai 
>CentOS-regression: Gluster Build System 
>Reviewed-by: Samikshan Bairagya 
>NetBSD-regression: NetBSD Build System 
>Reviewed-by: Atin Mukherjee 

Signed-off-by: hari gowtham 
Change-Id: I6491f6c441f7cfddbdaa724fcbe7c30e348aa765
BUG: 1456682
Reviewed-on: https://review.gluster.org/17427
Smoke: Gluster Build System 
Tested-by: hari gowtham 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Raghavendra Talur 
CentOS-regression: Gluster Build System

glusterd: Eliminate race in brick compatibility checking stage

2017-05-31T15:06:58+00:00

In https://review.gluster.org/17307/, while looking for compatible
bricks for multiplexing, it is checked if the brick pidfile exists
before checking if the corresponding brick process is running.

However checking if the brick process is running just after
checking if the pidfile exists isn't enough since there might be
race conditions where the pidfile has been created but hasn't
been updated with a pid value yet. This commit solves that by
making sure that we wait iteratively till the pid value is updated
as well.

> Reviewed-on: https://review.gluster.org/17375
> Smoke: Gluster Build System 
> Reviewed-by: Atin Mukherjee 
> NetBSD-regression: NetBSD Build System 
> CentOS-regression: Gluster Build System 

(cherry picked from commit a8624b8b13a1f4222e4d3e33fa5836d7b45369bc)

Change-Id: Ib7a158f95566486f7c1f84b6357c9b89e4c797ae
BUG: 1453087
Signed-off-by: Samikshan Bairagya 
Reviewed-on: https://review.gluster.org/17425
NetBSD-regression: NetBSD Build System 
Tested-by: Raghavendra Talur 
CentOS-regression: Gluster Build System 
Smoke: Gluster Build System 
Reviewed-by: Raghavendra Talur

perf/ioc: Fix race causing crash when accessing freed page

2017-05-31T08:05:17+00:00

ioc_inode_wakeup does not lock the ioc_inode for the duration
of the operation, leaving a window where ioc_prune could find
a NULL waitq and hence free the page which ioc_inode_wakeup later
tries to access.

Thanks to Mohit for the analysis.

credit: moagrawa@redhat.com

> BUG: 1456385
> Signed-off-by: N Balachandran 
> Reviewed-on: https://review.gluster.org/17410
> Reviewed-by: Raghavendra G 
> Tested-by: Raghavendra G 
> Smoke: Gluster Build System 
> NetBSD-regression: NetBSD Build System 
> CentOS-regression: Gluster Build System 
> Reviewed-by: Jeff Darcy 
Change-Id: I54b064857e2694826d0c03b23f8014e3984a3330
BUG: 1457054
Signed-off-by: N Balachandran 
Reviewed-on: https://review.gluster.org/17423
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Raghavendra Talur 
CentOS-regression: Gluster Build System

Tier: removing port allocated for tier

2017-05-31T06:00:16+00:00

Problem: Tier has a port which it doesn't use.

Fix: Remove the port getting allocated for tier.

>Change-Id: If0fe393fc335d9f622a063787e0a3c6db9b7a50c
>BUG: 1452006
>Signed-off-by: hari gowtham 
>Reviewed-on: https://review.gluster.org/17328
>Tested-by: hari gowtham 
>NetBSD-regression: NetBSD Build System 
>CentOS-regression: Gluster Build System 
>Smoke: Gluster Build System 
>Reviewed-by: Shyamsundar Ranganathan 

Change-Id: If0fe393fc335d9f622a063787e0a3c6db9b7a50c
BUG: 1456682
Signed-off-by: hari gowtham 
Reviewed-on: https://review.gluster.org/17420
Smoke: Gluster Build System 
Tested-by: hari gowtham 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Raghavendra Talur

Fixes upgrade issue in quota.conf

2017-05-31T05:58:24+00:00

When an op-version bump up is done the glusterd_store_quota_config
upgrades the quota conf file, although overwriting the same later
which leaves out all gfid entries. While this is warranted for
enable opcode, for upgrade we need to retain gfids. So for upgrade
opcode, we return once the upgrade is done.

> Reviewed-on: http://review.gluster.org/16425
> Smoke: Gluster Build System 
> NetBSD-regression: NetBSD Build System 
> CentOS-regression: Gluster Build System 
> Reviewed-by: Atin Mukherjee 
> (cherry picked from commit 89cf743118ab6554c7f210754e51c4921cbb60c7)

Change-Id: I2b38c6022d74b4a14dc07432651a51cc39ad5120
BUG: 1450773
Signed-off-by: Sanoj Unnikrishnan 
Reviewed-on: https://review.gluster.org/17292
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Raghavendra Talur

glusterd: Don't spawn new glusterfsds on node reboot with brick-mux

2017-05-30T13:36:40+00:00

With brick multiplexing enabled, upon a node reboot new bricks were
not being attached to the first spawned brick process even though
there wasn't any compatibility issues.

The reason for this is that upon glusterd restart after a node
reboot, since brick services aren't running, glusterd starts the
bricks in a "no-wait" mode. So after a brick process is spawned for
the first brick, there isn't enough time for the corresponding pid
file to get populated with a value before the compatibilty check is
made for the next brick.

This commit solves this by iteratively waiting for the pidfile to be
populated in the brick compatibility comparison stage before checking
if the brick process is alive.

> Reviewed-on: https://review.gluster.org/17307
> Reviewed-by: Atin Mukherjee 
> Smoke: Gluster Build System 
> NetBSD-regression: NetBSD Build System 
> CentOS-regression: Gluster Build System 

(cherry picked from commit 13e7b3b354a252ad4065f7b2f0f805c40a3c5d18)

Change-Id: Ibd1f8e54c63e4bb04162143c9d70f09918a44aa4
BUG: 1453087
Signed-off-by: Samikshan Bairagya 
Reviewed-on: https://review.gluster.org/17352
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Atin Mukherjee 
Reviewed-by: Raghavendra Talur

glusterd: ignore incorrect uuid validation if uuid_str is empty

2017-05-30T13:35:38+00:00

If uuid_str is not filled up in dictionary (when glusterd bit is old),
we shouldn't be additional validation with peer uuid otherwise the
handshake request will fail.

Refer :
http://lists.gluster.org/pipermail/gluster-users/2017-May/031187.html
Credits : pawan@platform.sh

>Reviewed-on: https://review.gluster.org/17358
>Smoke: Gluster Build System 
>NetBSD-regression: NetBSD Build System 
>CentOS-regression: Gluster Build System 
>Reviewed-by: Amar Tumballi 
>Reviewed-by: Prashanth Pai 
>(cherry picked from commit b1fbc695a63801a3a2c62738fd6660388123724a)

Change-Id: I2c30bf0490c31d1418b31d555e7758696e79409f
BUG: 1455182
Signed-off-by: Atin Mukherjee 
Reviewed-on: https://review.gluster.org/17386
Smoke: Gluster Build System 
Reviewed-by: Prashanth Pai 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Raghavendra Talur

cluster/afr: Return the list of node_uuids for the subvolume

2017-05-30T13:13:27+00:00

Problem:
AFR was returning the node uuid of the first node for every file if
the replica set was healthy, which was resulting in only one node
migrating all the files.

Fix:
With this patch AFR returns the list of node_uuids to the upper layer,
so that they can decide on which node to migrate which files, resulting
in improved performance. Ordering of node uuids will be maintained based
on the ordering of the bricks. If a brick is down, then the node uuid
for that will be set to all zeros.

> Reviewed-on: https://review.gluster.org/17084
> Reviewed-by: Pranith Kumar Karampuri 
> Tested-by: Pranith Kumar Karampuri 
> Smoke: Gluster Build System 
> NetBSD-regression: NetBSD Build System 
> CentOS-regression: Gluster Build System 
(cherry picked from commit 0a50167c0a8f950f5a1c76442b6c9abea466200d)

Change-Id: I73ee0f9898ae473584fdf487a2980d7a6db22f31
BUG: 1451561
Signed-off-by: karthik-us 
Reviewed-on: https://review.gluster.org/17337
Tested-by: Ravishankar N 
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Raghavendra Talur

cluster/dht: Fix crash in dht_selfheal_dir_setattr

2017-05-29T08:51:53+00:00

Use a local variable to store the call cnt used in the
for loop for the STACK_WIND so as not to access local
which may be freed by STACK_UNWIND after all fops return.

> BUG: 1452102
> Signed-off-by: N Balachandran 
> Reviewed-on: https://review.gluster.org/17343
> Smoke: Gluster Build System 
> NetBSD-regression: NetBSD Build System 
> Reviewed-by: Shyamsundar Ranganathan 
> CentOS-regression: Gluster Build System 
(cherry picked from commit 17784aaa311494e4538c616f02bf95477ae781bc)
Change-Id: I24f49b6dbd29a2b706e388e2f6d5196c0f80afc5
BUG: 1453056
Signed-off-by: N Balachandran 
Reviewed-on: https://review.gluster.org/17349
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Shyamsundar Ranganathan

afr: propagate correct errno for fop failures in arbiter

2017-05-18T08:08:18+00:00

Problem:
If quorum is not met in fop cbk, arbiter sends an ENOTCONN error to the
upper xlators. In a VM workload with sharding enabled, this was leading
to the VM pausing when replace-brick was performed as described in the BZ.

Fix:
Move the fop cbk arbitration logic to afr_handle_quorum() because in
normal replica volumes, that is the function that has the quorum and
errno checks in the fop cbk path before doing a post-op.

Thanks to Pranith for suggesting this approach.

> Reviewed-on: https://review.gluster.org/17235
> Smoke: Gluster Build System 
> Reviewed-by: Pranith Kumar Karampuri 
> NetBSD-regression: NetBSD Build System 
> CentOS-regression: Gluster Build System 
(cherry picked from commit 93c850dd2a513fab75408df9634ad3c970a0e859)

Change-Id: Ie6315db30c5e36326b71b90a01da824109e86796
BUG: 1450934
Signed-off-by: Ravishankar N 
Reviewed-on: https://review.gluster.org/17295
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Pranith Kumar Karampuri 
Reviewed-by: Raghavendra Talur