glusterfs.git/xlators, branch v3.2.6qa6

geo-rep / gsyncd: fix cleanup of temporary mounts

2012-03-09T14:14:22+00:00

The "finally" clause that was meant to cleanup after the
temp mount has not covered the case of getting signalled
(eg. by monitor, upon worker timing out).

So here we "outsource" the cleanup to an ephemeral child process.
Child calls setsid(2) so it won't be bothered by internal process
management. We use a pipe in between worker and the cleanup child;
when child sees the worker end getting closed, it performs the cleanup.
Worker end can get closed either because worker closes it (normal case),
or because worker has terminated (faulty case) -- thus as bonus, we get
a nice uniform handling with no need to differentiate between normal and
faulty cases.

The faulty case that was seen IRL -- ie., users of maintainance mounts
hang in chdir(2) to mount point -- can be simulated for testing purposes
by applying the following patch:

diff --git a/xlators/mount/fuse/src/fuse-bridge.c b/xlators/mount/fuse/src/fuse-bridge.c
index acd3c68..1ce5dc1 100644
--- a/xlators/mount/fuse/src/fuse-bridge.c
+++ b/xlators/mount/fuse/src/fuse-bridge.c
@@ -2918,7 +2918,7 @@ fuse_init (xlator_t *this, fuse_in_header_t *finh, void *msg)
         if (fini->minor < 9)
                 *priv->msg0_len_p = sizeof(*finh) + FUSE_COMPAT_WRITE_IN_SIZE;
 #endif
-        ret = send_fuse_obj (this, finh, &fino);
+        ret = priv->client_pid_set ? 0 : send_fuse_obj (this, finh, &fino);
         if (ret == 0)
                 gf_log ("glusterfs-fuse", GF_LOG_INFO,
                         "FUSE inited with protocol versions:"

Change-Id: I1172bf16ac1006bad48958655572155820e5138d
BUG: 786291
Signed-off-by: Csaba Henk 
Reviewed-on: http://review.gluster.com/2908
Tested-by: Gluster Build System 
Reviewed-by: Venky Shankar 
Reviewed-by: Vijay Bellur

gsyncd: geo-rep: Reduce excessive verbosity in logging

2012-03-06T17:46:21+00:00

Backport logging enhancement from master. This patch
reduces per-second logging to per-minute logging during
crawl

Change-Id: Ie51207e6dd8a0257e59f90239cc6960803673223
BUG: 789078
Signed-off-by: Venky Shankar 
Reviewed-on: http://review.gluster.com/2879
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

xlator/lib: Drain out sent requests to avoid multiple STACK_UNWINDs

2012-03-06T13:09:35+00:00

Change-Id: Id48c468934ac64ec52e279ded8949c2a7a760598
BUG: 789078
Signed-off-by: Vijay Bellur 
Reviewed-on: http://review.gluster.com/2871
Tested-by: Gluster Build System 
Reviewed-by: Venky Shankar

Refactor xlator/lib for better readability & maintainability.

2012-03-03T07:40:32+00:00

Change-Id: I26532f1bf7cab58b5870a6117f2a62288ee1f23d
BUG: 789078
Signed-off-by: Vijay Bellur 
Reviewed-on: http://review.gluster.com/2859
Reviewed-by: Pranith Kumar Karampuri 
Tested-by: Gluster Build System

geo-rep / syncdaemon: make the timeout for establishing the connection to slave configurable

2012-03-01T17:28:20+00:00

It can be set through the connection-timeout tunable but we keep it hidden,
intended as a workaround for some special scenarios not for general use.

Change-Id: I31f9fa3873afa7babc2106ee34484123a01bdc57
BUG: 789078
Signed-off-by: Csaba Henk 
Reviewed-on: http://review.gluster.com/2840
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

protocol/client: writev(): don't unwind if rpc_submit failed

2012-02-20T08:48:44+00:00

because rpc_submit does call 'cbk()' from inside if sending fails.
no need to unwind in higher layers

Change-Id: I08611ce742fba7032f68e3fe0f52a78a18a5714e
Signed-off-by: Amar Tumballi 
BUG: 767359
Reviewed-on: http://review.gluster.com/2770
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

nfs/server: Add counters for hard resolution

2012-02-14T10:58:15+00:00

Change-Id: Id7b26731b750b63d645222dde18cd9fe4ed54018
BUG: 785314
Signed-off-by: Vijay Bellur 
Reviewed-on: http://review.gluster.com/2745
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

support for nano second resolution for mtime,ctime,atime attributes.

2012-02-09T06:51:40+00:00

Change-Id: Id5078f270d0fec280b53d4aa7b16bbaf42a2df05
BUG: 784095
Signed-off-by: krishna 
Reviewed-on: http://review.gluster.com/2729
Reviewed-by: Anand Avati 
Tested-by: Gluster Build System

Fixes bug-765574, failure to build from hardened source

2012-01-26T10:19:30+00:00

Glusterfs 3.2.5 failed to build on Debian which prevented the
Debian project from updating their package to the latest release
version.

There were two changes needed, in both cases just adding a
printf format string argument to a call to gf_log.

The compiler error was that the argument was neither a string
literal nor a format string.  It was instead a pointer to a string.
The obvious solution was to add a format argument of "%s" before
the string pointer argument.

This has been tested successfully on Debian Sid.

Change-Id: I62c8a46938184c8a37224c2481bd1de00369ab19
Signed-off-by: louis zuckerman 
Reviewed-on: http://review.gluster.com/2598
Tested-by: Gluster Build System 
Reviewed-by: Kaleb KEITHLEY 
Reviewed-by: Amar Tumballi

mgmt/glusterd: do not assert if op_ctx is NULL

2012-01-24T16:37:03+00:00

In glusterd_op_send_cli_response we are asserting if op_ctx is NULL.
But in handler functions of different ops, we are sending op_ctx NULL
which is valid, but still glusterd will assert.

Change-Id: I37824c694d14e87a234389d639dfb000592f9513
BUG: 783913
Signed-off-by: Raghavendra Bhat 
Reviewed-on: http://review.gluster.com/2678
Tested-by: Gluster Build System 
Reviewed-by: Krishnan Parthasarathi 
Reviewed-by: Anand Avati