glusterfs.git/xlators, branch v3.4.0alpha

fuse(efence): zero sized memory was being allocated.

2013-02-06T03:58:02+00:00

For the last call of getdents(), gf_malloc called with 0 size, which is then
caught by efence.

BUG: 782760
Change-Id: If289029117a62ecfcecc70480e5ac8f0e050487d
Signed-off-by: Anand Avati 
Original-author: Varun Shastry 
Reviewed-on: http://review.gluster.org/3846
Tested-by: Gluster Build System 
Reviewed-by: Amar Tumballi

protocol/client: Avoid double free of frame

2013-02-05T06:11:51+00:00

When client_submit_request fails it calls cbk. The cleanups should
happen only in cbk. The code committed as part of
http://review.gluster.org/4357 violates this. Also found that
clnt_release_reopen_fd violates this as well.
This patch fixes these issue.

Change-Id: Ic02ba278724b03c65c00b686c39fd7846122618a
BUG: 821056
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/4464
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

glusterd: remove extra call to glusterd_volume_compute_cksum()

2013-02-05T03:23:00+00:00

In the commit phase of volume create, checksum on volinfo is
computed twice - once in the call to glusterd_store_volinfo() and once,
further down, in the same function glusterd_op_create_volume().

Change-Id: I36f9426943cd48937d4946b4b4ef09f19f31d888
BUG: 812356
Signed-off-by: Krutika Dhananjay 
Reviewed-on: http://review.gluster.org/4463
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

glusterd: log changes in volume create and delete codepath

2013-02-05T03:21:59+00:00

Making log changes involving two commands as they both share sections
of code (like the part where the volume metadata is cleaned up in vol
delete in case of success; and in vol create in case of failure).

* Most of the changes are of the 's/THIS/this' kind.

* Changed some of the log messages to give as much information as
  available in case of failure.

* Changed log levels in some of the log messages.

Change-Id: I10242511fe9400a07ab04717464d748d9172dd85
BUG: 812356
Signed-off-by: Krutika Dhananjay 
Reviewed-on: http://review.gluster.org/4462
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

glusterd: "volume heal info" doesn't report output properly

2013-02-05T01:41:16+00:00

Problem: "volume heal info" doesn't reports files to be healed when gluster*
         processes on one of the storage node is not running

Change-Id: Iff7d41407014624e4da9b70d710039ac14b48291
BUG: 880898
Signed-off-by: Venkatesh Somyajulu 
Reviewed-on: http://review.gluster.org/4371
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

geo-rep / gsyncd: Separate log file directory for Mountbroker sessions

2013-02-05T01:34:56+00:00

... so that a mountbroker session which is initiated b/w master
and slave does not use the same log file if it's started after
a normal geo-rep session b/w master and slave. This results in
EPERM as the log file is owned by root and the geo-rep slave
process (now running as a non privileged user) does not have
access to it.

Also, having separate log file directory for mountbroker sessions
looks clean.

NOTE: geo-rep's client mount log file location remains unchanged.

Change-Id: Ic7a732e250aee5393b9c3f6ebf6dfe2c310b7fe4
BUG: 893960
Signed-off-by: Venky Shankar 
Reviewed-on: http://review.gluster.org/4407
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

glusterd: Indexed node information in dict to retain consistency.

2013-02-04T22:24:55+00:00

Problem:
--------
Depending on the response time from different nodes, the response
dict for rebalance status was populated in  a FIFO manner, and
hence the output for the CLI was never consistent.

Fix:
----
Irrespective of the response time of the nodes, we now index the
entries in the response dict for rebalance status, in reference
to the peerlist. So, the order of the entries and hence the CLI
output is always consistent.

Change-Id: Ica7e89e5d95aa9860a6f3c7eff58ca2052e05bd6
BUG: 888390
Signed-off-by: Avra Sengupta 
Reviewed-on: http://review.gluster.org/4416
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

cluster/dht: Correct min_free_disk behaviour

2013-02-04T16:43:50+00:00

Problem:
Files were being created in subvol which had less than
min_free_disk available even in the cases where other
subvols with more space were available.

Solution:
Changed the logic to look for subvol which has more
space available.
In cases where all the subvols have lesser than
Min_free_disk available , the one with max space and
atleast one inode is available.

Known Issue: Cannot ensure that first file that is
created right after min-free-value is crossed on a
brick will get created in other brick because disk
usage stat takes some time to update in glusterprocess.
Will fix that as part of another bug.

Change-Id: If3ae0bf5a44f8739ce35b3ee3f191009ddd44455
BUG: 858488
Signed-off-by: Raghavendra Talur 
Reviewed-on: http://review.gluster.org/4420
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

cluster/stripe: Mount issues with Stripe xlator

2013-02-03T23:29:59+00:00

Problem:
* 'CONNECTING' is taken as CHILD_UP.
* Sending notifications (default_notify()) for all the events individually
   while mounting.

Solution:
* Consider Child up only after the event CHILD_UP is received.
* Send a single notification for all the children's events only
   while mounting.

Change-Id: I1b7de127e12f5bfb8f80702dbdce02019e138bc8
BUG: 885072
Signed-off-by: Varun Shastry 
Reviewed-on: http://review.gluster.org/4356
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

protocol/server: upon server_connection_put, set xl_private of the transport to

2013-02-03T22:10:02+00:00

 NULL

 Suppose the get_xlator_by_name returns NULL and the connection is put back
 then update the xl_private of the transport by setting to NULL. Otherwise
 server_connection_put would have freed the connection object and xl_private
 of the transport would still be pointing to the same location which is
 freed, thus leading to a segfault when the location is accessed.

Change-Id: Id47e0edde3073b09765338c730847ba3095df9e2
BUG: 901457
Signed-off-by: Raghavendra Bhat 
Reviewed-on: http://review.gluster.org/4411
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati