glusterfs.git/xlators, branch v3.5qa2

features/quota: Add the quota config xattr to newly added brick

2013-11-26T19:57:11+00:00

Issue:
Quota directory limit configuration is stored in the xattrs. When a new brick
is added these 'limit-set' xattrs have to be created to the directory in the
new brick. This is done by the dht directory healing when the directory is
created in the new brick. Since 'root' directory is already created DHT doesn't
heal the limit-set xattr root.

Solution:
When the add-brick command is issued run the below hook script to heal the
'limit-set' xattr. The hook script does the following only if limit is
configured on root.
    1. Create an auxiliary mount.
    2. getxattr 'limit-set' on the root
    3. setxattr the same value on the root
But this script needs the volume to be started to make the auxiliary mount.

To handle the case when the add-brick is issued when the volume was stopped,
symlink is created by the 'master' script to the corresponding location and
these two are by default disabled.

So, a 'master' script is added in the add-brick/pre. When add-brick command is
issued, it enables one of the scripts mentioned above based on the condition,
    if volume is started - enable add-brick/post script
    else                 - enable start/post script
After the actual script completes its job, it disables itself.

Note:
The enabling and disabling of the script is based on the glusterd's logic, that
it only runs the scripts which starts its name with 'S'. So,
    Enable     - symlink the file to 'S'*
    Disable    - unlink the symlink.

Change-Id: I2d3947a4d686c54417ec95f530af3bdd3444f4e2
BUG: 969461
Signed-off-by: Varun Shastry 
Reviewed-on: http://review.gluster.org/6104
Reviewed-by: Brian Foster 
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

cli: use proper copy to set node-name

2013-11-26T19:55:46+00:00

Previously node-name is set to point to node-uuid which could cause
memory leak.  This is fixed by having memory copy of node-uuid.

BUG: 1012296
Change-Id: I3b638ec289d5b167c6e752ef1ba41f41efacb9da
Signed-off-by: Bala.FA 
Reviewed-on: http://review.gluster.org/6330
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

posix: do not allow to set/get "trusted.glusterfs.volume-id" xattr

2013-11-26T19:00:18+00:00

Change-Id: I2e9a2264b1fd5ebc1ed0aff30225e89acbd0bcb4
BUG: 1034716
Signed-off-by: Vijaykumar M 
Reviewed-on: http://review.gluster.org/6361
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

cluster/dht: Handle Link-info getxattr failure in rebalance

2013-11-26T18:37:41+00:00

When getxattr fails with errno other than ENODATA fail rebalance
on that file. Log the reason for error.

Change-Id: Ia519870b88e6e6dd464d1c0415411aa999f80bc9
BUG: 1032927
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/6341
Tested-by: Gluster Build System 
Reviewed-by: Shishir Gowda 
Reviewed-by: Shyamsundar Ranganathan 
Reviewed-by: Vijay Bellur

write-behind: handle iobref_merge() error gracefully

2013-11-26T18:32:00+00:00

.. by UNWINDing ENOMEM error, rather than crashing.

Change-Id: Ica2d6399eaf7e381e7ebc41155620559c139c4d3
BUG: 1034398
Signed-off-by: Anand Avati 
Reviewed-on: http://review.gluster.org/6349
Tested-by: Gluster Build System 
Reviewed-by: Amar Tumballi

io-cache: handle iobref_merge() error gracefully

2013-11-26T18:31:48+00:00

.. by UNWINDing ENOMEM, rather than leaving pointer in vector pointing
to stale memory.

Change-Id: I7f3917ac056fae144f845c9d123233e91e278187
BUG: 1034398
Signed-off-by: Anand Avati 
Reviewed-on: http://review.gluster.org/6351
Tested-by: Gluster Build System 
Reviewed-by: Amar Tumballi

read-ahead: handle iobref_merge() error gracefully

2013-11-26T18:31:40+00:00

.. by UNWINDing ENOMEM rather than leaving pointers in vector which
points to unref'ed (or even worse, re-used) iobufs.

Change-Id: I849d8cbe5fc02ee992d4e28b7212c49aad4925c7
BUG: 1034398
Signed-off-by: Anand Avati 
Reviewed-on: http://review.gluster.org/6350
Tested-by: Gluster Build System 
Reviewed-by: Amar Tumballi

cluster/dht: set layout in inode ctx even if linkfile fails

2013-11-26T18:30:33+00:00

Creating linkfile could have failed, but we dont care about linkfile
for setting layout in the inode ctx (could be EEXIST etc.)

So ignore @inode in cbk and pick it up from local->loc.inode

Change-Id: I2952799d7ae0d3441b84b2ca2981afd75d7576e2
BUG: 1032859
Signed-off-by: Anand Avati 
Reviewed-on: http://review.gluster.org/6319
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

core: fix errno for non-existent GFID

2013-11-26T18:29:23+00:00

When clients refer to a GFID which does not exist, the errno to
be returned in ESTALE (and not ENOENT). Even though ENOENT might
look "proper" most of the time, as the application eventually expects
ENOENT even if a parent directory does not exist, not returning
ESTALE results in resolvers (FUSE and GFAPI) to not retry resolution
in uncached mode. This can result in spurious ENOENTs during
concurrent path modification operations.

Change-Id: I7a06ea6d6a191739f2e9c6e333a1969615e05936
BUG: 1032894
Signed-off-by: Anand Avati 
Reviewed-on: http://review.gluster.org/6318
Tested-by: Gluster Build System 
Reviewed-by: Amar Tumballi 
Reviewed-by: Brian Foster 
Reviewed-by: Vijay Bellur

cluster/dht: instruct marker whenever it shouldn't do accounting

2013-11-26T18:27:21+00:00

This is needed for two reasons:

* since dht-linkfiles are internal, they shouldn't be accounted.
* hardlink handling in marker is broken. link/unlink of hardlinks
  present in same directory can break marker accounting. Hence, if src
  and dst are in same directory in case of rename, dht - if it breaks
  rename into link/unlink operations - should instruct marker to not to
  do accounting.

Change-Id: I9c9f7384569f75a2792f6450ee7a5279bf751ae7
BUG: 1022995
Signed-off-by: Raghavendra G 
Reviewed-on: http://review.gluster.org/6203
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati