glusterfs.git/xlators, branch v3.7.0beta1

quick-read: Do a null check before unref

2015-04-29T05:01:37+00:00

Backport of http://review.gluster.org/10206

Commit 4ea5b8d2046b9e0bc7f24cdf1b2e72ab8b462c9e seems to have removed the check
as a part of static analyis fixes but I'm seeing errors in the client log.

---------------------
touch  /mnt/fuse_mnt/zero-byte-file
echo 3 > /proc/sys/vm/drop_caches
cat  /mnt/fuse_mnt/zero-byte-file

mount log:
[2015-04-13 05:52:21.683256] E [iobuf.c:790:iobuf_unref] (-->
/usr/local/lib/libglusterfs.so.0(_gf_log_callingfn+0x232)[0x7feda12c0e24] (-->
/usr/local/lib/libglusterfs.so.0(iobuf_unref+0x56)[0x7feda1304c8e] (-->
/usr/local/lib/glusterfs/3.7dev/xlator/performance/quick-read.so(qr_readv_cached+0x466)[0x7fed95b7e2fc]
(-->
/usr/local/lib/glusterfs/3.7dev/xlator/performance/quick-read.so(qr_readv+0x70)[0x7fed95b7e385]
(-->
/usr/local/lib/libglusterfs.so.0(default_readv_resume+0x270)[0x7feda12d4401]
))))) 0-iobuf: invalid argument: iobuf

---------------------

Change-Id: Ia6b29165cdef8783a716fe1e72d3d13bf0220aae
BUG: 1214168
Signed-off-by: Ravishankar N 
Reviewed-on: http://review.gluster.org/10329
Tested-by: NetBSD Build System
Reviewed-by: Raghavendra Talur 
Tested-by: Raghavendra Talur 
Reviewed-by: Vijay Bellur

tier: relax libgfdb required version number

2015-04-28T17:30:05+00:00

When calling dlopen() for libgfdb, do not specify the library
version number "libgfdb.so.0.0.1", since libtool will not always
create libraries or link with that name with the full 3-digit
version. For instance on NetBSD only up to the 2-digit version is
available and "libgfdb.so.0.0.1" does not exist.

Instead, just specify "libgfdb.so" and rely on smymlinks installed
by libtool to find the relevant library.

Backport of: I074b1009d3622a122fdaeb4b99658bca3277e211

BUG: 1212676
Change-Id: I334cb6be8508051105c393ce4bb350f9df014df5
Signed-off-by: Emmanuel Dreyfus 
Reviewed-on: http://review.gluster.org/10408
Reviewed-by: Dan Lambright 
Tested-by: NetBSD Build System
Tested-by: Gluster Build System

quota: display error when inode-quota cmds executed with cluster ver < 3.7

2015-04-28T17:28:39+00:00

This is a backport of http://review.gluster.org/#/c/10261/

> In a heterogeneous cluster with op_version less than 3.7, inode quotas will
> be accounted on those bricks which has glusterfs version 3.7 and this is
> not available in older version.
> This will have incorrect values displayed when user queries inode count
> from CLI.
>
> This patch will display error when inode-quota commands
> are executed with cluster version less than 3.7
>
> Change-Id: Ia0e6d5635d1d8e7b2e2cfc3daa7b7f9e314a263a
> BUG: 1212253
> Signed-off-by: vmallika 
> Reviewed-on: http://review.gluster.org/10261
> Tested-by: Gluster Build System 
> Reviewed-by: Atin Mukherjee 
> Reviewed-by: Vijay Bellur 

Change-Id: I1ddd605e5b87a248aa85f0eab14c404895751083
BUG: 1215907
Signed-off-by: vmallika 
Reviewed-on: http://review.gluster.org/10415
Tested-by: NetBSD Build System
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

glusterd: Remove direct references to peerinfo in frame cookies

2015-04-28T12:49:05+00:00

RCU protection requires that we don't have  direct references to
protected data structures outside read-critical sections

This change was developed on the git branch at [1]. This commit is a
combination of the following commits on the development branch.
  82ebfdd Remove direct references to peerinfo in frame cookies
  dec4bec Remove incorrect and unneeded code from
          gd_syncop_mgmt_v3_unlock_cbk_fn
  7aced7b Use stack allocated uuid for frame cookie.
  38e4124 Address comments from 10192/2

[1]: https://github.com/kshlm/glusterfs/tree/urcu

Change-Id: Ic50e5fca0be72af5090f4cf318efa55d29075de9
BUG: 1205186
Signed-off-by: Kaushal M 
Reviewed-on: http://review.gluster.org/10399
Reviewed-by: Krishnan Parthasarathi 
Tested-by: Krishnan Parthasarathi

glusterd: incorrect rsp.op_ret handling in volume get in cli

2015-04-28T08:54:19+00:00

Cherry picked from commit 540fc2829bd63a2fa070c68ed105eb23145df406:
> Change-Id: Iabe99c06166578fc90121e7cfdca4a6a3f5328ae
> BUG: 1211132
> Signed-off-by: Atin Mukherjee 
> Reviewed-on: http://review.gluster.org/10229
> Reviewed-by: Niels de Vos 
> Tested-by: Gluster Build System 
> Reviewed-by: Kaushal M 

Change-Id: Iabe99c06166578fc90121e7cfdca4a6a3f5328ae
BUG: 1215547
Signed-off-by: Atin Mukherjee 
Reviewed-on: http://review.gluster.org/10398
Reviewed-by: Niels de Vos 
Tested-by: NetBSD Build System
Tested-by: Gluster Build System

glusterd: initialize snapd svc at volume restore path

2015-04-28T08:53:35+00:00

In restore path snapd svc was not initialized because of which any glusterd
instance which went down and came back may have uninitialized snapd svc. The
reason I used 'may' is because depending on the nodes in the cluster. In a
single node cluster this wouldn't be a problem since glusterd_spawn_daemon takes
care of initializing it.

Backport of http://review.gluster.org/10304

Change-Id: I2da1e419a0506d3b2742c1cf39a3b9416eb3c305
BUG: 1215518
Signed-off-by: Atin Mukherjee 
Reviewed-on: http://review.gluster.org/10304
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System
Reviewed-by: Kaushal M 
(cherry picked from commit 18fd2fdd60839d737ab0ac64f33a444b54bdeee4)
Reviewed-on: http://review.gluster.org/10397
Reviewed-by: Krishnan Parthasarathi

tier: fix off-by-one overrun in UUID string

2015-04-27T12:33:00+00:00

UUID strings are UUID_CANONICAL_FORM_LEN (36) bytes long
plus the trailing nul character that various function (e.g.:
uuid_unparse) will add. As a consequence, UUID strings must
be declared as UUID_CANONICAL_FORM_LEN+1 long, otherwise
we get a off-by-one overrun that corrupts the next variable
on stack.

Backport of: I5837ad6ca06fa17cc7ab143eedd02d8099ecca2a

BUG: 1212676
Change-Id: I27bd223bdd72cda679b7cdc861e09e0f367bd6e4
Signed-off-by: Emmanuel Dreyfus 
Reviewed-on: http://review.gluster.org/10395
Tested-by: Gluster Build System 
Reviewed-by: Dan Lambright

features/trash: Minor coverity fixes

2015-04-27T06:25:28+00:00

        Backport of http://review.gluster.org/10315

CID 1288784
CID 1288785
CID 1288795
CID 1288796
CID 1288797
CID 1288802

Change-Id: I51dd7653a2dce3b7b6387e5d91c1c07eb157a04b
BUG: 1215026
Signed-off-by: Anoop C S 
Tested-by: Gluster Build System 
Tested-by: jiffin tony Thottan 
Reviewed-by: jiffin tony Thottan 
Reviewed-on: http://review.gluster.org/10361
Tested-by: NetBSD Build System

features/shard: Implement unlink fop

2015-04-27T05:08:54+00:00

        Backport of: http://review.gluster.org/10249

Change-Id: I01761721224c4efbbc5e4992e70ecf68b3868d63
BUG: 1214247
Signed-off-by: Krutika Dhananjay 
Reviewed-on: http://review.gluster.org/10377
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System
Reviewed-by: Vijay Bellur

tiering: skip CTR-xlator and config options when disabled

2015-04-26T14:35:34+00:00

When compiling with --disable-tiering, GlusterD should not contain any
references to the ChangeTimeRecorder xlator or any of the data tiering
options.

Cherry picked from commit a675ab96b917fc48fc3d7ca035590ebd7cf102bd:
> BUG: 1213125
> Change-Id: Idb46fb80f0ca8b66115e06841d9ec15ba14c24a0
> Signed-off-by: Niels de Vos 
> Reviewed-on: http://review.gluster.org/10296
> Reviewed-by: Dan Lambright 
> Tested-by: Gluster Build System 

BUG: 1215382
Change-Id: Idb46fb80f0ca8b66115e06841d9ec15ba14c24a0
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/10378
Tested-by: Gluster Build System 
Reviewed-by: Dan Lambright