summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorShehjar Tikoo <shehjart@zresearch.com>2009-03-17 21:59:30 -0700
committerAnand V. Avati <avati@amp.gluster.com>2009-03-18 11:07:07 +0530
commitb9fef00edbe7272d31be0ca22f3b2794918300e0 (patch)
tree70036bb3e14074257d570a9c05451a85d4295d3d
parent2d7f44e39792c71e4f7bb768acffc2f5a76c80e0 (diff)
Add return after STACK_UNWIND
We must add a 'return' after a STACK_UNWIND due to a stub creation failure, because if we dont, we'll end up adding a NULL stub to the worker thread request queue. Signed-off-by: Anand V. Avati <avati@amp.gluster.com>
-rw-r--r--xlators/performance/io-threads/src/io-threads.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/xlators/performance/io-threads/src/io-threads.c b/xlators/performance/io-threads/src/io-threads.c
index 3bebb3185e4..9ace53ba520 100644
--- a/xlators/performance/io-threads/src/io-threads.c
+++ b/xlators/performance/io-threads/src/io-threads.c
@@ -88,6 +88,7 @@ iot_open (call_frame_t *frame,
gf_log (this->name, GF_LOG_ERROR,
"cannot get open call stub");
STACK_UNWIND (frame, -1, ENOMEM, NULL, 0);
+ return 0;
}
iot_schedule ((iot_conf_t *)this->private, loc->inode, stub);
@@ -144,6 +145,7 @@ iot_create (call_frame_t *frame,
gf_log (this->name, GF_LOG_ERROR,
"cannot get create call stub");
STACK_UNWIND (frame, -1, ENOMEM, NULL, 0);
+ return 0;
}
iot_schedule ((iot_conf_t *)this->private, loc->inode, stub);
return 0;