diff options
| author | Saravanakumar Arumugam <sarumuga@redhat.com> | 2015-05-28 11:54:04 +0530 |
|---|---|---|
| committer | Vijay Bellur <vbellur@redhat.com> | 2015-06-11 12:21:56 -0700 |
| commit | 07df9b56fd0eb4abf1ef6a45318519c9d7ae08e3 (patch) | |
| tree | 9170b5cd01387a9f6aa622c7f7660c2e699bdb23 | |
| parent | 53e84fe1eec8770936e7fdfb7246925006566f41 (diff) | |
geo-rep: ignore symlink and harlink errors in geo-rep
Ignore logging in case of symlink and hardlink creation
errors, as these are safe errors with respect to
geo-replication.
Change-Id: I3b863fb03ae23dbea907e4dd9477ff85feecad70
BUG: 1225571
Signed-off-by: Saravanakumar Arumugam <sarumuga@redhat.com>
Reviewed-on: http://review.gluster.org/10957
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Aravinda VK <avishwan@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
| -rw-r--r-- | xlators/protocol/client/src/client-rpc-fops.c | 26 |
1 files changed, 15 insertions, 11 deletions
diff --git a/xlators/protocol/client/src/client-rpc-fops.c b/xlators/protocol/client/src/client-rpc-fops.c index b15c863dee1..54699ba94ac 100644 --- a/xlators/protocol/client/src/client-rpc-fops.c +++ b/xlators/protocol/client/src/client-rpc-fops.c @@ -158,13 +158,15 @@ client3_3_symlink_cbk (struct rpc_req *req, struct iovec *iov, int count, out: if (rsp.op_ret == -1) { - /* no need to print the gfid, because it will be null, since - * symlink operation failed. - */ - gf_log (this->name, GF_LOG_WARNING, - "remote operation failed: %s. Path: (%s to %s)", - strerror (gf_error_to_errno (rsp.op_errno)), - local->loc.path, local->loc2.path); + if (GF_IGNORE_IF_GSYNCD_SAFE_ERROR(frame, rsp.op_errno)) { + /* no need to print the gfid, because it will be null, + * since symlink operation failed. + */ + gf_log (this->name, GF_LOG_WARNING, + "remote operation failed: %s. Path: (%s to %s)", + strerror (gf_error_to_errno (rsp.op_errno)), + local->loc.path, local->loc2.path); + } } CLIENT_STACK_UNWIND (symlink, frame, rsp.op_ret, @@ -2663,10 +2665,12 @@ client3_3_link_cbk (struct rpc_req *req, struct iovec *iov, int count, out: if (rsp.op_ret == -1) { - gf_log (this->name, GF_LOG_WARNING, - "remote operation failed: %s (%s -> %s)", - strerror (gf_error_to_errno (rsp.op_errno)), - local->loc.path, local->loc2.path); + if (GF_IGNORE_IF_GSYNCD_SAFE_ERROR(frame, rsp.op_errno)) { + gf_log (this->name, GF_LOG_WARNING, + "remote operation failed: %s (%s -> %s)", + strerror (gf_error_to_errno (rsp.op_errno)), + local->loc.path, local->loc2.path); + } } CLIENT_STACK_UNWIND (link, frame, rsp.op_ret, |