diff options
author | Raghavendra G <rgowdapp@redhat.com> | 2015-07-06 15:45:45 +0530 |
---|---|---|
committer | Raghavendra G <rgowdapp@redhat.com> | 2015-07-06 08:15:25 -0700 |
commit | 5547db849770ff79a11a8bc1260478c56e4ffa9c (patch) | |
tree | 91733de69c601eb4ccae66a95ce630c163d9df84 | |
parent | c9765bcb1557ab1e921080e7de4f3ebac1e424d5 (diff) |
protocol/server: Add null check to gf_client_put
Change-Id: I8bab3cd7387f89743e15e7569f0bc83a7df3c754
BUG: 1240161
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
Reviewed-on: http://review.gluster.org/11550
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
-rw-r--r-- | libglusterfs/src/client_t.c | 6 | ||||
-rw-r--r-- | xlators/protocol/server/src/server-handshake.c | 2 |
2 files changed, 7 insertions, 1 deletions
diff --git a/libglusterfs/src/client_t.c b/libglusterfs/src/client_t.c index 4f51de9d885..1c291518564 100644 --- a/libglusterfs/src/client_t.c +++ b/libglusterfs/src/client_t.c @@ -288,6 +288,9 @@ gf_client_put (client_t *client, gf_boolean_t *detached) gf_boolean_t unref = _gf_false; int bind_ref; + if (client == NULL) + goto out; + if (detached) *detached = _gf_false; @@ -304,6 +307,9 @@ gf_client_put (client_t *client, gf_boolean_t *detached) *detached = _gf_true; gf_client_unref (client); } + +out: + return; } client_t * diff --git a/xlators/protocol/server/src/server-handshake.c b/xlators/protocol/server/src/server-handshake.c index 7ee12c49076..40cc684e1ba 100644 --- a/xlators/protocol/server/src/server-handshake.c +++ b/xlators/protocol/server/src/server-handshake.c @@ -700,7 +700,7 @@ fail: * list of connections the server is maintaining and might segfault * during statedump when bound_xl of the connection is accessed. */ - if (op_ret && !xl) { + if (op_ret && !xl && (client != NULL)) { /* We would have set the xl_private of the transport to the * @conn. But if we have put the connection i.e shutting down * the connection, then we should set xl_private to NULL as it |