summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAtin Mukherjee <amukherj@redhat.com>2015-03-17 16:47:22 +0530
committerKrishnan Parthasarathi <kparthas@redhat.com>2015-03-23 23:22:40 -0700
commit0940364b453fc37cb3e1844a743cf30c8ab2afc6 (patch)
tree5906477135d05a94048be4394167c84b8bce8c39
parent2308c07b9d52b28f371388b9393b17508b2ddccd (diff)
glusterd: Do not use global opinfo in syncop
Global opinfo should not be referred by syncop framework as it uses local txn_opinfo for every transaction. There is one place in the codebase where the global opinfo is set with the local txn_opinfo which can lead to an incorrect opinfo for an on-going op-sm transaction which refers to the same global opinfo. Change-Id: Ida63a8871b8d03fe646146eddfd3f2473f1b1d7c BUG: 1202745 Signed-off-by: Atin Mukherjee <amukherj@redhat.com> Reviewed-on: http://review.gluster.org/9908 Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Anand Nekkunti <anekkunt@redhat.com> Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com> Tested-by: Krishnan Parthasarathi <kparthas@redhat.com>
-rw-r--r--xlators/mgmt/glusterd/src/glusterd-syncop.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/xlators/mgmt/glusterd/src/glusterd-syncop.c b/xlators/mgmt/glusterd/src/glusterd-syncop.c
index 8e3f7ebc4eb..b12a9443c5c 100644
--- a/xlators/mgmt/glusterd/src/glusterd-syncop.c
+++ b/xlators/mgmt/glusterd/src/glusterd-syncop.c
@@ -1651,8 +1651,6 @@ gd_sync_task_begin (dict_t *op_ctx, rpcsvc_request_t * req)
gf_log (this->name, GF_LOG_DEBUG,
"Transaction ID : %s", uuid_utoa (*txn_id));
- opinfo = txn_opinfo;
-
/* Save the MY_UUID as the originator_uuid */
ret = glusterd_set_originator_uuid (op_ctx);
if (ret) {