diff options
| author | Michael Scherer <misc@redhat.com> | 2017-02-23 23:24:42 +0100 |
|---|---|---|
| committer | Shyamsundar Ranganathan <srangana@redhat.com> | 2017-02-24 09:49:19 -0500 |
| commit | f08f5bfef923259fe6de6d41a0a2b1b9140fc547 (patch) | |
| tree | 40e589b820cd00061347c2b7197fa09b0310520a | |
| parent | 62d3a2c3fc4e09fe8d1cb05f228715eede1a265d (diff) | |
Do not call va_end twice in _gf_log_eh
Since va_end is called after the out label,
we do not need to call it here, as it make va_end undefined,
and thus could cause problem. And this is a error
on cppcheck.
Change-Id: I6e96c796bd37fa3cde989996ab93f9a438c0ee74
BUG: 789278
Signed-off-by: Michael Scherer <misc@redhat.com>
Reviewed-on: https://review.gluster.org/16745
Smoke: Gluster Build System <jenkins@build.gluster.org>
Tested-by: Michael Scherer <misc@fedoraproject.org>
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
CentOS-regression: Gluster Build System <jenkins@build.gluster.org>
Reviewed-by: Shyamsundar Ranganathan <srangana@redhat.com>
| -rw-r--r-- | libglusterfs/src/logging.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/libglusterfs/src/logging.c b/libglusterfs/src/logging.c index 55cf2e97d2c..a8e7b96a24c 100644 --- a/libglusterfs/src/logging.c +++ b/libglusterfs/src/logging.c @@ -2292,8 +2292,6 @@ _gf_log_eh (const char *function, const char *fmt, ...) goto out; } - va_end (ap); - msg = GF_MALLOC (strlen (str1) + strlen (str2) + 1, gf_common_mt_char); if (!msg) { ret = -1; |