diff options
| author | Raghavendra Bhat <raghavendrabhat@gluster.com> | 2011-01-17 00:44:39 +0000 |
|---|---|---|
| committer | Anand V. Avati <avati@dev.gluster.com> | 2011-01-27 12:17:43 -0800 |
| commit | 0e651882a9aadcb35ea764ea65c05c3661175e00 (patch) | |
| tree | a90d339eb604d63622a183d8185c1d833bde3aa7 | |
| parent | bd8f7b95972abdbaba0b4ec067b6cb7968ad7e56 (diff) | |
remove op_errstr from glusterd_handle_rpc_msg as op_errstr is not used in that function
Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 1598 ([glusterfs-3.1.0qa22]: crash in glusterd)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1598
| -rw-r--r-- | xlators/mgmt/glusterd/src/glusterd3_1-mops.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/xlators/mgmt/glusterd/src/glusterd3_1-mops.c b/xlators/mgmt/glusterd/src/glusterd3_1-mops.c index b5ac57194f1..09b6b175444 100644 --- a/xlators/mgmt/glusterd/src/glusterd3_1-mops.c +++ b/xlators/mgmt/glusterd/src/glusterd3_1-mops.c @@ -1342,7 +1342,6 @@ glusterd_handle_rpc_msg (rpcsvc_request_t *req) { int ret = -1; gf_boolean_t is_cli_req = _gf_false; - char *op_errstr = NULL; int lock_fail = 0; GF_ASSERT (req); @@ -1490,10 +1489,9 @@ out: request, which causes double replies */ if (!lock_fail) (void) glusterd_opinfo_unlock (); - ret = glusterd_op_send_cli_response (req->procnum, ret, 0, req, NULL, op_errstr); + ret = glusterd_op_send_cli_response (req->procnum, ret, 0, req, NULL, "operation failed"); } - if (op_errstr && (strcmp (op_errstr, ""))) - GF_FREE (op_errstr); + if (ret) gf_log ("", GF_LOG_WARNING, "Returning %d", ret); |