summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSachidananda <sac@gluster.com>2010-05-18 00:05:47 +0000
committerAnand V. Avati <avati@dev.gluster.com>2010-05-21 00:32:23 -0700
commit608223c792fc308729b522777efad4c6afb8238c (patch)
treef994dffd8450b2a71140a06247afbd215b9ef90e
parentde1fbd0fc7d81d9c6f2091a3c94e3dc02d0a3577 (diff)
Log proper error message when hostname or ip does not conform to standards.
Signed-off-by: "Sachidananda Urs" <sac@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 923 (Hostnames with underscores fail) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=923
-rw-r--r--libglusterfs/src/xlator.c7
1 files changed, 6 insertions, 1 deletions
diff --git a/libglusterfs/src/xlator.c b/libglusterfs/src/xlator.c
index bc36173d142..fe688a9513d 100644
--- a/libglusterfs/src/xlator.c
+++ b/libglusterfs/src/xlator.c
@@ -603,7 +603,12 @@ _volume_option_value_validate (xlator_t *xl,
{
if (valid_internet_address (pair->value->data)) {
ret = 0;
- }
+ } else {
+ gf_log (xl->name, GF_LOG_ERROR, "internet address '%s'"
+ " does not conform to standards.",
+ pair->value->data);
+ goto out;
+ }
}
break;
case GF_OPTION_TYPE_ANY: