diff options
| author | Shehjar Tikoo <shehjart@gluster.com> | 2010-09-02 05:05:57 +0000 |
|---|---|---|
| committer | Vijay Bellur <vijay@dev.gluster.com> | 2010-09-02 05:17:19 -0700 |
| commit | 419e787880bacf8f3c85880a57a52ac4e532430b (patch) | |
| tree | 3c38b7e59f01d009a5a5f4c2f133a3aa24314d2a | |
| parent | 132d951d4392c4f0fd9aa012626b861b49ccaa8d (diff) | |
nfs3: Do not unref dst inode on rename cbk
This gets done when the call state gets wiped. Doing it here results
an extra unref causing a segfault.
Signed-off-by: Shehjar Tikoo <shehjart@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1464 (fd leak after rename)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1464
| -rw-r--r-- | xlators/nfs/server/src/nfs3.c | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/xlators/nfs/server/src/nfs3.c b/xlators/nfs/server/src/nfs3.c index 3aed70a97d5..057ccb60e25 100644 --- a/xlators/nfs/server/src/nfs3.c +++ b/xlators/nfs/server/src/nfs3.c @@ -3282,12 +3282,6 @@ nfs3svc_rename_cbk (call_frame_t *frame, void *cookie, xlator_t *this, nfs3_fdcache_remove (cs->nfs3state, openfd); } - /* This is the unref equivalent of the ref done when the inode was - * created on a lookup or a create request. - * The inode is finally unrefed in call state wipe. - */ - inode_unref (cs->resolvedloc.inode); - nfs3err: nfs3_log_common_res (nfs_rpcsvc_request_xid (cs->req), "RENAME", stat, -ret); |