summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorNiels de Vos <ndevos@redhat.com>2015-06-05 16:38:30 +0200
committerNiels de Vos <ndevos@redhat.com>2015-06-10 16:01:58 -0700
commitec7d0c3de11cbee1470308dcc10ec9f02e7fdfff (patch)
tree2ae46b2cc2c3a8cafea78f847b3b6bf83201841a
parent5b05d3e376e984f00528f5bf2f0febd0220ca91f (diff)
logging: log "Stale filehandle" on the client as Debug
There are valid use-cases where a "Stale filehandle" is expected. One of these is deleting a file through NFS-Ganesha. When the "filename" is deleted, Ganesha will stat the file-handle to update its attributes. The file-handle would still be valid in the case where there are hardlinks. There is no need to log "Stale filehandle" as Warning. It is perfectly fine to have this logged as Debug. Change-Id: Ib9006d95a5d1f7dd394bf5d5994ad70740ad4ab2 BUG: 1228731 Signed-off-by: Niels de Vos <ndevos@redhat.com> Reviewed-on: http://review.gluster.org/11107 Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com> Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: soumya k <skoduri@redhat.com> Reviewed-by: jiffin tony Thottan <jthottan@redhat.com>
-rw-r--r--xlators/protocol/client/src/client-rpc-fops.c7
1 files changed, 5 insertions, 2 deletions
diff --git a/xlators/protocol/client/src/client-rpc-fops.c b/xlators/protocol/client/src/client-rpc-fops.c
index d08565de7af..b15c863dee1 100644
--- a/xlators/protocol/client/src/client-rpc-fops.c
+++ b/xlators/protocol/client/src/client-rpc-fops.c
@@ -471,7 +471,6 @@ client3_3_stat_cbk (struct rpc_req *req, struct iovec *iov, int count,
xlator_t *this = NULL;
dict_t *xdata = NULL;
-
this = THIS;
frame = myframe;
@@ -499,7 +498,11 @@ client3_3_stat_cbk (struct rpc_req *req, struct iovec *iov, int count,
out:
if (rsp.op_ret == -1) {
- gf_log (this->name, GF_LOG_WARNING, "remote operation failed: %s",
+ /* stale filehandles are possible during normal operations, no
+ * need to spam the logs with these */
+ gf_log (this->name,
+ rsp.op_errno == ESTALE ? GF_LOG_DEBUG : GF_LOG_WARNING,
+ "remote operation failed: %s",
strerror (gf_error_to_errno (rsp.op_errno)));
}