diff options
| author | Pranith Kumar K <pkarampu@redhat.com> | 2018-03-19 12:09:18 +0530 |
|---|---|---|
| committer | Pranith Kumar Karampuri <pkarampu@redhat.com> | 2018-03-20 08:57:37 +0000 |
| commit | 2a326ad32ecb3f90379ef8f3c14c8d14dc64a3b7 (patch) | |
| tree | e6a778f25fa27b0a7be5bc1ea4b6b3c843d5ce78 | |
| parent | ccd7825334f294918f895768fbebf825084f2e5d (diff) | |
features/shard: Do list_del_init() while list memory is valid
Problem:
shard_post_lookup_fsync_handler() goes over the list of inode-ctx that need to
be fsynced and in cbk it removes each of the inode-ctx from the list. When the
first member of list is removed it tries to modifies list head's memory with
the latest next/prev and when this happens, there is no guarantee that the
list-head which is from stack memory of shard_post_lookup_fsync_handler() is
valid.
Fix:
Do list_del_init() in the loop before winding fsync.
BUG: 1557876
Change-Id: If429d3634219e1a435bd0da0ed985c646c59c2ca
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
| -rw-r--r-- | xlators/features/shard/src/shard.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/xlators/features/shard/src/shard.c b/xlators/features/shard/src/shard.c index 6c15bb3167e..52cf3d777f3 100644 --- a/xlators/features/shard/src/shard.c +++ b/xlators/features/shard/src/shard.c @@ -4521,7 +4521,6 @@ out: if (op_ret == 0) ctx->fsync_needed -= fsync_count; GF_ASSERT (ctx->fsync_needed >= 0); - list_del_init (&ctx->to_fsync_list); if (ctx->fsync_needed != 0) { list_add_tail (&ctx->to_fsync_list, &base_ictx->to_fsync_list); @@ -4596,6 +4595,7 @@ shard_post_lookup_fsync_handler (call_frame_t *frame, xlator_t *this) anon_fd = NULL; list_for_each_entry_safe (iter, tmp, ©, to_fsync_list) { + list_del_init (&iter->to_fsync_list); fsync_count = 0; shard_inode_ctx_get_fsync_count (iter->inode, this, &fsync_count); |