summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAnand Avati <avati@gluster.com>2009-11-28 05:34:11 +0000
committerAnand V. Avati <avati@dev.gluster.com>2009-11-28 21:30:06 -0800
commit1ec37aa78fccb45aa701a3380f6acf95819c7a39 (patch)
treefbc2aee11e49d86bafc40813724e32b979bd7672
parent915299aff39c993fbe21e68e9458100db519535e (diff)
protocol/server: fix improper validation of fd in server_rchecksum
state->fd validation should be done _after_ resolve_and_resume() Signed-off-by: Anand V. Avati <avati@blackhole.gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 315 (generation number support) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=315
-rw-r--r--xlators/protocol/server/src/server-protocol.c6
1 files changed, 0 insertions, 6 deletions
diff --git a/xlators/protocol/server/src/server-protocol.c b/xlators/protocol/server/src/server-protocol.c
index 6a085f953cf..9fc9adf14c7 100644
--- a/xlators/protocol/server/src/server-protocol.c
+++ b/xlators/protocol/server/src/server-protocol.c
@@ -5444,15 +5444,9 @@ server_rchecksum (call_frame_t *frame, xlator_t *bound_xl,
state->offset = ntoh64 (req->offset);
state->size = ntoh32 (req->len);
- GF_VALIDATE_OR_GOTO(bound_xl->name, state->fd, fail);
-
resolve_and_resume (frame, server_rchecksum_resume);
return 0;
-fail:
- server_rchecksum_cbk (frame, NULL, frame->this, -1, EINVAL, 0, NULL);
-
- return 0;
}