diff options
| author | Amar Tumballi <amar@gluster.com> | 2012-02-03 13:54:02 +0530 |
|---|---|---|
| committer | Vijay Bellur <vijay@gluster.com> | 2012-02-07 04:21:44 -0800 |
| commit | 0272f7de41fa529f51bc69fdaf694c77b47250f2 (patch) | |
| tree | 501194af413d895b719f1c94ed12cd918af47173 | |
| parent | 1969ef17591342af2148d3a740b368f8cc6f8d5d (diff) | |
protocol/client: assign the right value to 'conf' before de-refing it
variable assignment was done after it was actually getting de-referenced.
moved the assignment few lines up.
Change-Id: Id65e3e2d3dfe071e1c5b14c32488647070398ae4
BUG: 787117
Signed-off-by: Amar Tumballi <amar@gluster.com>
Reviewed-on: http://review.gluster.com/2712
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
| -rw-r--r-- | xlators/protocol/client/src/client3_1-fops.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/xlators/protocol/client/src/client3_1-fops.c b/xlators/protocol/client/src/client3_1-fops.c index 3d39fc579ff..e28079ff73c 100644 --- a/xlators/protocol/client/src/client3_1-fops.c +++ b/xlators/protocol/client/src/client3_1-fops.c @@ -4639,14 +4639,14 @@ client3_1_fremovexattr (call_frame_t *frame, xlator_t *this, if (!(args->fd && args->fd->inode)) goto unwind; + conf = this->private; + CLIENT_GET_REMOTE_FD(conf, args->fd, remote_fd, op_errno, unwind); memcpy (req.gfid, args->fd->inode->gfid, 16); req.name = (char *)args->name; req.fd = remote_fd; - conf = this->private; - ret = client_submit_request (this, &req, frame, conf->fops, GFS3_OP_FREMOVEXATTR, client3_1_fremovexattr_cbk, NULL, |