diff options
author | Kaushal M <kaushal@redhat.com> | 2013-09-10 15:33:00 +0530 |
---|---|---|
committer | Anand Avati <avati@redhat.com> | 2013-09-19 14:07:06 -0700 |
commit | ac92dccc8727acaa3c9e9353fba80817947552bf (patch) | |
tree | 887dd5e2c207e1d8772621133cd846662165a2f3 | |
parent | 0af0e6405d6911cf41d1ad1d4504baa842c1328e (diff) |
glusterd: Don't reset rebalance status on add-brick
Backport of 67c28b19355c47e96d1420405cc38753a3e5f9be from master
The rebalance status was being reset to 'Not started' when add-brick was
performed. This would lead to odd cases where a 'rebalance status' on a
volume would show status as 'not started' but would also include the
rebalance statistics. This also affected the showing of asynchronus task
status in 'volume status' command.
By not resetting the status prevent the above issues from happening.
Since we use the running/not-running of the rebalance process as the
check when performing other operations we can safely leave the rebalance
stats collected on an add-brick.
BUG: 1006247
Change-Id: Idade88d9e5a6f27659490b3e6d85495d426ef0a3
Signed-off-by: Kaushal M <kaushal@redhat.com>
Reviewed-on: http://review.gluster.org/5971
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@redhat.com>
-rw-r--r-- | xlators/mgmt/glusterd/src/glusterd-brick-ops.c | 9 |
1 files changed, 0 insertions, 9 deletions
diff --git a/xlators/mgmt/glusterd/src/glusterd-brick-ops.c b/xlators/mgmt/glusterd/src/glusterd-brick-ops.c index 112bfe22322..bc025caa320 100644 --- a/xlators/mgmt/glusterd/src/glusterd-brick-ops.c +++ b/xlators/mgmt/glusterd/src/glusterd-brick-ops.c @@ -1439,15 +1439,6 @@ glusterd_op_add_brick (dict_t *dict, char **op_errstr) goto out; } - /* Need to reset the defrag/rebalance status accordingly */ - switch (volinfo->rebal.defrag_status) { - case GF_DEFRAG_STATUS_FAILED: - case GF_DEFRAG_STATUS_COMPLETE: - volinfo->rebal.defrag_status = 0; - default: - break; - } - ret = glusterd_store_volinfo (volinfo, GLUSTERD_VOLINFO_VER_AC_INCREMENT); if (ret) goto out; |