diff options
| author | Anand <anekkunt@redhat.com> | 2015-01-09 14:24:08 +0530 |
|---|---|---|
| committer | Vijay Bellur <vbellur@redhat.com> | 2015-02-04 07:43:07 -0800 |
| commit | 3a332a834aac3f3a931b31dcaabe34901b309d6c (patch) | |
| tree | c92ac897fd6500812b61adcf590d35d3a7ea9d81 | |
| parent | ea6a31cd7c430768b8dfd3b4944fffde0be3a740 (diff) | |
libglusterfs : Corrected functions calls.
Problem : There was mismatch between arguments and parameters in some functions
(ex:glusterfs_uuid_buf_get,glusterfs_lkowner_buf_get). It could lead to stack overflow issues .
Fix : Arguments are removed during calling these function.
Change-Id: Icb41bd4119502d192d9cc7242d385ebe62cdb51a
BUG: 1180424
Signed-off-by: Anand <anekkunt@redhat.com>
Reviewed-on: http://review.gluster.org/9427
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Gaurav Kumar Garg <ggarg@redhat.com>
Reviewed-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
| -rw-r--r-- | libglusterfs/src/common-utils.c | 4 | ||||
| -rw-r--r-- | libglusterfs/src/globals.h | 4 |
2 files changed, 4 insertions, 4 deletions
diff --git a/libglusterfs/src/common-utils.c b/libglusterfs/src/common-utils.c index 6882b6c3178..6d03b09a943 100644 --- a/libglusterfs/src/common-utils.c +++ b/libglusterfs/src/common-utils.c @@ -2154,7 +2154,7 @@ mask_match(const uint32_t a, const uint32_t b, const uint32_t m) char * uuid_utoa (uuid_t uuid) { - char *uuid_buffer = glusterfs_uuid_buf_get(THIS->ctx); + char *uuid_buffer = glusterfs_uuid_buf_get (); uuid_unparse (uuid, uuid_buffer); return uuid_buffer; } @@ -2173,7 +2173,7 @@ uuid_utoa_r (uuid_t uuid, char *dst) char * lkowner_utoa (gf_lkowner_t *lkowner) { - char *lkowner_buffer = glusterfs_lkowner_buf_get(THIS->ctx); + char *lkowner_buffer = glusterfs_lkowner_buf_get (); lkowner_unparse (lkowner, lkowner_buffer, GF_LKOWNER_BUF_SIZE); return lkowner_buffer; } diff --git a/libglusterfs/src/globals.h b/libglusterfs/src/globals.h index ce1c64475f4..b9eaf8ad131 100644 --- a/libglusterfs/src/globals.h +++ b/libglusterfs/src/globals.h @@ -63,9 +63,9 @@ void *synctask_get (); int synctask_set (void *); /* uuid_buf */ -char *glusterfs_uuid_buf_get(); +char *glusterfs_uuid_buf_get (); /* lkowner_buf */ -char *glusterfs_lkowner_buf_get(); +char *glusterfs_lkowner_buf_get (); /* init */ int glusterfs_globals_init (glusterfs_ctx_t *ctx); |