diff options
| author | Sunny Kumar <sunkumar@redhat.com> | 2018-08-30 14:48:51 +0530 |
|---|---|---|
| committer | Atin Mukherjee <amukherj@redhat.com> | 2018-11-18 16:50:57 +0000 |
| commit | 5af9799ab7c6185a852c48ef6b8655d294a50d2d (patch) | |
| tree | 7d5a486c3f8507676a5f2ecb107b883e02edd162 | |
| parent | b4faa9e7a25bdf0582f8b0fd69aa1381c307a61e (diff) | |
cli : fix coverity issue in cli-xml-output.c
This patch fixes 1124659, 1241480 and 1274196.
Change-Id: Ib89f53b8e34fcc47184d08ad57f2ee32fd00d78c
updates: bz#789278
Signed-off-by: Sunny Kumar <sunkumar@redhat.com>
| -rw-r--r-- | cli/src/cli-xml-output.c | 10 |
1 files changed, 10 insertions, 0 deletions
diff --git a/cli/src/cli-xml-output.c b/cli/src/cli-xml-output.c index 5dbf37e3d5d..fa79066cb3a 100644 --- a/cli/src/cli-xml-output.c +++ b/cli/src/cli-xml-output.c @@ -3409,6 +3409,10 @@ cli_xml_output_vol_rebalance_status(xmlTextWriterPtr writer, dict_t *dict, "%" PRIu64, total_skipped); XML_RET_CHECK_AND_GOTO(ret, out); + if (overall_status == -1) { + overall_status = status_rcd; + } + ret = xmlTextWriterWriteFormatElement(writer, (xmlChar *)"status", "%d", overall_status); XML_RET_CHECK_AND_GOTO(ret, out); @@ -4103,6 +4107,8 @@ cli_xml_output_vol_gsync_status(dict_t *dict, xmlTextWriterPtr writer) } } out: + if (status_values) + GF_FREE(status_values); gf_log("cli", GF_LOG_DEBUG, "Returning %d", ret); return ret; } @@ -4178,6 +4184,10 @@ cli_xml_output_vol_gsync(dict_t *dict, int op_ret, int op_errno, break; case GF_GSYNC_OPTION_TYPE_STATUS: ret = cli_xml_output_vol_gsync_status(dict, writer); + if (ret) { + gf_log("cli", GF_LOG_DEBUG, "Failed to get gsync status"); + goto out; + } break; default: ret = 0; |