diff options
| author | Sanju Rakonde <srakonde@redhat.com> | 2019-04-26 22:28:53 +0530 |
|---|---|---|
| committer | Sanju Rakonde <srakonde@redhat.com> | 2019-04-27 19:06:11 +0530 |
| commit | 5d866c13efdcdeddf184f012aa88a652e90ff22e (patch) | |
| tree | f1079622b16b47bbe711fa3a37dd671414728955 | |
| parent | e10946dbfe18204d3e4a50e218ac3dbdab82a3a9 (diff) | |
glusterd: define dumpops in the xlator_api of glusterd
Problem: statedump is not capturing information related to glusterd
Solution: statdump is not capturing glusterd info because
trav->dumpops is null in gf_proc_dump_single_xlator_info ()
where trav is glusterd xlator object. trav->dumpops is null
because we missed to define dumpops in xlator_api of glusterd.
defining dumpops in xlator_api of glusterd fixes the issue.
fixes: bz#1703629
Change-Id: If85429ecb1ef580aced8d5b88d09fc15258bfc4c
Signed-off-by: Sanju Rakonde <srakonde@redhat.com>
| -rw-r--r-- | tests/bugs/glusterd/optimized-basic-testcases.t | 13 | ||||
| -rw-r--r-- | xlators/mgmt/glusterd/src/glusterd.c | 1 |
2 files changed, 14 insertions, 0 deletions
diff --git a/tests/bugs/glusterd/optimized-basic-testcases.t b/tests/bugs/glusterd/optimized-basic-testcases.t index dd98a65fa9a..d700b5ed5af 100644 --- a/tests/bugs/glusterd/optimized-basic-testcases.t +++ b/tests/bugs/glusterd/optimized-basic-testcases.t @@ -32,6 +32,16 @@ function get_brick_host_uuid() echo $host_uuid_list | awk '{print $1}' } +function generate_statedump_and_check_for_glusterd_info { + pid=`pidof glusterd` + #remove old stale statedumps + cleanup_statedump $pid + kill -USR1 $pid + #Wait till the statedump is generated + sleep 1 + fname=$(ls $statedumpdir | grep -E "\.$pid\.dump\.") + cat $statedumpdir/$fname | grep "xlator.glusterd.priv" | wc -l +} cleanup; @@ -279,4 +289,7 @@ mkdir -p /xyz/var/lib/glusterd/abc TEST $CLI volume create "test" $H0:/xyz/var/lib/glusterd/abc EXPECT 'Created' volinfo_field "test" 'Status'; +EXPECT "1" generate_statedump_and_check_for_glusterd_info + +cleanup_statedump `pidof glusterd` cleanup diff --git a/xlators/mgmt/glusterd/src/glusterd.c b/xlators/mgmt/glusterd/src/glusterd.c index d4ab63095e2..c0973cb2bea 100644 --- a/xlators/mgmt/glusterd/src/glusterd.c +++ b/xlators/mgmt/glusterd/src/glusterd.c @@ -2231,6 +2231,7 @@ xlator_api_t xlator_api = { .fini = fini, .mem_acct_init = mem_acct_init, .op_version = {1}, /* Present from the initial version */ + .dumpops = &dumpops, .fops = &fops, .cbks = &cbks, .options = options, |