diff options
| author | Pranith Kumar K <pkarampu@redhat.com> | 2015-04-26 17:59:49 +0530 |
|---|---|---|
| committer | Vijay Bellur <vbellur@redhat.com> | 2015-05-02 02:39:37 -0700 |
| commit | b8a5d23ac69c686242262bff43583d3871fff2c0 (patch) | |
| tree | 22e3886da677e4266998a1b4fbd27956e167b741 | |
| parent | 52e005c450ef0d2de41efb6cb82e6f83d6228976 (diff) | |
storage/posix: prevent NULL dereference
Backport of http://review.gluster.org/10383
filler->fd is never set but used.
BUG: 1216303
Change-Id: I02dc346c526be5af4ea55ae13e8314316f127455
Signed-off-by: Pranith Kumar K <pkarampu@redhat.com>
Reviewed-on: http://review.gluster.org/10437
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Tested-by: NetBSD Build System
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
| -rw-r--r-- | xlators/storage/posix/src/posix.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/xlators/storage/posix/src/posix.c b/xlators/storage/posix/src/posix.c index 50dae5db18d..6b6f7675a89 100644 --- a/xlators/storage/posix/src/posix.c +++ b/xlators/storage/posix/src/posix.c @@ -4677,7 +4677,7 @@ _posix_handle_xattr_keyvalue_pair (dict_t *d, char *k, data_t *v, "fgetxattr failed on gfid=%s " "while doing xattrop: " "Key:%s (%s)", - uuid_utoa (filler->fd->inode->gfid), + uuid_utoa (filler->inode->gfid), k, strerror (op_errno)); } @@ -4732,7 +4732,7 @@ unlock: gf_log (this->name, GF_LOG_ERROR, "fsetxattr failed on gfid=%s while doing xattrop: " "key=%s (%s)", - uuid_utoa (filler->fd->inode->gfid), + uuid_utoa (filler->inode->gfid), k, strerror (op_errno)); op_ret = -1; @@ -4750,7 +4750,7 @@ unlock: gf_log (this->name, GF_LOG_DEBUG, "dict_set_bin failed (gfid=%s): " "key=%s (%s)", - uuid_utoa (filler->fd->inode->gfid), + uuid_utoa (filler->inode->gfid), k, strerror (-size)); op_ret = -1; |