summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorKrutika Dhananjay <kdhananj@redhat.com>2013-02-21 16:22:38 +0530
committerVijay Bellur <vbellur@redhat.com>2013-03-04 00:21:45 -0800
commit6a303c8b9ce01d17453914841f5b61bf9daf91ac (patch)
treea86230cc8826838a25c2b075cc5c7f5d94aeeb4d
parenteb3b05581e2533f89df04ea75f5c4247045f07dc (diff)
glusterd: use gf_strdup() in place of strdup()
Change-Id: Idee71019dbc6eeaa0a808d671b29d6f3038a1a89 BUG: 913487 Signed-off-by: Krutika Dhananjay <kdhananj@redhat.com> Reviewed-on: http://review.gluster.org/4563 Tested-by: Gluster Build System <jenkins@build.gluster.com> Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
-rw-r--r--tests/bugs/bug-913487.t14
-rw-r--r--xlators/mgmt/glusterd/src/glusterd-op-sm.c2
2 files changed, 15 insertions, 1 deletions
diff --git a/tests/bugs/bug-913487.t b/tests/bugs/bug-913487.t
new file mode 100644
index 00000000000..2095903d9d2
--- /dev/null
+++ b/tests/bugs/bug-913487.t
@@ -0,0 +1,14 @@
+#!/bin/bash
+
+. $(dirname $0)/../include.rc
+
+cleanup;
+
+TEST glusterd;
+TEST pidof glusterd;
+
+TEST ! $CLI volume set $V0 performance.open-behind off;
+
+TEST pidof glusterd;
+
+cleanup;
diff --git a/xlators/mgmt/glusterd/src/glusterd-op-sm.c b/xlators/mgmt/glusterd/src/glusterd-op-sm.c
index 29c03d6961e..7d84e664de7 100644
--- a/xlators/mgmt/glusterd/src/glusterd-op-sm.c
+++ b/xlators/mgmt/glusterd/src/glusterd-op-sm.c
@@ -2405,7 +2405,7 @@ glusterd_dict_set_volid (dict_t *dict, char *volname, char **op_errstr)
out:
if (msg[0] != '\0') {
gf_log (this->name, GF_LOG_ERROR, "%s", msg);
- *op_errstr = strdup (msg);
+ *op_errstr = gf_strdup (msg);
}
return ret;
}