summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorKotresh HR <khiremat@redhat.com>2018-05-07 06:35:25 -0400
committerShyamsundar Ranganathan <srangana@redhat.com>2018-08-15 18:40:31 +0000
commitf33a61086da43af5a5de2ba99b4045a63cf5bd79 (patch)
tree22a723de9d53388b4aecd9ae3982fac0eb19c26c
parent802cf5b1b374a566f362da74f08106f3b3969155 (diff)
glusterd/geo-rep: Fix glusterd crash
Using strdump instead of gf_strdup crashes during free if mempool is being used. gf_free checks the magic number in the header which will not be taken care if strdup is used. Backport of: > BUG: 1576392 > Change-Id: Iab36496554b838a036af9d863e3f5fd07fd9780e > Signed-off-by: Kotresh HR <khiremat@redhat.com> fixes: bz#1611106 Change-Id: Iab36496554b838a036af9d863e3f5fd07fd9780e Signed-off-by: Kotresh HR <khiremat@redhat.com>
-rw-r--r--xlators/mgmt/glusterd/src/glusterd-geo-rep.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/xlators/mgmt/glusterd/src/glusterd-geo-rep.c b/xlators/mgmt/glusterd/src/glusterd-geo-rep.c
index 25193e2a51f..30e1bec96e4 100644
--- a/xlators/mgmt/glusterd/src/glusterd-geo-rep.c
+++ b/xlators/mgmt/glusterd/src/glusterd-geo-rep.c
@@ -5645,7 +5645,7 @@ glusterd_op_gsync_set (dict_t *dict, char **op_errstr, dict_t *rsp_dict)
GD_MSG_GSYNCD_OP_SET_FAILED, GEOREP" is not "
"set up for %s(master) and %s(slave)",
volname, slave);
- *op_errstr = strdup (GEOREP" is not set up");
+ *op_errstr = gf_strdup (GEOREP" is not set up");
goto out;
}