diff options
| author | Amar Tumballi <amar@kadalu.io> | 2020-03-04 00:46:08 +0530 |
|---|---|---|
| committer | hari gowtham <hari.gowtham005@gmail.com> | 2020-04-22 05:22:37 +0000 |
| commit | 4d6f1bed68cabfc2ce76316892ce0a1726d879b8 (patch) | |
| tree | cf69f7e371fb7f22a927803ed0c8e15331e3f179 | |
| parent | ce037b615c46c27278fa91065643ec51ceb764df (diff) | |
utime: resolve an issue of permission denied logs
In case where uid is not set to be 0, there are possible errors
from acl xlator. So, set `uid = 0;` with pid indicating this is
set from UTIME activity.
The message "E [MSGID: 148002] [utime.c:146:gf_utime_set_mdata_setxattr_cbk] 0-dev_SNIP_data-utime: dict set of key for set-ctime-mdata failed [Permission denied]" repeated 2 times between [2019-12-19 21:27:55.042634] and [2019-12-19 21:27:55.047887]
Change-Id: Ieadf329835a40a13ac0bf908dac776e66954466c
Fixes: #832
Signed-off-by: Amar Tumballi <amar@kadalu.io>
(cherry picked from commit eb916c057036db8289b41265797e5dce066d1512)
| -rw-r--r-- | libglusterfs/src/glusterfs/common-utils.h | 3 | ||||
| -rw-r--r-- | xlators/features/utime/src/utime.c | 10 |
2 files changed, 12 insertions, 1 deletions
diff --git a/libglusterfs/src/glusterfs/common-utils.h b/libglusterfs/src/glusterfs/common-utils.h index 0e2ecc73af1..dd661ddcf55 100644 --- a/libglusterfs/src/glusterfs/common-utils.h +++ b/libglusterfs/src/glusterfs/common-utils.h @@ -169,7 +169,8 @@ enum _gf_special_pid { GF_CLIENT_PID_SCRUB = -9, GF_CLIENT_PID_TIER_DEFRAG = -10, GF_SERVER_PID_TRASH = -11, - GF_CLIENT_PID_ADD_REPLICA_MOUNT = -12 + GF_CLIENT_PID_ADD_REPLICA_MOUNT = -12, + GF_CLIENT_PID_SET_UTIME = -13, }; enum _gf_xlator_ipc_targets { diff --git a/xlators/features/utime/src/utime.c b/xlators/features/utime/src/utime.c index e3a80b6ed48..c9dfec51a7e 100644 --- a/xlators/features/utime/src/utime.c +++ b/xlators/features/utime/src/utime.c @@ -192,8 +192,18 @@ gf_utime_set_mdata_lookup_cbk(call_frame_t *frame, void *cookie, xlator_t *this, loc.inode = inode_ref(inode); gf_uuid_copy(loc.gfid, stbuf->ia_gfid); + + pid_t pid = frame->root->pid; + uid_t uid = frame->root->uid; + gid_t gid = frame->root->gid; + frame->root->uid = 0; + frame->root->gid = 0; + frame->root->pid = GF_CLIENT_PID_SET_UTIME; STACK_WIND(frame, gf_utime_set_mdata_setxattr_cbk, FIRST_CHILD(this), FIRST_CHILD(this)->fops->setxattr, &loc, dict, 0, NULL); + frame->root->uid = uid; + frame->root->gid = gid; + frame->root->pid = pid; dict_unref(dict); inode_unref(loc.inode); |