diff options
| author | Atin Mukherjee <amukherj@redhat.com> | 2016-03-28 10:49:43 +0530 |
|---|---|---|
| committer | Kaushal M <kaushal@redhat.com> | 2016-03-31 00:53:44 -0700 |
| commit | 2cd5b752c1123095acff5ce57649393ab1de7aaf (patch) | |
| tree | 77c875a0e274902a71760c5a4dc8452be26a4666 | |
| parent | 116419f3cb7b5711b0881428c2deda829b43e782 (diff) | |
libglusterfs: open cmd_history log file with O_APPEND and O_WRONLY
Commit 8fdfa0c introduced a fix to ensure cmd_history file is log rotated
properly. However with this fix fdopen() is called with mode "a" on a fd which
was not opened with O_WRONLY & O_APPEND resulting into a fdopen() failure.
Fix is to open cmd_history.log file with O_CREATE|O_WRONLY|O_APPEND mode
Backport of commit 207289621f6c5b75bdb80aa14ddaf72efd5eb9b1:
> Change-Id: I75ef350560aa6d5435c78c5fd83adfde1a73bfc3
> BUG: 1286959
> Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
> Reviewed-on: http://review.gluster.org/13829
> Smoke: Gluster Build System <jenkins@build.gluster.com>
> Reviewed-by: Niels de Vos <ndevos@redhat.com>
> NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
> CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
Change-Id: I75ef350560aa6d5435c78c5fd83adfde1a73bfc3
BUG: 1304963
Signed-off-by: Atin Mukherjee <amukherj@redhat.com>
Reviewed-on: http://review.gluster.org/13847
NetBSD-regression: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Smoke: Gluster Build System <jenkins@build.gluster.com>
CentOS-regression: Gluster Build System <jenkins@build.gluster.com>
| -rw-r--r-- | libglusterfs/src/logging.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/libglusterfs/src/logging.c b/libglusterfs/src/logging.c index e33acf44bfd..2d0a4eacfea 100644 --- a/libglusterfs/src/logging.c +++ b/libglusterfs/src/logging.c @@ -2443,7 +2443,7 @@ gf_cmd_log (const char *domain, const char *fmt, ...) } fd = open (ctx->log.cmd_log_filename, - O_CREAT | O_RDONLY, S_IRUSR | S_IWUSR); + O_CREAT | O_WRONLY | O_APPEND, S_IRUSR | S_IWUSR); if (fd < 0) { gf_msg (THIS->name, GF_LOG_CRITICAL, errno, LG_MSG_FILE_OP_FAILED, "failed to open " |