diff options
author | Ravishankar N <ravishankar@redhat.com> | 2014-12-01 10:08:53 +0000 |
---|---|---|
committer | Pranith Kumar Karampuri <pkarampu@redhat.com> | 2014-12-04 02:31:33 -0800 |
commit | 811abf66d158efa037f1314792f7c674a7640c50 (patch) | |
tree | 59894506581228ca7caef46259fa8b1c5262f3a3 | |
parent | ac4c203bfb4c3ebe48a08ef695ee462ba9b5e2c7 (diff) |
heal: free leaked frames.
'gluster v heal <VOLNAME> info` waits for about 10 seconds before printing the
heal info and exiting.
Problem: glfsh_process_entries() is not freeing the frames it created.
Thus when glfs_fini() is called, it busy waits for 10 seconds for background
frames to finish before returning error.
Fix: Destroy the frames in that are created in glfsh_process_entries().
Change-Id: I5484d1b7301a355b913ae9c15b8a62471036c755
BUG: 1169335
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
Reviewed-on: http://review.gluster.org/9224
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
Tested-by: Pranith Kumar Karampuri <pkarampu@redhat.com>
-rw-r--r-- | heal/src/glfs-heal.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/heal/src/glfs-heal.c b/heal/src/glfs-heal.c index e01e98df0e9..1056ea467c4 100644 --- a/heal/src/glfs-heal.c +++ b/heal/src/glfs-heal.c @@ -350,6 +350,8 @@ out: inode_unref (inode); } + if (frame) + AFR_STACK_DESTROY (frame); GF_FREE (path); return ret; } |