diff options
| author | Venky Shankar <vshankar@redhat.com> | 2012-10-05 15:44:22 +0530 |
|---|---|---|
| committer | Anand Avati <avati@redhat.com> | 2012-10-17 00:16:05 -0700 |
| commit | 59dfcf15578e08731f80c1f0c88cd4b7cd79d23d (patch) | |
| tree | 8f03abeeafad6b346590dbecb288316cbab0b1bc | |
| parent | 53e49e8592140d9f9d2134df6bb8322276e27cff (diff) | |
cluster/dht: ignore empty ->hashed_subvol during lookup
->hashed_subvol is not valid (== NULL) when the subvolume
the entity hashes to is down. For directories, we need not
rely on ->hashed_subvol as we aggregate information from all
subvolumes. So, during lookup, NULL ->hashed_subvol is ingored
but logged.
Change-Id: I306e4e274fe29d60ff028add4a6c3bcd67b2f314
Signed-off-by: Venky Shankar <vshankar@redhat.com>
BUG: 856459
Reviewed-on: http://review.gluster.org/4046
Reviewed-by: Anand Avati <avati@redhat.com>
Tested-by: Anand Avati <avati@redhat.com>
| -rw-r--r-- | xlators/cluster/dht/src/dht-common.c | 10 |
1 files changed, 1 insertions, 9 deletions
diff --git a/xlators/cluster/dht/src/dht-common.c b/xlators/cluster/dht/src/dht-common.c index 366982e31e2..f1f9818902f 100644 --- a/xlators/cluster/dht/src/dht-common.c +++ b/xlators/cluster/dht/src/dht-common.c @@ -1391,16 +1391,8 @@ dht_lookup (call_frame_t *frame, xlator_t *this, return 0; } - if (!hashed_subvol) { + if (!hashed_subvol) hashed_subvol = dht_subvol_get_hashed (this, loc); - if (!hashed_subvol) { - gf_log (this->name, GF_LOG_ERROR, - "Failed to get hashed subvol for %s", - loc->path); - op_errno = EINVAL; - goto err; - } - } local->hashed_subvol = hashed_subvol; if (is_revalidate (loc)) { |